Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no such device error when non interactive mode #2514

Merged
merged 3 commits into from
Feb 8, 2023
Merged

fix no such device error when non interactive mode #2514

merged 3 commits into from
Feb 8, 2023

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Feb 6, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • added an environmental variable for specifying encryption passphrase for Keystore,
  • fixed a case where running Forest in headless mode would cause a cryptic no such device error. Now it will enforce setting the passphrase via the environmental variable unless the encryption is explicitly disabled.

Reference issue to close (if applicable)

Closes #2499

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic added this to the Forest 🌲 Infrastructure milestone Feb 6, 2023
@LesnyRumcajs LesnyRumcajs marked this pull request as draft February 6, 2023 18:35
@LesnyRumcajs LesnyRumcajs force-pushed the fix-no-such-device-non-interactive-mode branch 2 times, most recently from 4ff8243 to df1ff12 Compare February 8, 2023 10:50
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review February 8, 2023 11:56
LesnyRumcajs
LesnyRumcajs commented Feb 8, 2023
View reviewed changes
forest/daemon/tests/keystore_tests.rs
use tempfile::TempDir;

// https://github.com/ChainSafe/forest/issues/2499
#[test]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More cases should be implemented once #2528 is done.

@LesnyRumcajs LesnyRumcajs enabled auto-merge (squash) February 8, 2023 14:50
@LesnyRumcajs LesnyRumcajs force-pushed the fix-no-such-device-non-interactive-mode branch from 061b473 to b6c53b7 Compare February 8, 2023 15:09
@LesnyRumcajs LesnyRumcajs merged commit c395cea into main Feb 8, 2023
@LesnyRumcajs LesnyRumcajs deleted the fix-no-such-device-non-interactive-mode branch February 8, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmattic elmattic elmattic approved these changes

@lemmih lemmih Awaiting requested review from lemmih

@jdjaustin jdjaustin Awaiting requested review from jdjaustin

@tyshko5 tyshko5 Awaiting requested review from tyshko5

@creativcoder creativcoder Awaiting requested review from creativcoder

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker no such device error when running in non-interactive mode
3 participants
@LesnyRumcajs @hanabi1224 @elmattic