CircleCI updates, removal of github actions #813
Conversation
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
| @@ -140,15 +211,89 @@ jobs: | |||
| - run: | |||
| name: Run test vectors | |||
| command: make run-vectors | |||
| install: | |||
| coverage: | |||
| executor: mac-executor | |||
There was a problem hiding this comment.
this should maybe use the linux executor? or is this intentional?
There was a problem hiding this comment.
This is intentional, I kept getting unexpected issues while running in the linux executor. I plan to investigate this more as its likely somehow caused by the grcov env vars but for now should be sufficient.
There was a problem hiding this comment.
Maybe add a TODO comment to indicate this, so it doesn't get lost in the future? Or some mechanism to come back to this?
.circleci/config.yml
Outdated
| name: Upload to codecov | ||
| command: | | ||
| zip -0 ccov.zip `find . \( -name "forest*.gc*" \) -print`; | ||
| ./grcov ccov.zip -s . -t lcov --llvm --branch --ignore-not-existing --ignore "/*" --ignore="target/debug/build/*" --ignore="tests/*" --ignore="blockchain/beacon/tests/*" -o lcov.info; |
There was a problem hiding this comment.
| ./grcov ccov.zip -s . -t lcov --llvm --branch --ignore-not-existing --ignore "/*" --ignore="target/debug/build/*" --ignore="tests/*" --ignore="blockchain/beacon/tests/*" -o lcov.info; | |
| ./grcov ccov.zip -s . -t lcov --llvm --branch --ignore-not-existing --ignore "/*" --ignore="target/debug/build/*" --ignore="**/tests/*" -o lcov.info; |
| @@ -140,15 +211,89 @@ jobs: | |||
| - run: | |||
| name: Run test vectors | |||
| command: make run-vectors | |||
| install: | |||
| coverage: | |||
| executor: mac-executor | |||
There was a problem hiding this comment.
Maybe add a TODO comment to indicate this, so it doesn't get lost in the future? Or some mechanism to come back to this?
|
@ec2 @austinabell sorry had to update readme badges |
Summary of changes
Changes introduced in this pull request:
I think we are able to take advantage of parallelism within container for test vectors as defined here but I could not get it to split the tests out correctly.
Reference issue to close (if applicable)
Closes #467
Other information and links