-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI updates, removal of github actions #813
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1fe7406
Added code cov, nightly and macos builds removed github actions
dutterbutter ac72973
linted and cleaned
dutterbutter bbd9bde
Updated security vulnerability
dutterbutter da319ac
updated dependency
dutterbutter e19db7e
resolved conflicts
dutterbutter 88ace9e
resolved conflicts
dutterbutter f7a09b1
coverage should only run on main
dutterbutter f070680
fixed grcov cmd
dutterbutter ec19460
Merge branch 'main' of github.com:ChainSafe/forest into db/ci-wrk
dutterbutter 5005507
add todo comment
dutterbutter 2e27aeb
updated readme badges
dutterbutter 097bc95
Merge branch 'main' into db/ci-wrk
dutterbutter 3fd7966
fixed badge styles
dutterbutter 2e9e541
Merge branch 'db/ci-wrk' of github.com:ChainSafe/forest into db/ci-wrk
dutterbutter c1d59cf
Merge branch 'main' into db/ci-wrk
dutterbutter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should maybe use the linux executor? or is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional, I kept getting unexpected issues while running in the linux executor. I plan to investigate this more as its likely somehow caused by the grcov env vars but for now should be sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a TODO comment to indicate this, so it doesn't get lost in the future? Or some mechanism to come back to this?