Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging to hide internal messages by default #954

Merged
merged 4 commits into from
Jan 26, 2021
Merged

Update logging to hide internal messages by default #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1bcbc4
Update logging to hide internal messages by default
austinabell Jan 23, 2021
f60747a
Merge branch 'main' of github.com:ChainSafe/forest into austin/vm/log…
austinabell Jan 25, 2021
adf1ec8
Merge branch 'main' of github.com:ChainSafe/forest into austin/vm/log…
austinabell Jan 25, 2021
29c6caf
Merge branch 'main' of github.com:ChainSafe/forest into austin/vm/log…
austinabell Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vm/actor/src/builtin/power/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ impl Actor {
e.downcast_default(ExitCode::ErrIllegalState, "failed to look up claim")
})?;
if !contains_claim {
log::warn!("skipping batch verifies for unknown miner: {}", addr);
log::debug!("skipping batch verifies for unknown miner: {}", addr);
return Ok(());
}

Expand Down Expand Up @@ -507,7 +507,7 @@ impl Actor {
)
})?;
if !miner_has_claim {
log::warn!("skipping cron event for unknown miner: {}", evt.miner_addr);
log::debug!("skipping cron event for unknown miner: {}", evt.miner_addr);
continue;
}
cron_events.push(evt);
Expand Down Expand Up @@ -542,7 +542,7 @@ impl Actor {
// Failures are unexpected here but will result in removal of miner power
// A log message would really help here.
if let Err(e) = res {
log::warn!(
log::debug!(
"OnDeferredCronEvent failed for miner {}: res {}",
event.miner_addr,
e
Expand Down
6 changes: 3 additions & 3 deletions vm/interpreter/src/default_runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use fil_types::{verifier::ProofVerifier, DevnetParams, NetworkParams, NetworkVer
use fil_types::{PieceInfo, RegisteredSealProof, SealVerifyInfo, WindowPoStVerifyInfo};
use forest_encoding::{blake2b_256, to_vec, Cbor};
use ipld_blockstore::BlockStore;
use log::warn;
use log::debug;
use message::{Message, UnsignedMessage};
use num_bigint::BigInt;
use num_traits::Zero;
Expand Down Expand Up @@ -717,7 +717,7 @@ where
let ret = self
.internal_send(*self.message().receiver(), to, method, value, params)
.map_err(|e| {
warn!(
debug!(
"internal send failed: (to: {}) (method: {}) {}",
to, method, e
);
Expand Down Expand Up @@ -990,7 +990,7 @@ where
.par_iter()
.map(|s| {
if let Err(err) = V::verify_seal(s) {
warn!(
debug!(
"seal verify in batch failed (miner: {}) (err: {})",
addr, err
);
Expand Down
4 changes: 2 additions & 2 deletions vm/interpreter/src/vm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use fil_types::{
};
use forest_encoding::Cbor;
use ipld_blockstore::BlockStore;
use log::warn;
use log::debug;
use message::{ChainMessage, Message, MessageReceipt, UnsignedMessage};
use networks::UPGRADE_CLAUS_HEIGHT;
use num_bigint::{BigInt, Sign};
Expand Down Expand Up @@ -387,7 +387,7 @@ where
err
));
} else {
warn!(
debug!(
"[from={}, to={}, seq={}, m={}] send error: {}",
msg.from(),
msg.to(),
Expand Down