Introduced parachain candidate validation #3249

kishansagathiya · 2023-05-09T06:30:14Z

This commit adds all the functions required for parachain candidate validations.

With this commit, we are able to take candidate receipts and
- get validation data for it,
- perform basic checks on it,
- run respective parachain's validate_block on parachain's runtime,
- get validate results from parachain's runtime and verify those validation results again relaychain runtime,
- and declare candidate as valid or invalid in the end.

This commit also includes tests for candidate validation.

Implement 3 require import calls or create and issue for them.

This is a simpler version. Eventually as other parts get implemented, we will redo this so that we call run multiple validation code in async way.

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

#2989

Primary Reviewer

@timwu20

This commit adds all the functions required for parachain candidate validations. With this commit, we are able to take candidate receipts and - get validation data for it, - perform basic checks on it, - run respective parachain's validate_block on parachain's runtime, - get validate results from parachain's runtime and verify those validation results again relaychain runtime, - and declare candidate as valid or invalid in the end. This commit also includes tests for candidate validation.

codecov · 2023-05-09T06:35:06Z

Codecov Report

Merging #3249 (a255619) into feat/parachain (46892e5) will decrease coverage by 0.31%.
The diff coverage is 45.32%.

❗ Current head a255619 differs from pull request most recent head 73a4b62. Consider uploading reports for the commit 73a4b62 to get more accurate results

Additional details and impacted files

@@                Coverage Diff                 @@
##           feat/parachain    #3249      +/-   ##
==================================================
- Coverage           50.97%   50.66%   -0.31%     
==================================================
  Files                 247      249       +2     
  Lines               31829    31968     +139     
==================================================
- Hits                16224    16198      -26     
- Misses              13873    14021     +148     
- Partials             1732     1749      +17

…3281) Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com> Co-authored-by: Edward Mack <emack@pop-os.localdomain>

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>

Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>

…ution message (#3355)

…ement/1 protocol (#3354) - Added `StatementFetchingRequest` and `StatementFetchingResponse` varying data types. - implemented 'network.Message` interface in `StatementFetchingRequest` and 'network.ResponseMessage` interface in `StatementFetchingResponse` as they will be passed into `func (rrp *RequestResponseProtocol) Do(to peer.ID, req Message, res ResponseMessage) error` function as `req` and `res`. - I didn't want to create a new YAML file here. so I decided to rename the YAML file name and variable(in which data of the YAML file getting unmarshalled) name so that I can use them in this PR.

…collation/1 protocol (#3356)

…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`

…available_data/1 protocol (#3368) - Added AvailableDataFetchingRequest and AvailableDataFetchingResponse types. - Implemented 'network.Message' interface in AvailableDataFetchingRequest and 'network.ResponseMessage' interface in AvailableDataFetchingResponse as they will be passed into this function as req and res.

…g statement and collation (#3374) added New() method and decode test for below varying data types. - statement - statement distribution message - collation protocol - collator protocol message

…pov/1 protocol (#3365) - Added PoVFetchingRequest and PoVFetchingResponse types. - Implemented 'network.Message' interface in PoVFetchingRequest and 'network.ResponseMessage' interface in PoVFetchingResponse as they will be passed into this function as req and res.

#3277) - Added parachain service - Registered collation and validation protocol - Confirmed that we can communicate with collators by talking to them in `run()` function

Implemented following parachain host runtime calls - ParachainHost_persisted_validation_data - ParachainHost_validation_code

…lidation

Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>

lib/parachain/candidate_validation.go

lib/parachain/types/types.go

…om:ChainSafe/gossamer into kishan/feat/parachain-candidate-validation

edwardmack

This looks good to me, I just have a couple questions to help build my understanding.

lib/parachain/candidate_validation_test.go

lib/parachain/pvf.go

…lidation

This commit adds all the functions required for parachain candidate validations. With this commit, we are able to take candidate receipts and - get validation data for it, - perform basic checks on it, - run respective parachain's validate_block on parachain's runtime, - get validate results from parachain's runtime and verify those validation results again relaychain runtime, - and declare candidate as valid or invalid in the end. This commit also includes tests for candidate validation.

kishansagathiya requested review from edwardmack, timwu20, EclesioMeloJunior, jimjbrettj, dimartiro and kanishkatn as code owners May 9, 2023 06:30

kishansagathiya and others added 22 commits May 9, 2023 12:56

make lint and make license

cd0a656

fixed test:wq

0e9ac95

feat/scale: add BitVec (#3253)

2e84116

feat(erasure_coding): introduce erasure coding for PoV Distributor (#…

e9ec1de

…3281) Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com> Co-authored-by: Edward Mack <emack@pop-os.localdomain>

Fix(lint): fixes a lint issue in bitvec-test (#3306)

cb8a35e

feat(parachain): add types (#3297)

e212d48

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>

feat(parachain): Add StatementDistributionMessage varingDataType (#3316)

dcc31f1

feat/runtime: Add few parachain runtime calls (#3241)

29ee139

Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>

feat(parachain): Create struct for Approval Distribution Message (#3326)

11eaf7c

chore(parachain): improve comments of statement and statement distrib…

6238983

…ution message (#3355)

feat(parachain): Add CollationProtocol VaryingDataType (#3337)

222e030

feat(lib/parachain): Implement request and response message for /req_…

7d8053d

…collation/1 protocol (#3356)

fix(lib/erasure): Move test assertion to non-error condition (#3371)

838ae5f

chore(lib/parachain): add tests to decode varying data types regardin…

b1757f5

…g statement and collation (#3374) added New() method and decode test for below varying data types. - statement - statement distribution message - collation protocol - collator protocol message

chore(lib/parachain): remove pov byte array and use pov struct (#3375)

a4873fd

feat(lib/parachain): added parachain service and registering protocols (

30f371d

#3277) - Added parachain service - Registered collation and validation protocol - Confirmed that we can communicate with collators by talking to them in `run()` function

Implemented extra parachain host runtime API calls (#3237)

3082b79

Implemented following parachain host runtime calls - ParachainHost_persisted_validation_data - ParachainHost_validation_code

Merge branch 'feat/parachain' into kishan/feat/parachain-candidate-va…

3807fc2

…lidation

kishansagathiya and others added 2 commits August 1, 2023 21:36

more fix

a04bc30

Update lib/parachain/candidate_validation.go

e2f069d

Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>

kishansagathiya requested a review from EclesioMeloJunior August 1, 2023 16:08

EclesioMeloJunior reviewed Aug 1, 2023

View reviewed changes

lib/parachain/candidate_validation.go Outdated Show resolved Hide resolved

lib/parachain/types/types.go Outdated Show resolved Hide resolved

kishansagathiya added 2 commits August 2, 2023 10:14

more reviews

a514a9f

Merge branch 'kishan/feat/parachain-candidate-validation' of github.c…

93c350a

…om:ChainSafe/gossamer into kishan/feat/parachain-candidate-validation

kishansagathiya requested a review from EclesioMeloJunior August 2, 2023 04:45

EclesioMeloJunior approved these changes Aug 3, 2023

View reviewed changes

edwardmack approved these changes Aug 3, 2023

View reviewed changes

lib/parachain/candidate_validation_test.go Outdated Show resolved Hide resolved

lib/parachain/pvf.go Outdated Show resolved Hide resolved

kanishkatn reviewed Aug 4, 2023

View reviewed changes

lib/parachain/pvf.go Outdated Show resolved Hide resolved

kishansagathiya force-pushed the feat/parachain branch from f94aa1e to 46892e5 Compare August 4, 2023 06:17

kishansagathiya added 3 commits August 4, 2023 12:07

Merge branch 'feat/parachain' into kishan/feat/parachain-candidate-va…

c5ed819

…lidation

addressed reviews

a255619

moved parachain runtime code to its own package

73a4b62

kishansagathiya merged commit b7d8b91 into feat/parachain Aug 4, 2023
18 of 19 checks passed

kishansagathiya deleted the kishan/feat/parachain-candidate-validation branch August 4, 2023 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduced parachain candidate validation #3249

Introduced parachain candidate validation #3249

kishansagathiya commented May 9, 2023 •

edited

Loading

codecov bot commented May 9, 2023 •

edited

Loading

edwardmack left a comment

Introduced parachain candidate validation #3249

Introduced parachain candidate validation #3249

Conversation

kishansagathiya commented May 9, 2023 • edited Loading

Changes

Tests

Issues

Primary Reviewer

codecov bot commented May 9, 2023 • edited Loading

Codecov Report

edwardmack left a comment

Choose a reason for hiding this comment

kishansagathiya commented May 9, 2023 •

edited

Loading

codecov bot commented May 9, 2023 •

edited

Loading