feat(lib/erasure): implement Go binding over rust for erasure coding #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaysagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
There was a problem hiding this comment.
squash all commits into one. The target folder is still part of the commit history. That would make pulling this branch longer.
kishan@kishan-Inspiron-14-7425-2-in-1:~/code/gossamer$ git fetch axay issue-3422
remote: Enumerating objects: 6882, done.
remote: Counting objects: 100% (6881/6881), done.
remote: Compressing objects: 100% (2973/2973), done.
remote: Total 6882 (delta 2843), reused 6880 (delta 2843), pack-reused 1
Receiving objects: 100% (6882/6882), 474.99 MiB | 6.73 MiB/s, done.
Resolving deltas: 100% (2843/2843), completed with 7 local objects.
From github.com:axaysagathiya/gossamer
* branch issue-3422 -> FETCH_HEAD
* [new branch] issue-3422 -> axay/issue-342
rename package rename package removing target
axaysagathiya
force-pushed
the
issue-3422
branch
from
5c370d0
to
7450373
Compare
kishansagathiya
approved these changes
Aug 23, 2023
EclesioMeloJunior
requested changes
Aug 23, 2023
EclesioMeloJunior
requested changes
Aug 23, 2023
edwardmack
pushed a commit
that referenced
this pull request
Aug 30, 2023
edwardmack
pushed a commit
that referenced
this pull request
Aug 31, 2023
edwardmack
added a commit
that referenced
this pull request
Aug 31, 2023
kishansagathiya
pushed a commit
that referenced
this pull request
Sep 14, 2023
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 23, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 24, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implemented Go binding over rust for erasure coding.
Polkadot's repo is at reed-solomon-novelpoly which implements Novel Polynomial Basis and Its Application to Reed-Solomon Erasure Codes.
in kagome, they have used C bindings over polkadot's implementations of reed-solomon-novelpoly
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Fixes #3422
Primary Reviewer
@timwu20 @kishansagathiya @edwardmack