Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Buffer issues in Lightclient browser #2896

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

dapplion
Copy link
Contributor

Motivation

Make the Lightcliient UI work in browser

Description

User browser friendly Uint8Array opts

@codeclimate
Copy link

codeclimate bot commented Jul 27, 2021

Code Climate has analyzed commit 237903d and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2021

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 20b0a74 Previous: c40dfa5 Ratio
getCommitteeAssignments - req 1000 vs - 250000 vc 9.1082 ms/op 11.740 ms/op 0.78
epoch altair - 250000 vs - 7PWei - processJustificationAndFinalization 281.63 us/op 154.69 us/op 1.82
epoch altair - 250000 vs - 7PWei - processInactivityUpdates 2.6434 s/op 2.3781 s/op 1.11
epoch altair - 250000 vs - 7PWei - processRewardsAndPenalties 963.76 ms/op 1.0460 s/op 0.92
epoch altair - 250000 vs - 7PWei - processRegistryUpdates 15.271 us/op 13.506 us/op 1.13
epoch altair - 250000 vs - 7PWei - processSlashings 50.646 us/op 86.361 us/op 0.59
epoch altair - 250000 vs - 7PWei - processEffectiveBalanceUpdates 93.787 ms/op 114.95 ms/op 0.82
epoch altair - 250000 vs - 7PWei - processParticipationFlagUpdates 282.59 ms/op 267.68 ms/op 1.06
epoch altair - 250000 vs - 7PWei - prepareEpochProcessState 593.38 ms/op 564.72 ms/op 1.05
Process block - 250000 vs - 7PWei - with 0 validator exit 480.83 us/op 381.66 us/op 1.26
Process block - 250000 vs - 7PWei - with 1 validator exit 27.730 ms/op 32.916 ms/op 0.84
Process block - 250000 vs - 7PWei - with 16 validator exits 29.762 ms/op 25.560 ms/op 1.16
epoch phase0 - 250000 vs - 7PWei - processJustificationAndFinalization 129.83 us/op 97.370 us/op 1.33
epoch phase0 - 250000 vs - 7PWei - processRewardsAndPenalties 641.65 ms/op 623.30 ms/op 1.03
epoch phase0 - 250000 vs - 7PWei - processRegistryUpdates 19.078 us/op 20.951 us/op 0.91
epoch phase0 - 250000 vs - 7PWei - processSlashings 45.870 us/op 39.195 us/op 1.17
epoch phase0 - 250000 vs - 7PWei - processFinalUpdates 45.013 ms/op 45.358 ms/op 0.99
epoch phase0 - 250000 vs - 7PWei - prepareEpochProcessState 1.1241 s/op 987.69 ms/op 1.14
getAttestationDeltas - 250000 vs - 7PWei 88.358 ms/op 100.80 ms/op 0.88
processSlots - 250000 vs - 7PWei - 32 empty slots 6.8801 s/op 6.2046 s/op 1.11
shuffle list - 16384 els 1.8907 ms/op 2.7835 ms/op 0.68
shuffle list - 250000 els 25.890 ms/op 40.484 ms/op 0.64
getPubkeys - persistent - req 1000 vs - 250000 vc 19.371 us/op 21.138 us/op 0.92
BLS verify - blst-native 2.2317 ms/op 2.0457 ms/op 1.09
BLS verifyMultipleSignatures 3 - blst-native 4.5174 ms/op 4.3295 ms/op 1.04
BLS verifyMultipleSignatures 8 - blst-native 9.6880 ms/op 9.1128 ms/op 1.06
BLS verifyMultipleSignatures 32 - blst-native 38.330 ms/op 32.618 ms/op 1.18
BLS aggregatePubkeys 32 - blst-native 48.946 us/op 46.154 us/op 1.06
BLS aggregatePubkeys 128 - blst-native 184.76 us/op 170.52 us/op 1.08
getAttestationsForBlock 108.36 ms/op 158.13 ms/op 0.69
validate gossip signedAggregateAndProof - struct 6.4902 ms/op 5.3673 ms/op 1.21
validate gossip signedAggregateAndProof - treeBacked 5.4328 ms/op 5.1021 ms/op 1.06
validate gossip attestation - struct 2.5213 ms/op 2.3946 ms/op 1.05
validate gossip attestation - treeBacked 2.5869 ms/op 2.5226 ms/op 1.03

by benchmarkbot/action

@dapplion dapplion force-pushed the dapplion/lightclient-issues branch from bd79eba to 237903d Compare July 28, 2021 08:35
@wemeetagain wemeetagain merged commit d46f754 into master Jul 28, 2021
@wemeetagain wemeetagain deleted the dapplion/lightclient-issues branch July 28, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants