Fix Buffer issues in Lightclient browser

packages/beacon-state-transition/src/util/domain.ts

@@ -5,13 +5,16 @@ import {Epoch, Version, Root, DomainType, allForks} from "@chainsafe/lodestar-ty
 
 import {computeForkDataRoot} from "./fork";
 
-// Only used by processDeposit
+// Only used by processDeposit +  lightclient
 /**
  * Return the domain for the [[domainType]] and [[forkVersion]].
  */
-export function computeDomain(domainType: DomainType, forkVersion: Version, genesisValidatorRoot: Root): Buffer {
+export function computeDomain(domainType: DomainType, forkVersion: Version, genesisValidatorRoot: Root): Uint8Array {
   const forkDataRoot = computeForkDataRoot(forkVersion, genesisValidatorRoot);
-  return Buffer.concat([domainType as Buffer, forkDataRoot.slice(0, 28)]);
+  const domain = new Uint8Array(32);
+  domain.set(domainType, 0);
+  domain.set(forkDataRoot.slice(0, 28), 4);
+  return domain;
 }
 
 /**

packages/light-client/src/utils/clock.ts

@@ -8,6 +8,7 @@ type OnSlotFn = (slot: Slot, signal: AbortSignal) => Promise<void>;
 
 export interface IClock {
   readonly currentSlot: Slot;
+  readonly genesisTime: number;
   start(signal: AbortSignal): void;
   runEverySlot(fn: OnSlotFn): void;
 }
@@ -17,7 +18,7 @@ export class Clock implements IClock {
 
   constructor(
     private readonly config: IChainForkConfig,
-    private readonly genesisTime: number,
+    readonly genesisTime: number,
     private readonly onError?: (e: Error) => void
   ) {}
 

packages/light-client/src/utils/verifyMerkleBranch.ts

@@ -1,4 +1,5 @@
-import {hash, byteArrayEquals} from "@chainsafe/ssz";
+import {byteArrayEquals} from "@chainsafe/ssz";
+import {hash} from "@chainsafe/persistent-merkle-tree";
 
 /**
  * Verify that the given ``leaf`` is on the merkle branch ``proof``
@@ -16,9 +17,9 @@ export function isValidMerkleBranch(
   let value = leaf;
   for (let i = 0; i < depth; i++) {
     if (Math.floor(index / 2 ** i) % 2) {
-      value = hash(Buffer.concat([proof[i], value]));
+      value = hash(proof[i], value);
     } else {
-      value = hash(Buffer.concat([value, proof[i]]));
+      value = hash(value, proof[i]);
     }
   }
   return byteArrayEquals(value, root);

packages/light-client/test/unit/sync.test.ts

@@ -167,6 +167,7 @@ describe("Lightclient flow with LightClientUpdater", () => {
 });
 
 class MockClock implements IClock {
+  readonly genesisTime = 0;
   constructor(readonly currentSlot: Slot) {}
   start(): void {
     //