-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offset sync period by ALTAIR_FORK_EPOCH #3477
Conversation
Code Climate has analyzed commit 4196cd3 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report
@@ Coverage Diff @@
## master #3477 +/- ##
==========================================
+ Coverage 37.83% 37.86% +0.03%
==========================================
Files 307 307
Lines 8094 8098 +4
Branches 1246 1246
==========================================
+ Hits 3062 3066 +4
Misses 4880 4880
Partials 152 152 |
This PR seems incorrect. ALTAIR does not necessarily start on a sync committee period boundary, making the initial sync committee period shorter than the remaining ones. |
Motivation
The first sync period for networks with ALTAIR_FORK_EPOCH >> 0 should be sync period 0.
Description