-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Offset sync period by ALTAIR_FORK_EPOCH #3477 #3614
Merged
Merged
+38
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit ca682ca and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
37349e0
to
458278d
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
44534d6
to
ca682ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #3614 +/- ##
==========================================
- Coverage 37.50% 37.47% -0.03%
==========================================
Files 311 311
Lines 8357 8354 -3
Branches 1295 1295
==========================================
- Hits 3134 3131 -3
Misses 5074 5074
Partials 149 149 |
wemeetagain
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ALTAIR_FORK_EPOCH does not necessarily start on a sync committee period boundary.
Closes #3494
Description