Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge stable to unstable #5137

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Merge stable to unstable #5137

merged 5 commits into from
Feb 13, 2023

Conversation

wemeetagain
Copy link
Member

No description provided.

wemeetagain and others added 5 commits February 12, 2023 11:35
@wemeetagain
v1.4.3
8890b7f
@filoozom @wemeetagain
feat: add chiado config (#5108)
1262052 
* feat: add chiado config

* feat: add chiado to cli package

* chore: add chiado to default.env

* feat: automatically apply right preset for Chiado
@g11tech @wemeetagain
Add zhejiang network option (#5132)
628ac62
@wemeetagain
Fix dynamically set max peers (#5130)
ce35af9 
* Fix dynamically set max peers

* Ensure maxPeers >= targetPeers
@wemeetagain
Release v1.4.3 (#5135)
941a1cf
@wemeetagain wemeetagain requested a review from a team as a code owner February 12, 2023 23:20
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 8358b41 Previous: 2042c3b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 659.54 us/op 917.41 us/op 0.72
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 49.121 us/op 43.088 us/op 1.14
BLS verify - blst-native 1.2118 ms/op 1.1921 ms/op 1.02
BLS verifyMultipleSignatures 3 - blst-native 2.4592 ms/op 2.3592 ms/op 1.04
BLS verifyMultipleSignatures 8 - blst-native 5.3321 ms/op 5.2525 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 19.395 ms/op 18.855 ms/op 1.03
BLS aggregatePubkeys 32 - blst-native 25.847 us/op 25.365 us/op 1.02
BLS aggregatePubkeys 128 - blst-native 101.49 us/op 98.769 us/op 1.03
getAttestationsForBlock 57.756 ms/op 52.960 ms/op 1.09
isKnown best case - 1 super set check 269.00 ns/op 254.00 ns/op 1.06
isKnown normal case - 2 super set checks 245.00 ns/op 263.00 ns/op 0.93
isKnown worse case - 16 super set checks 256.00 ns/op 264.00 ns/op 0.97
CheckpointStateCache - add get delete 5.4130 us/op 5.0580 us/op 1.07
validate gossip signedAggregateAndProof - struct 2.7763 ms/op 2.7210 ms/op 1.02
validate gossip attestation - struct 1.3232 ms/op 1.3123 ms/op 1.01
pickEth1Vote - no votes 1.3104 ms/op 1.2076 ms/op 1.09
pickEth1Vote - max votes 11.564 ms/op 10.283 ms/op 1.12
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.2881 ms/op 8.3886 ms/op 1.11
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.733 ms/op 14.347 ms/op 1.10
pickEth1Vote - Eth1Data fastSerialize value x2048 663.39 us/op 616.80 us/op 1.08
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.1912 ms/op 5.3499 ms/op 0.97
bytes32 toHexString 543.00 ns/op 448.00 ns/op 1.21
bytes32 Buffer.toString(hex) 352.00 ns/op 323.00 ns/op 1.09
bytes32 Buffer.toString(hex) from Uint8Array 568.00 ns/op 521.00 ns/op 1.09
bytes32 Buffer.toString(hex) + 0x 347.00 ns/op 311.00 ns/op 1.12
Object access 1 prop 0.16700 ns/op 0.15400 ns/op 1.08
Map access 1 prop 0.16400 ns/op 0.15300 ns/op 1.07
Object get x1000 6.5230 ns/op 6.9510 ns/op 0.94
Map get x1000 0.54300 ns/op 0.57500 ns/op 0.94
Object set x1000 54.938 ns/op 48.563 ns/op 1.13
Map set x1000 46.403 ns/op 39.871 ns/op 1.16
Return object 10000 times 0.24570 ns/op 0.22160 ns/op 1.11
Throw Error 10000 times 4.2007 us/op 3.9156 us/op 1.07
fastMsgIdFn sha256 / 200 bytes 3.4150 us/op 3.2420 us/op 1.05
fastMsgIdFn h32 xxhash / 200 bytes 292.00 ns/op 256.00 ns/op 1.14
fastMsgIdFn h64 xxhash / 200 bytes 390.00 ns/op 362.00 ns/op 1.08
fastMsgIdFn sha256 / 1000 bytes 11.457 us/op 11.453 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 406.00 ns/op 394.00 ns/op 1.03
fastMsgIdFn h64 xxhash / 1000 bytes 479.00 ns/op 448.00 ns/op 1.07
fastMsgIdFn sha256 / 10000 bytes 103.56 us/op 103.25 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9240 us/op 1.9600 us/op 0.98
fastMsgIdFn h64 xxhash / 10000 bytes 1.3680 us/op 1.4070 us/op 0.97
enrSubnets - fastDeserialize 64 bits 1.2920 us/op 1.2800 us/op 1.01
enrSubnets - ssz BitVector 64 bits 505.00 ns/op 472.00 ns/op 1.07
enrSubnets - fastDeserialize 4 bits 184.00 ns/op 172.00 ns/op 1.07
enrSubnets - ssz BitVector 4 bits 503.00 ns/op 473.00 ns/op 1.06
prioritizePeers score -10:0 att 32-0.1 sync 2-0 98.297 us/op 93.434 us/op 1.05
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 128.45 us/op 124.00 us/op 1.04
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 174.46 us/op 165.15 us/op 1.06
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 311.99 us/op 308.59 us/op 1.01
prioritizePeers score 0:0 att 64-1 sync 4-1 389.90 us/op 353.72 us/op 1.10
array of 16000 items push then shift 1.6764 us/op 1.6220 us/op 1.03
LinkedList of 16000 items push then shift 8.8940 ns/op 8.7510 ns/op 1.02
array of 16000 items push then pop 85.700 ns/op 94.658 ns/op 0.91
LinkedList of 16000 items push then pop 8.4360 ns/op 8.5100 ns/op 0.99
array of 24000 items push then shift 2.2560 us/op 2.3397 us/op 0.96
LinkedList of 24000 items push then shift 8.6720 ns/op 8.8400 ns/op 0.98
array of 24000 items push then pop 79.254 ns/op 82.186 ns/op 0.96
LinkedList of 24000 items push then pop 8.5590 ns/op 8.4430 ns/op 1.01
intersect bitArray bitLen 8 13.904 ns/op 13.247 ns/op 1.05
intersect array and set length 8 75.666 ns/op 76.857 ns/op 0.98
intersect bitArray bitLen 128 46.662 ns/op 44.290 ns/op 1.05
intersect array and set length 128 1.0382 us/op 1.0614 us/op 0.98
Buffer.concat 32 items 2.8620 us/op 2.9760 us/op 0.96
Uint8Array.set 32 items 2.2460 us/op 3.0640 us/op 0.73
pass gossip attestations to forkchoice per slot 2.3921 ms/op 2.3383 ms/op 1.02
computeDeltas 3.4259 ms/op 3.1539 ms/op 1.09
computeProposerBoostScoreFromBalances 1.7408 ms/op 1.8924 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei normalcase 2.0669 ms/op 2.6898 ms/op 0.77
altair processAttestation - 250000 vs - 7PWei worstcase 3.5430 ms/op 3.5470 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 134.40 us/op 140.33 us/op 0.96
altair processAttestation - setStatus - 1/3 committees join 273.42 us/op 271.72 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 368.47 us/op 368.90 us/op 1.00
altair processAttestation - setStatus - 2/3 committees join 448.07 us/op 482.38 us/op 0.93
altair processAttestation - setStatus - 4/5 committees join 643.64 us/op 655.69 us/op 0.98
altair processAttestation - setStatus - 100% committees join 759.67 us/op 760.07 us/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase 16.228 ms/op 16.183 ms/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase hashState 27.970 ms/op 26.409 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase 46.098 ms/op 53.540 ms/op 0.86
altair processBlock - 250000 vs - 7PWei worstcase hashState 64.434 ms/op 68.331 ms/op 0.94
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2664 ms/op 2.2402 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei worstcase 29.315 ms/op 29.323 ms/op 1.00
altair processEth1Data - 250000 vs - 7PWei normalcase 458.42 us/op 464.60 us/op 0.99
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 6.3790 us/op 7.0310 us/op 0.91
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 19.131 us/op 22.082 us/op 0.87
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 8.0490 us/op 8.7280 us/op 0.92
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.0050 us/op 6.5670 us/op 0.91
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 74.150 us/op 78.308 us/op 0.95
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 594.86 us/op 624.04 us/op 0.95
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 898.98 us/op 888.03 us/op 1.01
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 856.48 us/op 897.48 us/op 0.95
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.2449 ms/op 2.1708 ms/op 1.03
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.5506 ms/op 1.5289 ms/op 1.01
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.5617 ms/op 3.7171 ms/op 0.96
Tree 40 250000 create 293.68 ms/op 303.85 ms/op 0.97
Tree 40 250000 get(125000) 170.26 ns/op 179.66 ns/op 0.95
Tree 40 250000 set(125000) 874.29 ns/op 943.74 ns/op 0.93
Tree 40 250000 toArray() 16.164 ms/op 17.200 ms/op 0.94
Tree 40 250000 iterate all - toArray() + loop 16.249 ms/op 15.595 ms/op 1.04
Tree 40 250000 iterate all - get(i) 62.642 ms/op 61.499 ms/op 1.02
MutableVector 250000 create 10.585 ms/op 9.6199 ms/op 1.10
MutableVector 250000 get(125000) 6.0280 ns/op 6.2900 ns/op 0.96
MutableVector 250000 set(125000) 244.97 ns/op 246.48 ns/op 0.99
MutableVector 250000 toArray() 2.6621 ms/op 2.7090 ms/op 0.98
MutableVector 250000 iterate all - toArray() + loop 2.7553 ms/op 2.8328 ms/op 0.97
MutableVector 250000 iterate all - get(i) 1.4245 ms/op 1.4999 ms/op 0.95
Array 250000 create 2.7397 ms/op 2.4864 ms/op 1.10
Array 250000 clone - spread 1.0611 ms/op 1.1725 ms/op 0.91
Array 250000 get(125000) 0.51000 ns/op 0.55700 ns/op 0.92
Array 250000 set(125000) 0.59800 ns/op 0.64400 ns/op 0.93
Array 250000 iterate all - loop 107.99 us/op 96.282 us/op 1.12
effectiveBalanceIncrements clone Uint8Array 300000 22.760 us/op 30.636 us/op 0.74
effectiveBalanceIncrements clone MutableVector 300000 312.00 ns/op 365.00 ns/op 0.85
effectiveBalanceIncrements rw all Uint8Array 300000 165.48 us/op 165.59 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 75.170 ms/op 80.317 ms/op 0.94
phase0 afterProcessEpoch - 250000 vs - 7PWei 108.21 ms/op 110.58 ms/op 0.98
phase0 beforeProcessEpoch - 250000 vs - 7PWei 40.830 ms/op 32.248 ms/op 1.27
altair processEpoch - mainnet_e81889 316.16 ms/op 316.68 ms/op 1.00
mainnet_e81889 - altair beforeProcessEpoch 48.653 ms/op 63.380 ms/op 0.77
mainnet_e81889 - altair processJustificationAndFinalization 15.985 us/op 17.114 us/op 0.93
mainnet_e81889 - altair processInactivityUpdates 5.1440 ms/op 5.0581 ms/op 1.02
mainnet_e81889 - altair processRewardsAndPenalties 66.676 ms/op 51.874 ms/op 1.29
mainnet_e81889 - altair processRegistryUpdates 2.6680 us/op 2.6430 us/op 1.01
mainnet_e81889 - altair processSlashings 446.00 ns/op 432.00 ns/op 1.03
mainnet_e81889 - altair processEth1DataReset 524.00 ns/op 505.00 ns/op 1.04
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2364 ms/op 1.1950 ms/op 1.03
mainnet_e81889 - altair processSlashingsReset 3.9570 us/op 4.5700 us/op 0.87
mainnet_e81889 - altair processRandaoMixesReset 6.1870 us/op 4.2260 us/op 1.46
mainnet_e81889 - altair processHistoricalRootsUpdate 730.00 ns/op 594.00 ns/op 1.23
mainnet_e81889 - altair processParticipationFlagUpdates 2.4380 us/op 2.3370 us/op 1.04
mainnet_e81889 - altair processSyncCommitteeUpdates 433.00 ns/op 437.00 ns/op 0.99
mainnet_e81889 - altair afterProcessEpoch 122.18 ms/op 113.79 ms/op 1.07
phase0 processEpoch - mainnet_e58758 366.55 ms/op 313.45 ms/op 1.17
mainnet_e58758 - phase0 beforeProcessEpoch 135.35 ms/op 121.67 ms/op 1.11
mainnet_e58758 - phase0 processJustificationAndFinalization 16.617 us/op 16.687 us/op 1.00
mainnet_e58758 - phase0 processRewardsAndPenalties 64.008 ms/op 56.926 ms/op 1.12
mainnet_e58758 - phase0 processRegistryUpdates 7.8030 us/op 7.3670 us/op 1.06
mainnet_e58758 - phase0 processSlashings 513.00 ns/op 502.00 ns/op 1.02
mainnet_e58758 - phase0 processEth1DataReset 506.00 ns/op 556.00 ns/op 0.91
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 942.50 us/op 940.68 us/op 1.00
mainnet_e58758 - phase0 processSlashingsReset 4.5520 us/op 3.0600 us/op 1.49
mainnet_e58758 - phase0 processRandaoMixesReset 4.4720 us/op 4.2030 us/op 1.06
mainnet_e58758 - phase0 processHistoricalRootsUpdate 555.00 ns/op 570.00 ns/op 0.97
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.0830 us/op 3.8090 us/op 1.07
mainnet_e58758 - phase0 afterProcessEpoch 97.609 ms/op 95.001 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.1956 ms/op 1.4847 ms/op 0.81
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4442 ms/op 1.4709 ms/op 0.98
altair processInactivityUpdates - 250000 normalcase 27.205 ms/op 22.444 ms/op 1.21
altair processInactivityUpdates - 250000 worstcase 26.087 ms/op 20.085 ms/op 1.30
phase0 processRegistryUpdates - 250000 normalcase 5.8100 us/op 6.0830 us/op 0.96
phase0 processRegistryUpdates - 250000 badcase_full_deposits 223.30 us/op 234.38 us/op 0.95
phase0 processRegistryUpdates - 250000 worstcase 0.5 124.57 ms/op 124.69 ms/op 1.00
altair processRewardsAndPenalties - 250000 normalcase 69.451 ms/op 56.514 ms/op 1.23
altair processRewardsAndPenalties - 250000 worstcase 71.908 ms/op 53.660 ms/op 1.34
phase0 getAttestationDeltas - 250000 normalcase 6.4428 ms/op 6.4443 ms/op 1.00
phase0 getAttestationDeltas - 250000 worstcase 6.5741 ms/op 6.3190 ms/op 1.04
phase0 processSlashings - 250000 worstcase 3.5244 ms/op 3.4835 ms/op 1.01
altair processSyncCommitteeUpdates - 250000 166.54 ms/op 169.27 ms/op 0.98
BeaconState.hashTreeRoot - No change 249.00 ns/op 261.00 ns/op 0.95
BeaconState.hashTreeRoot - 1 full validator 52.714 us/op 50.283 us/op 1.05
BeaconState.hashTreeRoot - 32 full validator 548.81 us/op 505.78 us/op 1.09
BeaconState.hashTreeRoot - 512 full validator 5.3716 ms/op 4.9647 ms/op 1.08
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 61.953 us/op 60.485 us/op 1.02
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 909.22 us/op 863.71 us/op 1.05
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.138 ms/op 11.063 ms/op 1.01
BeaconState.hashTreeRoot - 1 balances 48.250 us/op 47.167 us/op 1.02
BeaconState.hashTreeRoot - 32 balances 412.97 us/op 426.19 us/op 0.97
BeaconState.hashTreeRoot - 512 balances 4.2229 ms/op 4.3491 ms/op 0.97
BeaconState.hashTreeRoot - 250000 balances 71.303 ms/op 70.635 ms/op 1.01
aggregationBits - 2048 els - zipIndexesInBitList 15.227 us/op 15.721 us/op 0.97
regular array get 100000 times 32.405 us/op 32.359 us/op 1.00
wrappedArray get 100000 times 32.394 us/op 32.351 us/op 1.00
arrayWithProxy get 100000 times 15.514 ms/op 15.300 ms/op 1.01
ssz.Root.equals 512.00 ns/op 590.00 ns/op 0.87
byteArrayEquals 503.00 ns/op 544.00 ns/op 0.92
shuffle list - 16384 els 6.5410 ms/op 6.4158 ms/op 1.02
shuffle list - 250000 els 95.998 ms/op 94.192 ms/op 1.02
processSlot - 1 slots 8.0030 us/op 8.6380 us/op 0.93
processSlot - 32 slots 1.2666 ms/op 1.2458 ms/op 1.02
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 181.12 us/op 184.37 us/op 0.98
getCommitteeAssignments - req 1 vs - 250000 vc 2.8646 ms/op 2.7482 ms/op 1.04
getCommitteeAssignments - req 100 vs - 250000 vc 3.9702 ms/op 3.9346 ms/op 1.01
getCommitteeAssignments - req 1000 vs - 250000 vc 4.2842 ms/op 4.2309 ms/op 1.01
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.2300 ns/op 4.5500 ns/op 0.93
state getBlockRootAtSlot - 250000 vs - 7PWei 907.94 ns/op 939.55 ns/op 0.97
computeProposers - vc 250000 9.8458 ms/op 10.702 ms/op 0.92
computeEpochShuffling - vc 250000 95.743 ms/op 96.357 ms/op 0.99
getNextSyncCommittee - vc 250000 162.29 ms/op 174.24 ms/op 0.93

by benchmarkbot/action

@twoeths
Copy link
Contributor

twoeths commented Feb 13, 2023

Finally CI passed, created a CI issue at #5138

@wemeetagain wemeetagain merged commit 3236de8 into unstable Feb 13, 2023
@wemeetagain
Copy link
Member Author

🎉 This PR is included in v1.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wemeetagain @twoeths @filoozom @g11tech