Upgrade lerna to lerna 6 #5368
Merged
Upgrade lerna to lerna 6 #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
force-pushed
the
nh/lerna-upgrade
branch
from
f69a7d8 to
4dc6d37
Compare
nazarhussain
commented
Apr 17, 2023
| @@ -43,7 +43,7 @@ jobs: | |||
| key: ${{ runner.os }}-${{ steps.node.outputs.v8CppApiVersion }}-${{ hashFiles('**/yarn.lock', '**/package.json') }} | |||
| - name: Install & build | |||
| if: steps.cache-deps.outputs.cache-hit != 'true' | |||
| run: yarn install --frozen-lockfile --ignore-optional && yarn build | |||
There was a problem hiding this comment.
Had to remove --ignore-optional from all CI scripts because of the following issue. The alternative solution didn't worked in our case. The issue is somehow related to NPM and yarn behavior about optional dependencies npm/cli#4828
nazarhussain
commented
Apr 17, 2023
| @@ -4,6 +4,7 @@ | |||
| ], | |||
| "npmClient": "yarn", | |||
| "useWorkspaces": true, | |||
| "useNx": true, | |||
There was a problem hiding this comment.
Major change in Lerna 6 is the new task runner nx. We can revert to a legacy behavior by setting this to false.
This reverts commit 99dde2b.
nazarhussain
force-pushed
the
nh/lerna-upgrade
branch
from
4dc6d37 to
e3044b1
Compare
|
🎉 This PR is included in v1.8.0 🎉 |
nflaig
reviewed
May 24, 2023
| @@ -11,8 +11,8 @@ | |||
| "clean": "rm -rf ./packages/*/lib ./packages/*/*.tsbuildinfo", | |||
| "build": "lerna run build", | |||
| "build:docs": "lerna run build:refdocs && ./scripts/prepare-docs.sh", | |||
| "build:lib:watch": "lerna run build:lib:watch --parallel", | |||
| "build:types:watch": "lerna run build:types:watch --parallel", | |||
There was a problem hiding this comment.
@nazarhussain what was the reason for removing --parallel? Looks like it is required to run multiple concurrent jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the dependencies up-to-date.
Description
Upgrade the lerna.
Steps to test or reproduce