Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix yarn install warnings #5711

Merged
merged 1 commit into from
Jun 27, 2023
Merged

chore: fix yarn install warnings #5711

merged 1 commit into from
Jun 27, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jun 26, 2023 •
edited
Loading

Motivation

No warnings when running yarn install

and be able to merge

Description

Fixes yarn install warnings

Steps to reproduce

Clean node_modules

yarn clean:nm

Reinstall

yarn install

Output

~/projects/ethereum/lodestar [nflaig/fix-yarn-warnings ≡]> yarn install
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
[5/5] Building fresh packages...
Done in 51.36s.

@nflaig nflaig requested a review from a team as a code owner June 26, 2023 21:01
nflaig
nflaig commented Jun 26, 2023
View reviewed changes
package.json
@@ -67,6 +67,7 @@
"karma-spec-reporter": "^0.0.36",
"karma-webpack": "^5.0.0",
"lerna": "^6.6.1",
"libp2p": "0.42.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the following warning: warning " > @lodestar/reqresp@1.9.0" has unmet peer dependency "libp2p@~0.42.2".

Not sure why this works but picked it up here: yarnpkg/yarn#5347 (comment)

package.json
@@ -85,5 +86,8 @@
"typescript": "^5.0.3",
"typescript-docs-verifier": "^2.4.0",
"webpack": "^5.77.0"
},
"resolutions": {
"dns-over-http-resolver": "^2.1.1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add custom resolution for now until the dependency tree is updated

warning "workspace-aggregator-7fe22546-d232-4ae9-9884-df7a13280865 > @lodestar/beacon-node > @multiformats/multiaddr > dns-over-http-resolver > native-fetch@4.0.2" has unmet peer dependency "undici@*".

This PR fixes the warnings and is included in 2.1.1

packages/beacon-node/package.json
@@ -97,6 +97,7 @@
"@chainsafe/as-chacha20poly1305": "^0.1.0",
"@chainsafe/as-sha256": "^0.3.1",
"@chainsafe/bls": "7.1.1",
"@chainsafe/blst": "^0.2.9",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just missed I guess, gets rid of warning "workspace-aggregator-7fe22546-d232-4ae9-9884-df7a13280865 > @lodestar/beacon-node > @chainsafe/bls@7.1.1" has unmet peer dependency "@chainsafe/blst@^0.2.4".

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: accc632 Previous: a208afb Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 662.21 us/op 816.44 us/op 0.81
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 48.808 us/op 46.294 us/op 1.05
BLS verify - blst-native 1.2449 ms/op 1.2151 ms/op 1.02
BLS verifyMultipleSignatures 3 - blst-native 2.5291 ms/op 2.4652 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst-native 5.4360 ms/op 5.2976 ms/op 1.03
BLS verifyMultipleSignatures 32 - blst-native 19.571 ms/op 19.152 ms/op 1.02
BLS aggregatePubkeys 32 - blst-native 26.530 us/op 25.886 us/op 1.02
BLS aggregatePubkeys 128 - blst-native 102.08 us/op 100.04 us/op 1.02
getAttestationsForBlock 61.269 ms/op 56.262 ms/op 1.09
isKnown best case - 1 super set check 262.00 ns/op 263.00 ns/op 1.00
isKnown normal case - 2 super set checks 253.00 ns/op 261.00 ns/op 0.97
isKnown worse case - 16 super set checks 254.00 ns/op 258.00 ns/op 0.98
CheckpointStateCache - add get delete 5.4100 us/op 5.3160 us/op 1.02
validate gossip signedAggregateAndProof - struct 2.8034 ms/op 2.8217 ms/op 0.99
validate gossip attestation - struct 1.3433 ms/op 1.3492 ms/op 1.00
pickEth1Vote - no votes 1.4130 ms/op 1.3552 ms/op 1.04
pickEth1Vote - max votes 8.8788 ms/op 8.6700 ms/op 1.02
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.7076 ms/op 8.5185 ms/op 1.02
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.233 ms/op 15.017 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize value x2048 764.22 us/op 707.88 us/op 1.08
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.8812 ms/op 7.1009 ms/op 0.97
bytes32 toHexString 526.00 ns/op 554.00 ns/op 0.95
bytes32 Buffer.toString(hex) 358.00 ns/op 418.00 ns/op 0.86
bytes32 Buffer.toString(hex) from Uint8Array 559.00 ns/op 635.00 ns/op 0.88
bytes32 Buffer.toString(hex) + 0x 360.00 ns/op 394.00 ns/op 0.91
Object access 1 prop 0.17500 ns/op 0.19000 ns/op 0.92
Map access 1 prop 0.16400 ns/op 0.16500 ns/op 0.99
Object get x1000 6.7130 ns/op 7.1970 ns/op 0.93
Map get x1000 0.67000 ns/op 0.65800 ns/op 1.02
Object set x1000 58.861 ns/op 63.017 ns/op 0.93
Map set x1000 47.722 ns/op 52.610 ns/op 0.91
Return object 10000 times 0.24490 ns/op 0.26290 ns/op 0.93
Throw Error 10000 times 4.3538 us/op 4.4858 us/op 0.97
fastMsgIdFn sha256 / 200 bytes 3.5510 us/op 3.6600 us/op 0.97
fastMsgIdFn h32 xxhash / 200 bytes 305.00 ns/op 333.00 ns/op 0.92
fastMsgIdFn h64 xxhash / 200 bytes 457.00 ns/op 495.00 ns/op 0.92
fastMsgIdFn sha256 / 1000 bytes 11.810 us/op 12.515 us/op 0.94
fastMsgIdFn h32 xxhash / 1000 bytes 456.00 ns/op 457.00 ns/op 1.00
fastMsgIdFn h64 xxhash / 1000 bytes 509.00 ns/op 547.00 ns/op 0.93
fastMsgIdFn sha256 / 10000 bytes 100.67 us/op 110.05 us/op 0.91
fastMsgIdFn h32 xxhash / 10000 bytes 1.8730 us/op 2.2260 us/op 0.84
fastMsgIdFn h64 xxhash / 10000 bytes 1.3790 us/op 1.5270 us/op 0.90
enrSubnets - fastDeserialize 64 bits 1.3710 us/op 1.4530 us/op 0.94
enrSubnets - ssz BitVector 64 bits 480.00 ns/op 606.00 ns/op 0.79
enrSubnets - fastDeserialize 4 bits 163.00 ns/op 205.00 ns/op 0.80
enrSubnets - ssz BitVector 4 bits 534.00 ns/op 640.00 ns/op 0.83
prioritizePeers score -10:0 att 32-0.1 sync 2-0 115.51 us/op 118.85 us/op 0.97
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 134.41 us/op 162.14 us/op 0.83
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 197.35 us/op 193.63 us/op 1.02
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 345.69 us/op 359.73 us/op 0.96
prioritizePeers score 0:0 att 64-1 sync 4-1 386.87 us/op 467.24 us/op 0.83
array of 16000 items push then shift 1.7025 us/op 1.8918 us/op 0.90
LinkedList of 16000 items push then shift 9.1060 ns/op 10.074 ns/op 0.90
array of 16000 items push then pop 106.43 ns/op 123.72 ns/op 0.86
LinkedList of 16000 items push then pop 9.4400 ns/op 9.2460 ns/op 1.02
array of 24000 items push then shift 2.5746 us/op 2.5396 us/op 1.01
LinkedList of 24000 items push then shift 9.8500 ns/op 9.2170 ns/op 1.07
array of 24000 items push then pop 89.296 ns/op 78.854 ns/op 1.13
LinkedList of 24000 items push then pop 10.568 ns/op 9.2680 ns/op 1.14
intersect bitArray bitLen 8 14.012 ns/op 14.199 ns/op 0.99
intersect array and set length 8 101.48 ns/op 85.083 ns/op 1.19
intersect bitArray bitLen 128 52.043 ns/op 47.892 ns/op 1.09
intersect array and set length 128 1.5979 us/op 1.2012 us/op 1.33
Buffer.concat 32 items 3.6450 us/op 3.1160 us/op 1.17
Uint8Array.set 32 items 2.8660 us/op 2.6370 us/op 1.09
transfer serialized Status (84 B) 2.3500 us/op 2.2120 us/op 1.06
copy serialized Status (84 B) 1.8550 us/op 1.8260 us/op 1.02
transfer serialized SignedVoluntaryExit (112 B) 2.3990 us/op 2.3180 us/op 1.03
copy serialized SignedVoluntaryExit (112 B) 2.0570 us/op 2.0320 us/op 1.01
transfer serialized ProposerSlashing (416 B) 2.9140 us/op 2.8210 us/op 1.03
copy serialized ProposerSlashing (416 B) 2.6460 us/op 3.1570 us/op 0.84
transfer serialized Attestation (485 B) 2.7490 us/op 2.9220 us/op 0.94
copy serialized Attestation (485 B) 2.4700 us/op 2.5130 us/op 0.98
transfer serialized AttesterSlashing (33232 B) 3.2120 us/op 2.9550 us/op 1.09
copy serialized AttesterSlashing (33232 B) 8.8690 us/op 6.7140 us/op 1.32
transfer serialized Small SignedBeaconBlock (128000 B) 3.1190 us/op 3.5200 us/op 0.89
copy serialized Small SignedBeaconBlock (128000 B) 57.670 us/op 14.702 us/op 3.92
transfer serialized Avg SignedBeaconBlock (200000 B) 3.4940 us/op 3.6620 us/op 0.95
copy serialized Avg SignedBeaconBlock (200000 B) 44.877 us/op 22.309 us/op 2.01
transfer serialized BlobsSidecar (524380 B) 4.7710 us/op 3.6730 us/op 1.30
copy serialized BlobsSidecar (524380 B) 213.96 us/op 170.49 us/op 1.25
transfer serialized Big SignedBeaconBlock (1000000 B) 4.2810 us/op 4.0630 us/op 1.05
copy serialized Big SignedBeaconBlock (1000000 B) 292.20 us/op 289.00 us/op 1.01
pass gossip attestations to forkchoice per slot 2.8036 ms/op 2.8638 ms/op 0.98
forkChoice updateHead vc 100000 bc 64 eq 0 2.3657 ms/op 2.1249 ms/op 1.11
forkChoice updateHead vc 600000 bc 64 eq 0 16.555 ms/op 12.022 ms/op 1.38
forkChoice updateHead vc 1000000 bc 64 eq 0 19.009 ms/op 23.707 ms/op 0.80
forkChoice updateHead vc 600000 bc 320 eq 0 17.280 ms/op 17.998 ms/op 0.96
forkChoice updateHead vc 600000 bc 1200 eq 0 92.200 ms/op 88.577 ms/op 1.04
forkChoice updateHead vc 600000 bc 64 eq 1000 22.553 ms/op 21.368 ms/op 1.06
forkChoice updateHead vc 600000 bc 64 eq 10000 23.538 ms/op 23.551 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 300000 54.003 ms/op 32.167 ms/op 1.68
computeDeltas 3.5906 ms/op 3.6116 ms/op 0.99
computeProposerBoostScoreFromBalances 1.8732 ms/op 1.9292 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei normalcase 2.5888 ms/op 3.1373 ms/op 0.83
altair processAttestation - 250000 vs - 7PWei worstcase 4.7715 ms/op 4.7994 ms/op 0.99
altair processAttestation - setStatus - 1/6 committees join 144.72 us/op 157.35 us/op 0.92
altair processAttestation - setStatus - 1/3 committees join 288.69 us/op 302.95 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 371.44 us/op 430.62 us/op 0.86
altair processAttestation - setStatus - 2/3 committees join 469.48 us/op 502.34 us/op 0.93
altair processAttestation - setStatus - 4/5 committees join 661.12 us/op 809.01 us/op 0.82
altair processAttestation - setStatus - 100% committees join 764.21 us/op 917.22 us/op 0.83
altair processBlock - 250000 vs - 7PWei normalcase 16.861 ms/op 19.850 ms/op 0.85
altair processBlock - 250000 vs - 7PWei normalcase hashState 27.813 ms/op 27.696 ms/op 1.00
altair processBlock - 250000 vs - 7PWei worstcase 46.588 ms/op 57.765 ms/op 0.81
altair processBlock - 250000 vs - 7PWei worstcase hashState 70.319 ms/op 79.888 ms/op 0.88
phase0 processBlock - 250000 vs - 7PWei normalcase 2.1318 ms/op 2.2065 ms/op 0.97
phase0 processBlock - 250000 vs - 7PWei worstcase 28.525 ms/op 34.406 ms/op 0.83
altair processEth1Data - 250000 vs - 7PWei normalcase 467.48 us/op 497.79 us/op 0.94
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 7.2300 us/op 7.9140 us/op 0.91
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 22.603 us/op 24.055 us/op 0.94
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 9.6390 us/op 13.172 us/op 0.73
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 7.2160 us/op 7.1700 us/op 1.01
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 88.313 us/op 100.08 us/op 0.88
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 717.98 us/op 791.27 us/op 0.91
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 935.97 us/op 938.97 us/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 933.35 us/op 934.13 us/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4760 ms/op 3.1501 ms/op 0.79
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.6736 ms/op 1.8368 ms/op 0.91
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.1019 ms/op 5.0921 ms/op 0.81
Tree 40 250000 create 296.77 ms/op 432.16 ms/op 0.69
Tree 40 250000 get(125000) 183.39 ns/op 217.79 ns/op 0.84
Tree 40 250000 set(125000) 926.72 ns/op 1.1860 us/op 0.78
Tree 40 250000 toArray() 20.783 ms/op 24.402 ms/op 0.85
Tree 40 250000 iterate all - toArray() + loop 20.032 ms/op 24.516 ms/op 0.82
Tree 40 250000 iterate all - get(i) 72.205 ms/op 82.194 ms/op 0.88
MutableVector 250000 create 11.104 ms/op 13.592 ms/op 0.82
MutableVector 250000 get(125000) 6.5500 ns/op 7.7770 ns/op 0.84
MutableVector 250000 set(125000) 279.58 ns/op 308.06 ns/op 0.91
MutableVector 250000 toArray() 3.4440 ms/op 3.7496 ms/op 0.92
MutableVector 250000 iterate all - toArray() + loop 3.1981 ms/op 4.1234 ms/op 0.78
MutableVector 250000 iterate all - get(i) 1.5253 ms/op 1.7789 ms/op 0.86
Array 250000 create 2.9390 ms/op 3.7051 ms/op 0.79
Array 250000 clone - spread 1.1188 ms/op 1.5088 ms/op 0.74
Array 250000 get(125000) 0.55700 ns/op 0.93600 ns/op 0.60
Array 250000 set(125000) 0.62300 ns/op 0.89300 ns/op 0.70
Array 250000 iterate all - loop 84.111 us/op 116.11 us/op 0.72
effectiveBalanceIncrements clone Uint8Array 300000 26.938 us/op 49.209 us/op 0.55
effectiveBalanceIncrements clone MutableVector 300000 320.00 ns/op 414.00 ns/op 0.77
effectiveBalanceIncrements rw all Uint8Array 300000 162.81 us/op 184.02 us/op 0.88
effectiveBalanceIncrements rw all MutableVector 300000 78.715 ms/op 160.78 ms/op 0.49
phase0 afterProcessEpoch - 250000 vs - 7PWei 114.18 ms/op 138.73 ms/op 0.82
phase0 beforeProcessEpoch - 250000 vs - 7PWei 39.463 ms/op 54.400 ms/op 0.73
altair processEpoch - mainnet_e81889 305.77 ms/op 418.42 ms/op 0.73
mainnet_e81889 - altair beforeProcessEpoch 64.894 ms/op 100.92 ms/op 0.64
mainnet_e81889 - altair processJustificationAndFinalization 17.266 us/op 39.354 us/op 0.44
mainnet_e81889 - altair processInactivityUpdates 5.4218 ms/op 8.1918 ms/op 0.66
mainnet_e81889 - altair processRewardsAndPenalties 71.124 ms/op 87.563 ms/op 0.81
mainnet_e81889 - altair processRegistryUpdates 2.3280 us/op 5.9890 us/op 0.39
mainnet_e81889 - altair processSlashings 549.00 ns/op 1.4540 us/op 0.38
mainnet_e81889 - altair processEth1DataReset 595.00 ns/op 1.4880 us/op 0.40
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2200 ms/op 4.6905 ms/op 0.26
mainnet_e81889 - altair processSlashingsReset 5.1840 us/op 14.240 us/op 0.36
mainnet_e81889 - altair processRandaoMixesReset 4.6050 us/op 6.6500 us/op 0.69
mainnet_e81889 - altair processHistoricalRootsUpdate 789.00 ns/op 2.4640 us/op 0.32
mainnet_e81889 - altair processParticipationFlagUpdates 2.6590 us/op 8.3850 us/op 0.32
mainnet_e81889 - altair processSyncCommitteeUpdates 609.00 ns/op 1.5200 us/op 0.40
mainnet_e81889 - altair afterProcessEpoch 117.07 ms/op 164.05 ms/op 0.71
phase0 processEpoch - mainnet_e58758 326.54 ms/op 503.21 ms/op 0.65
mainnet_e58758 - phase0 beforeProcessEpoch 119.08 ms/op 211.00 ms/op 0.56
mainnet_e58758 - phase0 processJustificationAndFinalization 15.013 us/op 25.647 us/op 0.59
mainnet_e58758 - phase0 processRewardsAndPenalties 55.053 ms/op 79.361 ms/op 0.69
mainnet_e58758 - phase0 processRegistryUpdates 8.3110 us/op 17.987 us/op 0.46
mainnet_e58758 - phase0 processSlashings 565.00 ns/op 1.4440 us/op 0.39
mainnet_e58758 - phase0 processEth1DataReset 530.00 ns/op 847.00 ns/op 0.63
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0329 ms/op 1.4087 ms/op 0.73
mainnet_e58758 - phase0 processSlashingsReset 3.0110 us/op 7.7880 us/op 0.39
mainnet_e58758 - phase0 processRandaoMixesReset 4.3560 us/op 10.193 us/op 0.43
mainnet_e58758 - phase0 processHistoricalRootsUpdate 750.00 ns/op 1.8500 us/op 0.41
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9380 us/op 7.8540 us/op 0.50
mainnet_e58758 - phase0 afterProcessEpoch 97.997 ms/op 122.30 ms/op 0.80
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2703 ms/op 1.5551 ms/op 0.82
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5734 ms/op 1.6595 ms/op 0.95
altair processInactivityUpdates - 250000 normalcase 23.141 ms/op 25.836 ms/op 0.90
altair processInactivityUpdates - 250000 worstcase 22.229 ms/op 27.493 ms/op 0.81
phase0 processRegistryUpdates - 250000 normalcase 6.2430 us/op 8.3560 us/op 0.75
phase0 processRegistryUpdates - 250000 badcase_full_deposits 237.93 us/op 289.55 us/op 0.82
phase0 processRegistryUpdates - 250000 worstcase 0.5 113.30 ms/op 141.76 ms/op 0.80
altair processRewardsAndPenalties - 250000 normalcase 53.979 ms/op 71.832 ms/op 0.75
altair processRewardsAndPenalties - 250000 worstcase 52.331 ms/op 78.510 ms/op 0.67
phase0 getAttestationDeltas - 250000 normalcase 6.4508 ms/op 8.3068 ms/op 0.78
phase0 getAttestationDeltas - 250000 worstcase 6.5948 ms/op 7.2078 ms/op 0.91
phase0 processSlashings - 250000 worstcase 3.5311 ms/op 4.1729 ms/op 0.85
altair processSyncCommitteeUpdates - 250000 170.93 ms/op 198.47 ms/op 0.86
BeaconState.hashTreeRoot - No change 258.00 ns/op 376.00 ns/op 0.69
BeaconState.hashTreeRoot - 1 full validator 50.469 us/op 55.154 us/op 0.92
BeaconState.hashTreeRoot - 32 full validator 501.72 us/op 611.82 us/op 0.82
BeaconState.hashTreeRoot - 512 full validator 5.7041 ms/op 5.7844 ms/op 0.99
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 60.559 us/op 79.440 us/op 0.76
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 858.99 us/op 969.03 us/op 0.89
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.056 ms/op 13.342 ms/op 0.83
BeaconState.hashTreeRoot - 1 balances 47.947 us/op 56.077 us/op 0.86
BeaconState.hashTreeRoot - 32 balances 430.41 us/op 545.17 us/op 0.79
BeaconState.hashTreeRoot - 512 balances 4.3402 ms/op 4.8891 ms/op 0.89
BeaconState.hashTreeRoot - 250000 balances 76.614 ms/op 84.624 ms/op 0.91
aggregationBits - 2048 els - zipIndexesInBitList 16.561 us/op 18.165 us/op 0.91
regular array get 100000 times 42.136 us/op 48.003 us/op 0.88
wrappedArray get 100000 times 32.195 us/op 36.208 us/op 0.89
arrayWithProxy get 100000 times 15.288 ms/op 18.806 ms/op 0.81
ssz.Root.equals 548.00 ns/op 648.00 ns/op 0.85
byteArrayEquals 531.00 ns/op 635.00 ns/op 0.84
shuffle list - 16384 els 6.7346 ms/op 7.1492 ms/op 0.94
shuffle list - 250000 els 100.10 ms/op 104.03 ms/op 0.96
processSlot - 1 slots 8.2530 us/op 9.4190 us/op 0.88
processSlot - 32 slots 1.2940 ms/op 1.4028 ms/op 0.92
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 33.516 ms/op 37.577 ms/op 0.89
getCommitteeAssignments - req 1 vs - 250000 vc 2.8868 ms/op 3.0118 ms/op 0.96
getCommitteeAssignments - req 100 vs - 250000 vc 4.0934 ms/op 4.2533 ms/op 0.96
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4237 ms/op 4.5951 ms/op 0.96
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.3600 ns/op 4.3000 ns/op 1.01
state getBlockRootAtSlot - 250000 vs - 7PWei 966.85 ns/op 924.74 ns/op 1.05
computeProposers - vc 250000 10.634 ms/op 10.781 ms/op 0.99
computeEpochShuffling - vc 250000 102.33 ms/op 104.74 ms/op 0.98
getNextSyncCommittee - vc 250000 176.68 ms/op 180.65 ms/op 0.98
computeSigningRoot for AttestationData 13.366 us/op 14.154 us/op 0.94
hash AttestationData serialized data then Buffer.toString(base64) 2.4258 us/op 2.4775 us/op 0.98
toHexString serialized data 1.0504 us/op 1.0962 us/op 0.96
Buffer.toString(base64) 305.93 ns/op 328.42 ns/op 0.93

by benchmarkbot/action

wemeetagain
wemeetagain approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the comments

@wemeetagain wemeetagain merged commit 9ba6d54 into unstable Jun 27, 2023
@wemeetagain wemeetagain deleted the nflaig/fix-yarn-warnings branch June 27, 2023 15:47
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

@nflaig nflaig mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain