fix: add undici to satisfy peer dep requirements

[bajtos]

The module native-fetch requires undici to be installed as its peer dependency.

Before this change, pnpm add was reporting a missing peer dependency.

dependencies:
+ dns-over-http-resolver 2.1.0

 WARN  Issues with peer dependencies found
.
└─┬ dns-over-http-resolver 2.1.0
  └─┬ native-fetch 4.0.2
    └── ✕ missing peer undici@"*"
Peer dependencies that should be installed:
  undici@"*"

With this change in place, there are no warnings reported.

dependencies:
+ dns-over-http-resolver 2.1.1

Progress: resolved 9, reused 9, downloaded 0, added 9, done

To be honest, I think it would be better to add undici as a dependency to native-fetch, as that would fix the problem for all consumers of native-fetch. However, in libp2p/js-libp2p#1487, @achingbrain suggested to fix the problem in this repo, so here we are.

Fixes #44

[achingbrain]

To be honest, I think it would be better to add undici as a dependency to native-fetch

This was done on purpose to allow consumers to control the version of undici they use. It's more of a legacy thing from when native-fetch used node-fetch which sometimes had interesting bugs in certain versions.

node 18 has global fetch so hopefully this whole sorry mess will go away soon, likely when electron ships with node 18 (landed in v23 nightlies a couple of weeks ago, so probably in a couple of months time?).

[github-actions]

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[bajtos]

To be honest, I think it would be better to add undici as a dependency to native-fetch

This was done on purpose to allow consumers to control the version of undici they use. It's more of a legacy thing from when native-fetch used node-fetch which sometimes had interesting bugs in certain versions.

Thank you for explaining the context 👍🏻

node 18 has global fetch so hopefully this whole sorry mess will go away soon, likely when electron ships with node 18 (landed in v23 nightlies a couple of weeks ago, so probably in a couple of months time?).

I am looking forward to that!

At the moment, native-fetch does not detect native fetch implementation in Node.js 18. Would you like me to open a pull request for that?

A possible blocker is that native fetch is still considered as an experimental feature in Node.js 18 and prints an ugly notice to stdout when used:

$ node
Welcome to Node.js v18.12.1.
Type ".help" for more information.
> await fetch('http://libp2p.io/')
(node:68539) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Response {
[...]

Compare that with fetch from undici, which does not print any warnings:

$ node
Welcome to Node.js v18.12.1.
Type ".help" for more information.
> const {fetch} = await import('undici')
undefined
> await fetch('http://libp2p.io/')
Response {
[...]