Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: v1.23.1 release #7262

Merged
merged 6 commits into from
Nov 29, 2024
Merged

chore: v1.23.1 release #7262

merged 6 commits into from
Nov 29, 2024

Conversation

philknows
Copy link
Member

@philknows philknows commented Nov 28, 2024 •
edited
Loading

Motivation

This PR includes hotfixes which also pertain to users of the mekong testnet.

Includes #7241, #7247, #7249, #7255

Added #7252 to unblock failing unit test.

philknows and others added 5 commits November 28, 2024 12:54
@philknows
chore: bump package versions to 1.23.1
36be6b3
@twoeths @nflaig
fix: prune checkpoint states at syncing time (#7241)
ffa4bb8 
* fix: prune checkpoint states at syncing time

* fix: lint

* fix: check-types in test
@twoeths @nflaig
fix: sync cached isCompoundingValidatorArr at epoch transition (#7247)
2c2326f
@twoeths @nflaig
fix: handle outOfRangeData when range sync Deneb (#7249)
f1e8198 
* fix: handle outOfRangeData for beaconBlocksMaybeBlobsByRange()

* fix: lint

* fix: archiveBlocks - handle deneb outOfRangeData block
@twoeths @nflaig
fix: sync cached balance when adding new validator to registry (#7255)
7f96e70 
* fix: sync cached balance when adding new validator to registry

* chore: add more comments

* fix: remove persisted checkpoint states from the previous run at startup
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 9996dfe Previous: - Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.8499 ms/op
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 43.546 us/op
BLS verify - blst 1.2846 ms/op
BLS verifyMultipleSignatures 3 - blst 2.0268 ms/op
BLS verifyMultipleSignatures 8 - blst 2.4672 ms/op
BLS verifyMultipleSignatures 32 - blst 7.3704 ms/op
BLS verifyMultipleSignatures 64 - blst 10.057 ms/op
BLS verifyMultipleSignatures 128 - blst 16.652 ms/op
BLS deserializing 10000 signatures 644.17 ms/op
BLS deserializing 100000 signatures 6.6672 s/op
BLS verifyMultipleSignatures - same message - 3 - blst 1.2534 ms/op
BLS verifyMultipleSignatures - same message - 8 - blst 1.3370 ms/op
BLS verifyMultipleSignatures - same message - 32 - blst 1.7746 ms/op
BLS verifyMultipleSignatures - same message - 64 - blst 2.5875 ms/op
BLS verifyMultipleSignatures - same message - 128 - blst 4.2814 ms/op
BLS aggregatePubkeys 32 - blst 19.118 us/op
BLS aggregatePubkeys 128 - blst 65.168 us/op
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 78.367 ms/op
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 56.791 ms/op
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 55.115 ms/op
getSlashingsAndExits - default max 90.493 us/op
getSlashingsAndExits - 2k 275.81 us/op
proposeBlockBody type=full, size=empty 5.6477 ms/op
isKnown best case - 1 super set check 293.00 ns/op
isKnown normal case - 2 super set checks 276.00 ns/op
isKnown worse case - 16 super set checks 277.00 ns/op
InMemoryCheckpointStateCache - add get delete 2.9760 us/op
updateUnfinalizedPubkeys - updating 10 pubkeys 917.05 us/op
updateUnfinalizedPubkeys - updating 100 pubkeys 3.2779 ms/op
updateUnfinalizedPubkeys - updating 1000 pubkeys 47.534 ms/op
validate api signedAggregateAndProof - struct 2.6293 ms/op
validate gossip signedAggregateAndProof - struct 2.6471 ms/op
batch validate gossip attestation - vc 640000 - chunk 32 135.26 us/op
batch validate gossip attestation - vc 640000 - chunk 64 116.10 us/op
batch validate gossip attestation - vc 640000 - chunk 128 104.19 us/op
batch validate gossip attestation - vc 640000 - chunk 256 103.55 us/op
pickEth1Vote - no votes 977.89 us/op
pickEth1Vote - max votes 6.9338 ms/op
pickEth1Vote - Eth1Data hashTreeRoot value x2048 14.259 ms/op
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.386 ms/op
pickEth1Vote - Eth1Data fastSerialize value x2048 449.50 us/op
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.1654 ms/op
bytes32 toHexString 418.00 ns/op
bytes32 Buffer.toString(hex) 248.00 ns/op
bytes32 Buffer.toString(hex) from Uint8Array 368.00 ns/op
bytes32 Buffer.toString(hex) + 0x 249.00 ns/op
Object access 1 prop 0.13600 ns/op
Map access 1 prop 0.13500 ns/op
Object get x1000 6.3580 ns/op
Map get x1000 6.4840 ns/op
Object set x1000 31.565 ns/op
Map set x1000 21.889 ns/op
Return object 10000 times 0.28390 ns/op
Throw Error 10000 times 3.2205 us/op
toHex 162.95 ns/op
Buffer.from 133.62 ns/op
shared Buffer 82.123 ns/op
fastMsgIdFn sha256 / 200 bytes 2.1930 us/op
fastMsgIdFn h32 xxhash / 200 bytes 223.00 ns/op
fastMsgIdFn h64 xxhash / 200 bytes 266.00 ns/op
fastMsgIdFn sha256 / 1000 bytes 7.2320 us/op
fastMsgIdFn h32 xxhash / 1000 bytes 350.00 ns/op
fastMsgIdFn h64 xxhash / 1000 bytes 337.00 ns/op
fastMsgIdFn sha256 / 10000 bytes 63.521 us/op
fastMsgIdFn h32 xxhash / 10000 bytes 1.7790 us/op
fastMsgIdFn h64 xxhash / 10000 bytes 1.1750 us/op
send data - 1000 256B messages 11.689 ms/op
send data - 1000 512B messages 15.669 ms/op
send data - 1000 1024B messages 26.607 ms/op
send data - 1000 1200B messages 25.684 ms/op
send data - 1000 2048B messages 30.708 ms/op
send data - 1000 4096B messages 29.854 ms/op
send data - 1000 16384B messages 72.240 ms/op
send data - 1000 65536B messages 202.98 ms/op
enrSubnets - fastDeserialize 64 bits 981.00 ns/op
enrSubnets - ssz BitVector 64 bits 344.00 ns/op
enrSubnets - fastDeserialize 4 bits 135.00 ns/op
enrSubnets - ssz BitVector 4 bits 354.00 ns/op
prioritizePeers score -10:0 att 32-0.1 sync 2-0 161.94 us/op
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 137.63 us/op
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 378.15 us/op
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 550.63 us/op
prioritizePeers score 0:0 att 64-1 sync 4-1 789.33 us/op
array of 16000 items push then shift 1.5817 us/op
LinkedList of 16000 items push then shift 6.8420 ns/op
array of 16000 items push then pop 100.68 ns/op
LinkedList of 16000 items push then pop 6.8690 ns/op
array of 24000 items push then shift 2.3920 us/op
LinkedList of 24000 items push then shift 6.9210 ns/op
array of 24000 items push then pop 127.58 ns/op
LinkedList of 24000 items push then pop 6.7720 ns/op
intersect bitArray bitLen 8 6.3110 ns/op
intersect array and set length 8 43.724 ns/op
intersect bitArray bitLen 128 28.687 ns/op
intersect array and set length 128 648.89 ns/op
bitArray.getTrueBitIndexes() bitLen 128 2.2970 us/op
bitArray.getTrueBitIndexes() bitLen 248 5.1580 us/op
bitArray.getTrueBitIndexes() bitLen 512 8.9350 us/op
Buffer.concat 32 items 890.00 ns/op
Uint8Array.set 32 items 1.8780 us/op
Buffer.copy 2.1720 us/op
Uint8Array.set - with subarray 2.7770 us/op
Uint8Array.set - without subarray 1.4920 us/op
getUint32 - dataview 232.00 ns/op
getUint32 - manual 146.00 ns/op
Set add up to 64 items then delete first 2.1441 us/op
OrderedSet add up to 64 items then delete first 3.2402 us/op
Set add up to 64 items then delete last 2.4434 us/op
OrderedSet add up to 64 items then delete last 3.7639 us/op
Set add up to 64 items then delete middle 2.4460 us/op
OrderedSet add up to 64 items then delete middle 5.0928 us/op
Set add up to 128 items then delete first 4.7743 us/op
OrderedSet add up to 128 items then delete first 7.0686 us/op
Set add up to 128 items then delete last 4.8215 us/op
OrderedSet add up to 128 items then delete last 7.3902 us/op
Set add up to 128 items then delete middle 4.6913 us/op
OrderedSet add up to 128 items then delete middle 13.069 us/op
Set add up to 256 items then delete first 9.7730 us/op
OrderedSet add up to 256 items then delete first 14.823 us/op
Set add up to 256 items then delete last 9.6609 us/op
OrderedSet add up to 256 items then delete last 15.063 us/op
Set add up to 256 items then delete middle 9.4366 us/op
OrderedSet add up to 256 items then delete middle 38.834 us/op
transfer serialized Status (84 B) 1.4030 us/op
copy serialized Status (84 B) 1.1390 us/op
transfer serialized SignedVoluntaryExit (112 B) 1.4490 us/op
copy serialized SignedVoluntaryExit (112 B) 1.1620 us/op
transfer serialized ProposerSlashing (416 B) 2.1100 us/op
copy serialized ProposerSlashing (416 B) 2.5100 us/op
transfer serialized Attestation (485 B) 2.5450 us/op
copy serialized Attestation (485 B) 2.5920 us/op
transfer serialized AttesterSlashing (33232 B) 2.6990 us/op
copy serialized AttesterSlashing (33232 B) 5.4810 us/op
transfer serialized Small SignedBeaconBlock (128000 B) 3.7280 us/op
copy serialized Small SignedBeaconBlock (128000 B) 15.106 us/op
transfer serialized Avg SignedBeaconBlock (200000 B) 4.1020 us/op
copy serialized Avg SignedBeaconBlock (200000 B) 21.569 us/op
transfer serialized BlobsSidecar (524380 B) 2.8600 us/op
copy serialized BlobsSidecar (524380 B) 86.588 us/op
transfer serialized Big SignedBeaconBlock (1000000 B) 3.1540 us/op
copy serialized Big SignedBeaconBlock (1000000 B) 145.67 us/op
pass gossip attestations to forkchoice per slot 2.7578 ms/op
forkChoice updateHead vc 100000 bc 64 eq 0 440.89 us/op
forkChoice updateHead vc 600000 bc 64 eq 0 2.9074 ms/op
forkChoice updateHead vc 1000000 bc 64 eq 0 4.6270 ms/op
forkChoice updateHead vc 600000 bc 320 eq 0 2.7229 ms/op
forkChoice updateHead vc 600000 bc 1200 eq 0 2.7875 ms/op
forkChoice updateHead vc 600000 bc 7200 eq 0 3.5691 ms/op
forkChoice updateHead vc 600000 bc 64 eq 1000 9.9052 ms/op
forkChoice updateHead vc 600000 bc 64 eq 10000 9.8895 ms/op
forkChoice updateHead vc 600000 bc 64 eq 300000 13.171 ms/op
computeDeltas 500000 validators 300 proto nodes 3.8839 ms/op
computeDeltas 500000 validators 1200 proto nodes 3.9246 ms/op
computeDeltas 500000 validators 7200 proto nodes 3.9363 ms/op
computeDeltas 750000 validators 300 proto nodes 5.8473 ms/op
computeDeltas 750000 validators 1200 proto nodes 5.9883 ms/op
computeDeltas 750000 validators 7200 proto nodes 6.0615 ms/op
computeDeltas 1400000 validators 300 proto nodes 11.294 ms/op
computeDeltas 1400000 validators 1200 proto nodes 11.595 ms/op
computeDeltas 1400000 validators 7200 proto nodes 11.091 ms/op
computeDeltas 2100000 validators 300 proto nodes 16.931 ms/op
computeDeltas 2100000 validators 1200 proto nodes 16.978 ms/op
computeDeltas 2100000 validators 7200 proto nodes 17.049 ms/op
altair processAttestation - 250000 vs - 7PWei normalcase 1.5916 ms/op
altair processAttestation - 250000 vs - 7PWei worstcase 2.5081 ms/op
altair processAttestation - setStatus - 1/6 committees join 79.995 us/op
altair processAttestation - setStatus - 1/3 committees join 169.31 us/op
altair processAttestation - setStatus - 1/2 committees join 238.96 us/op
altair processAttestation - setStatus - 2/3 committees join 306.34 us/op
altair processAttestation - setStatus - 4/5 committees join 457.29 us/op
altair processAttestation - setStatus - 100% committees join 545.20 us/op
altair processBlock - 250000 vs - 7PWei normalcase 5.9817 ms/op
altair processBlock - 250000 vs - 7PWei normalcase hashState 33.977 ms/op
altair processBlock - 250000 vs - 7PWei worstcase 46.042 ms/op
altair processBlock - 250000 vs - 7PWei worstcase hashState 89.306 ms/op
phase0 processBlock - 250000 vs - 7PWei normalcase 2.4784 ms/op
phase0 processBlock - 250000 vs - 7PWei worstcase 25.157 ms/op
altair processEth1Data - 250000 vs - 7PWei normalcase 313.38 us/op
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 7.5750 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 44.872 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 7.7010 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 8.4750 us/op
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 180.46 us/op
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.6425 ms/op
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.7794 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.4096 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.4763 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.2678 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.5453 ms/op
Tree 40 250000 create 198.08 ms/op
Tree 40 250000 get(125000) 136.75 ns/op
Tree 40 250000 set(125000) 618.36 ns/op
Tree 40 250000 toArray() 14.500 ms/op
Tree 40 250000 iterate all - toArray() + loop 14.609 ms/op
Tree 40 250000 iterate all - get(i) 52.451 ms/op
Array 250000 create 2.7625 ms/op
Array 250000 clone - spread 1.3994 ms/op
Array 250000 get(125000) 0.40000 ns/op
Array 250000 set(125000) 0.41700 ns/op
Array 250000 iterate all - loop 104.09 us/op
phase0 afterProcessEpoch - 250000 vs - 7PWei 47.587 ms/op
Array.fill - length 1000000 3.5624 ms/op
Array push - length 1000000 16.524 ms/op
Array.get 0.27094 ns/op
Uint8Array.get 0.43197 ns/op
phase0 beforeProcessEpoch - 250000 vs - 7PWei 17.552 ms/op
altair processEpoch - mainnet_e81889 306.22 ms/op
mainnet_e81889 - altair beforeProcessEpoch 18.046 ms/op
mainnet_e81889 - altair processJustificationAndFinalization 19.266 us/op
mainnet_e81889 - altair processInactivityUpdates 4.9659 ms/op
mainnet_e81889 - altair processRewardsAndPenalties 55.991 ms/op
mainnet_e81889 - altair processRegistryUpdates 2.7380 us/op
mainnet_e81889 - altair processSlashings 563.00 ns/op
mainnet_e81889 - altair processEth1DataReset 451.00 ns/op
mainnet_e81889 - altair processEffectiveBalanceUpdates 3.5559 ms/op
mainnet_e81889 - altair processSlashingsReset 4.5870 us/op
mainnet_e81889 - altair processRandaoMixesReset 5.3030 us/op
mainnet_e81889 - altair processHistoricalRootsUpdate 470.00 ns/op
mainnet_e81889 - altair processParticipationFlagUpdates 3.1870 us/op
mainnet_e81889 - altair processSyncCommitteeUpdates 495.00 ns/op
mainnet_e81889 - altair afterProcessEpoch 51.916 ms/op
capella processEpoch - mainnet_e217614 1.1058 s/op
mainnet_e217614 - capella beforeProcessEpoch 74.106 ms/op
mainnet_e217614 - capella processJustificationAndFinalization 22.019 us/op
mainnet_e217614 - capella processInactivityUpdates 16.628 ms/op
mainnet_e217614 - capella processRewardsAndPenalties 250.27 ms/op
mainnet_e217614 - capella processRegistryUpdates 21.673 us/op
mainnet_e217614 - capella processSlashings 651.00 ns/op
mainnet_e217614 - capella processEth1DataReset 300.00 ns/op
mainnet_e217614 - capella processEffectiveBalanceUpdates 14.765 ms/op
mainnet_e217614 - capella processSlashingsReset 5.3700 us/op
mainnet_e217614 - capella processRandaoMixesReset 8.4300 us/op
mainnet_e217614 - capella processHistoricalRootsUpdate 777.00 ns/op
mainnet_e217614 - capella processParticipationFlagUpdates 2.5730 us/op
mainnet_e217614 - capella afterProcessEpoch 126.42 ms/op
phase0 processEpoch - mainnet_e58758 343.61 ms/op
mainnet_e58758 - phase0 beforeProcessEpoch 81.119 ms/op
mainnet_e58758 - phase0 processJustificationAndFinalization 22.278 us/op
mainnet_e58758 - phase0 processRewardsAndPenalties 40.703 ms/op
mainnet_e58758 - phase0 processRegistryUpdates 10.740 us/op
mainnet_e58758 - phase0 processSlashings 513.00 ns/op
mainnet_e58758 - phase0 processEth1DataReset 617.00 ns/op
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1431 ms/op
mainnet_e58758 - phase0 processSlashingsReset 3.7680 us/op
mainnet_e58758 - phase0 processRandaoMixesReset 4.3980 us/op
mainnet_e58758 - phase0 processHistoricalRootsUpdate 353.00 ns/op
mainnet_e58758 - phase0 processParticipationRecordUpdates 2.9960 us/op
mainnet_e58758 - phase0 afterProcessEpoch 44.112 ms/op
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.2250 ms/op
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.5082 ms/op
altair processInactivityUpdates - 250000 normalcase 18.327 ms/op
altair processInactivityUpdates - 250000 worstcase 19.267 ms/op
phase0 processRegistryUpdates - 250000 normalcase 7.6510 us/op
phase0 processRegistryUpdates - 250000 badcase_full_deposits 316.45 us/op
phase0 processRegistryUpdates - 250000 worstcase 0.5 137.36 ms/op
altair processRewardsAndPenalties - 250000 normalcase 53.325 ms/op
altair processRewardsAndPenalties - 250000 worstcase 60.316 ms/op
phase0 getAttestationDeltas - 250000 normalcase 7.3273 ms/op
phase0 getAttestationDeltas - 250000 worstcase 7.2547 ms/op
phase0 processSlashings - 250000 worstcase 124.01 us/op
altair processSyncCommitteeUpdates - 250000 125.65 ms/op
BeaconState.hashTreeRoot - No change 251.00 ns/op
BeaconState.hashTreeRoot - 1 full validator 134.83 us/op
BeaconState.hashTreeRoot - 32 full validator 1.3036 ms/op
BeaconState.hashTreeRoot - 512 full validator 11.378 ms/op
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 166.84 us/op
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.2296 ms/op
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 29.726 ms/op
BeaconState.hashTreeRoot - 1 balances 111.23 us/op
BeaconState.hashTreeRoot - 32 balances 894.10 us/op
BeaconState.hashTreeRoot - 512 balances 8.5225 ms/op
BeaconState.hashTreeRoot - 250000 balances 180.62 ms/op
aggregationBits - 2048 els - zipIndexesInBitList 22.962 us/op
byteArrayEquals 32 53.086 ns/op
Buffer.compare 32 16.883 ns/op
byteArrayEquals 1024 1.5639 us/op
Buffer.compare 1024 24.494 ns/op
byteArrayEquals 16384 24.922 us/op
Buffer.compare 16384 183.05 ns/op
byteArrayEquals 123687377 188.10 ms/op
Buffer.compare 123687377 6.1023 ms/op
byteArrayEquals 32 - diff last byte 51.884 ns/op
Buffer.compare 32 - diff last byte 16.878 ns/op
byteArrayEquals 1024 - diff last byte 1.5613 us/op
Buffer.compare 1024 - diff last byte 25.730 ns/op
byteArrayEquals 16384 - diff last byte 24.905 us/op
Buffer.compare 16384 - diff last byte 183.95 ns/op
byteArrayEquals 123687377 - diff last byte 188.48 ms/op
Buffer.compare 123687377 - diff last byte 6.1743 ms/op
byteArrayEquals 32 - random bytes 4.9770 ns/op
Buffer.compare 32 - random bytes 16.604 ns/op
byteArrayEquals 1024 - random bytes 6.4010 ns/op
Buffer.compare 1024 - random bytes 16.616 ns/op
byteArrayEquals 16384 - random bytes 4.9740 ns/op
Buffer.compare 16384 - random bytes 16.600 ns/op
byteArrayEquals 123687377 - random bytes 6.2600 ns/op
Buffer.compare 123687377 - random bytes 17.920 ns/op
regular array get 100000 times 41.618 us/op
wrappedArray get 100000 times 31.801 us/op
arrayWithProxy get 100000 times 13.444 ms/op
ssz.Root.equals 44.482 ns/op
byteArrayEquals 43.858 ns/op
Buffer.compare 10.042 ns/op
processSlot - 1 slots 17.696 us/op
processSlot - 32 slots 3.3553 ms/op
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 42.025 ms/op
getCommitteeAssignments - req 1 vs - 250000 vc 2.0550 ms/op
getCommitteeAssignments - req 100 vs - 250000 vc 4.0073 ms/op
getCommitteeAssignments - req 1000 vs - 250000 vc 4.2692 ms/op
findModifiedValidators - 10000 modified validators 238.55 ms/op
findModifiedValidators - 1000 modified validators 180.83 ms/op
findModifiedValidators - 100 modified validators 165.15 ms/op
findModifiedValidators - 10 modified validators 165.15 ms/op
findModifiedValidators - 1 modified validators 149.23 ms/op
findModifiedValidators - no difference 162.08 ms/op
compare ViewDUs 3.2053 s/op
compare each validator Uint8Array 1.8185 s/op
compare ViewDU to Uint8Array 937.18 ms/op
migrate state 1000000 validators, 24 modified, 0 new 768.79 ms/op
migrate state 1000000 validators, 1700 modified, 1000 new 1.0442 s/op
migrate state 1000000 validators, 3400 modified, 2000 new 1.2886 s/op
migrate state 1500000 validators, 24 modified, 0 new 782.84 ms/op
migrate state 1500000 validators, 1700 modified, 1000 new 1.0225 s/op
migrate state 1500000 validators, 3400 modified, 2000 new 1.2657 s/op
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.1700 ns/op
state getBlockRootAtSlot - 250000 vs - 7PWei 644.80 ns/op
computeProposers - vc 250000 6.5013 ms/op
computeEpochShuffling - vc 250000 40.381 ms/op
getNextSyncCommittee - vc 250000 117.69 ms/op
computeSigningRoot for AttestationData 25.174 us/op
hash AttestationData serialized data then Buffer.toString(base64) 1.5465 us/op
toHexString serialized data 858.27 ns/op
Buffer.toString(base64) 179.30 ns/op
nodejs block root to RootHex using toHex 146.74 ns/op
nodejs block root to RootHex using toRootHex 92.775 ns/op
browser block root to RootHex using the deprecated toHexString 221.51 ns/op
browser block root to RootHex using toHex 176.88 ns/op
browser block root to RootHex using toRootHex 158.20 ns/op

by benchmarkbot/action

@philknows philknows marked this pull request as ready for review November 28, 2024 22:16
@philknows philknows requested a review from a team as a code owner November 28, 2024 22:16
twoeths
twoeths previously approved these changes Nov 29, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 48.71%. Comparing base (72be9fd) to head (9f4e7e6).
Report is 7 commits behind head on stable.

Additional details and impacted files 
@@            Coverage Diff             @@
##           stable    #7262      +/-   ##
==========================================
- Coverage   49.36%   48.71%   -0.66%     
==========================================
  Files         599      599              
  Lines       39958    39972      +14     
  Branches     2103     2059      -44     
==========================================
- Hits        19724    19471     -253     
- Misses      20194    20461     +267     
  Partials       40       40

@philknows philknows merged commit f778821 into stable Nov 29, 2024
21 checks passed
@philknows philknows deleted the rc/v1.23.1 branch November 29, 2024 19:23
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.23.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philknows @wemeetagain @twoeths @nflaig