Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skip web3_provider unit tests #7252

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore: skip web3_provider unit tests #7252

merged 1 commit into from
Nov 27, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Nov 27, 2024

Motivation

see #7250

Description

This PR skips the web3_provider unit tests for now until we figure out a more robust solution to test this code without relying on external sources

@nflaig nflaig requested a review from a team as a code owner November 27, 2024 06:24
@nflaig nflaig enabled auto-merge (squash) November 27, 2024 06:34
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.51%. Comparing base (b78cb92) to head (90d79fb).
Report is 1 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #7252      +/-   ##
============================================
- Coverage     49.14%   48.51%   -0.64%     
============================================
  Files           600      600              
  Lines         40121    40121              
  Branches       2093     2054      -39     
============================================
- Hits          19719    19466     -253     
- Misses        20364    20617     +253     
  Partials         38       38

@nflaig nflaig merged commit 18f4218 into unstable Nov 27, 2024
19 of 20 checks passed
@nflaig nflaig deleted the nflaig/skip-web3-provider-tests branch November 27, 2024 06:46
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Performance Alert ⚠️

Possible performance regression was detected for some benchmarks.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold.

Benchmark suite Current: dce72f5 Previous: b78cb92 Ratio
Array.fill - length 1000000 8.3778 ms/op 2.5817 ms/op 3.25
phase0 beforeProcessEpoch - 250000 vs - 7PWei 43.008 ms/op 12.122 ms/op 3.55
Full benchmark results
Benchmark suite Current: dce72f5 Previous: b78cb92 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.0195 ms/op 2.3636 ms/op 0.85
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 50.917 us/op 75.104 us/op 0.68
BLS verify - blst 792.90 us/op 879.66 us/op 0.90
BLS verifyMultipleSignatures 3 - blst 1.1999 ms/op 1.3506 ms/op 0.89
BLS verifyMultipleSignatures 8 - blst 1.6928 ms/op 2.2216 ms/op 0.76
BLS verifyMultipleSignatures 32 - blst 5.0050 ms/op 6.3587 ms/op 0.79
BLS verifyMultipleSignatures 64 - blst 9.3188 ms/op 11.207 ms/op 0.83
BLS verifyMultipleSignatures 128 - blst 17.848 ms/op 21.691 ms/op 0.82
BLS deserializing 10000 signatures 704.73 ms/op 670.72 ms/op 1.05
BLS deserializing 100000 signatures 6.9823 s/op 6.9543 s/op 1.00
BLS verifyMultipleSignatures - same message - 3 - blst 888.19 us/op 928.46 us/op 0.96
BLS verifyMultipleSignatures - same message - 8 - blst 997.32 us/op 1.0317 ms/op 0.97
BLS verifyMultipleSignatures - same message - 32 - blst 1.7120 ms/op 1.8293 ms/op 0.94
BLS verifyMultipleSignatures - same message - 64 - blst 2.6800 ms/op 2.8070 ms/op 0.95
BLS verifyMultipleSignatures - same message - 128 - blst 4.4497 ms/op 4.4043 ms/op 1.01
BLS aggregatePubkeys 32 - blst 20.275 us/op 19.468 us/op 1.04
BLS aggregatePubkeys 128 - blst 71.343 us/op 67.614 us/op 1.06
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 107.85 ms/op 136.91 ms/op 0.79
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 51.718 ms/op 70.702 ms/op 0.73
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 42.633 ms/op 48.592 ms/op 0.88
getSlashingsAndExits - default max 104.49 us/op 119.09 us/op 0.88
getSlashingsAndExits - 2k 319.41 us/op 430.95 us/op 0.74
proposeBlockBody type=full, size=empty 6.4125 ms/op 6.4601 ms/op 0.99
isKnown best case - 1 super set check 326.00 ns/op 585.00 ns/op 0.56
isKnown normal case - 2 super set checks 307.00 ns/op 606.00 ns/op 0.51
isKnown worse case - 16 super set checks 306.00 ns/op 599.00 ns/op 0.51
InMemoryCheckpointStateCache - add get delete 3.0310 us/op 3.4720 us/op 0.87
validate api signedAggregateAndProof - struct 1.4469 ms/op 1.6020 ms/op 0.90
validate gossip signedAggregateAndProof - struct 1.4401 ms/op 1.6810 ms/op 0.86
batch validate gossip attestation - vc 640000 - chunk 32 133.58 us/op 134.48 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 64 115.57 us/op 128.61 us/op 0.90
batch validate gossip attestation - vc 640000 - chunk 128 112.02 us/op 122.14 us/op 0.92
batch validate gossip attestation - vc 640000 - chunk 256 106.00 us/op 122.43 us/op 0.87
pickEth1Vote - no votes 1.1534 ms/op 1.2147 ms/op 0.95
pickEth1Vote - max votes 5.8934 ms/op 12.066 ms/op 0.49
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.298 ms/op 22.741 ms/op 0.58
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 19.403 ms/op 36.837 ms/op 0.53
pickEth1Vote - Eth1Data fastSerialize value x2048 549.08 us/op 591.98 us/op 0.93
pickEth1Vote - Eth1Data fastSerialize tree x2048 3.0638 ms/op 3.1316 ms/op 0.98
bytes32 toHexString 452.00 ns/op 585.00 ns/op 0.77
bytes32 Buffer.toString(hex) 250.00 ns/op 225.00 ns/op 1.11
bytes32 Buffer.toString(hex) from Uint8Array 362.00 ns/op 451.00 ns/op 0.80
bytes32 Buffer.toString(hex) + 0x 262.00 ns/op 224.00 ns/op 1.17
Object access 1 prop 0.14100 ns/op 0.18000 ns/op 0.78
Map access 1 prop 0.13300 ns/op 0.11100 ns/op 1.20
Object get x1000 5.9650 ns/op 5.0230 ns/op 1.19
Map get x1000 6.5270 ns/op 5.8550 ns/op 1.11
Object set x1000 39.225 ns/op 35.968 ns/op 1.09
Map set x1000 26.336 ns/op 27.023 ns/op 0.97
Return object 10000 times 0.29540 ns/op 0.31090 ns/op 0.95
Throw Error 10000 times 3.4339 us/op 3.0405 us/op 1.13
toHex 155.21 ns/op 130.15 ns/op 1.19
Buffer.from 139.22 ns/op 119.75 ns/op 1.16
shared Buffer 102.30 ns/op 80.728 ns/op 1.27
fastMsgIdFn sha256 / 200 bytes 2.4120 us/op 1.9800 us/op 1.22
fastMsgIdFn h32 xxhash / 200 bytes 245.00 ns/op 247.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 270.00 ns/op 225.00 ns/op 1.20
fastMsgIdFn sha256 / 1000 bytes 7.5240 us/op 5.9820 us/op 1.26
fastMsgIdFn h32 xxhash / 1000 bytes 386.00 ns/op 384.00 ns/op 1.01
fastMsgIdFn h64 xxhash / 1000 bytes 351.00 ns/op 322.00 ns/op 1.09
fastMsgIdFn sha256 / 10000 bytes 65.265 us/op 50.433 us/op 1.29
fastMsgIdFn h32 xxhash / 10000 bytes 1.9090 us/op 1.8030 us/op 1.06
fastMsgIdFn h64 xxhash / 10000 bytes 1.2400 us/op 1.1610 us/op 1.07
send data - 1000 256B messages 13.057 ms/op 13.840 ms/op 0.94
send data - 1000 512B messages 17.632 ms/op 19.185 ms/op 0.92
send data - 1000 1024B messages 28.726 ms/op 26.673 ms/op 1.08
send data - 1000 1200B messages 30.263 ms/op 31.290 ms/op 0.97
send data - 1000 2048B messages 36.334 ms/op 43.947 ms/op 0.83
send data - 1000 4096B messages 33.047 ms/op 32.803 ms/op 1.01
send data - 1000 16384B messages 86.984 ms/op 84.363 ms/op 1.03
send data - 1000 65536B messages 245.42 ms/op 185.60 ms/op 1.32
enrSubnets - fastDeserialize 64 bits 1.1290 us/op 890.00 ns/op 1.27
enrSubnets - ssz BitVector 64 bits 366.00 ns/op 280.00 ns/op 1.31
enrSubnets - fastDeserialize 4 bits 160.00 ns/op 120.00 ns/op 1.33
enrSubnets - ssz BitVector 4 bits 376.00 ns/op 276.00 ns/op 1.36
prioritizePeers score -10:0 att 32-0.1 sync 2-0 148.93 us/op 138.22 us/op 1.08
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 166.09 us/op 137.78 us/op 1.21
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 258.24 us/op 288.63 us/op 0.89
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 399.30 us/op 493.81 us/op 0.81
prioritizePeers score 0:0 att 64-1 sync 4-1 665.78 us/op 777.88 us/op 0.86
array of 16000 items push then shift 1.6865 us/op 1.3672 us/op 1.23
LinkedList of 16000 items push then shift 7.4110 ns/op 6.9590 ns/op 1.06
array of 16000 items push then pop 108.64 ns/op 116.62 ns/op 0.93
LinkedList of 16000 items push then pop 7.1100 ns/op 6.3200 ns/op 1.13
array of 24000 items push then shift 2.4491 us/op 1.9599 us/op 1.25
LinkedList of 24000 items push then shift 7.2480 ns/op 6.5860 ns/op 1.10
array of 24000 items push then pop 140.01 ns/op 157.18 ns/op 0.89
LinkedList of 24000 items push then pop 7.0520 ns/op 6.0300 ns/op 1.17
intersect bitArray bitLen 8 6.5120 ns/op 5.5230 ns/op 1.18
intersect array and set length 8 44.650 ns/op 39.555 ns/op 1.13
intersect bitArray bitLen 128 30.376 ns/op 26.854 ns/op 1.13
intersect array and set length 128 668.08 ns/op 645.52 ns/op 1.03
bitArray.getTrueBitIndexes() bitLen 128 1.8190 us/op 2.0880 us/op 0.87
bitArray.getTrueBitIndexes() bitLen 248 2.8040 us/op 3.8520 us/op 0.73
bitArray.getTrueBitIndexes() bitLen 512 6.6970 us/op 9.5240 us/op 0.70
Buffer.concat 32 items 940.00 ns/op 968.00 ns/op 0.97
Uint8Array.set 32 items 1.5140 us/op 1.8380 us/op 0.82
Buffer.copy 1.7020 us/op 2.0000 us/op 0.85
Uint8Array.set - with subarray 2.6200 us/op 3.2440 us/op 0.81
Uint8Array.set - without subarray 1.6060 us/op 1.8510 us/op 0.87
getUint32 - dataview 236.00 ns/op 292.00 ns/op 0.81
getUint32 - manual 155.00 ns/op 286.00 ns/op 0.54
Set add up to 64 items then delete first 2.2379 us/op 2.8635 us/op 0.78
OrderedSet add up to 64 items then delete first 3.5841 us/op 4.6323 us/op 0.77
Set add up to 64 items then delete last 2.6052 us/op 3.0921 us/op 0.84
OrderedSet add up to 64 items then delete last 3.9720 us/op 3.4348 us/op 1.16
Set add up to 64 items then delete middle 2.6104 us/op 2.4623 us/op 1.06
OrderedSet add up to 64 items then delete middle 5.5397 us/op 5.1023 us/op 1.09
Set add up to 128 items then delete first 5.1888 us/op 4.4423 us/op 1.17
OrderedSet add up to 128 items then delete first 7.6057 us/op 6.7966 us/op 1.12
Set add up to 128 items then delete last 5.4698 us/op 4.1111 us/op 1.33
OrderedSet add up to 128 items then delete last 8.1484 us/op 6.3057 us/op 1.29
Set add up to 128 items then delete middle 5.2627 us/op 4.1567 us/op 1.27
OrderedSet add up to 128 items then delete middle 15.619 us/op 12.205 us/op 1.28
Set add up to 256 items then delete first 10.475 us/op 8.5156 us/op 1.23
OrderedSet add up to 256 items then delete first 15.831 us/op 13.419 us/op 1.18
Set add up to 256 items then delete last 10.708 us/op 7.9135 us/op 1.35
OrderedSet add up to 256 items then delete last 16.345 us/op 12.245 us/op 1.33
Set add up to 256 items then delete middle 10.456 us/op 7.8654 us/op 1.33
OrderedSet add up to 256 items then delete middle 44.175 us/op 35.314 us/op 1.25
transfer serialized Status (84 B) 1.5030 us/op 1.1150 us/op 1.35
copy serialized Status (84 B) 1.2500 us/op 1.0150 us/op 1.23
transfer serialized SignedVoluntaryExit (112 B) 1.4830 us/op 1.3630 us/op 1.09
copy serialized SignedVoluntaryExit (112 B) 1.1870 us/op 1.0220 us/op 1.16
transfer serialized ProposerSlashing (416 B) 1.6310 us/op 1.3960 us/op 1.17
copy serialized ProposerSlashing (416 B) 1.4280 us/op 1.5320 us/op 0.93
transfer serialized Attestation (485 B) 1.5280 us/op 1.9800 us/op 0.77
copy serialized Attestation (485 B) 1.5940 us/op 1.5450 us/op 1.03
transfer serialized AttesterSlashing (33232 B) 2.4320 us/op 1.6700 us/op 1.46
copy serialized AttesterSlashing (33232 B) 8.1310 us/op 4.1190 us/op 1.97
transfer serialized Small SignedBeaconBlock (128000 B) 3.4710 us/op 1.7800 us/op 1.95
copy serialized Small SignedBeaconBlock (128000 B) 21.716 us/op 10.577 us/op 2.05
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2810 us/op 2.5450 us/op 1.29
copy serialized Avg SignedBeaconBlock (200000 B) 24.654 us/op 15.172 us/op 1.62
transfer serialized BlobsSidecar (524380 B) 3.3570 us/op 2.6480 us/op 1.27
copy serialized BlobsSidecar (524380 B) 126.00 us/op 75.373 us/op 1.67
transfer serialized Big SignedBeaconBlock (1000000 B) 3.6980 us/op 3.0180 us/op 1.23
copy serialized Big SignedBeaconBlock (1000000 B) 174.34 us/op 138.68 us/op 1.26
pass gossip attestations to forkchoice per slot 2.9611 ms/op 2.5612 ms/op 1.16
forkChoice updateHead vc 100000 bc 64 eq 0 465.00 us/op 368.56 us/op 1.26
forkChoice updateHead vc 600000 bc 64 eq 0 2.9049 ms/op 2.4736 ms/op 1.17
forkChoice updateHead vc 1000000 bc 64 eq 0 5.2079 ms/op 3.9233 ms/op 1.33
forkChoice updateHead vc 600000 bc 320 eq 0 2.8998 ms/op 2.2119 ms/op 1.31
forkChoice updateHead vc 600000 bc 1200 eq 0 3.3057 ms/op 2.3455 ms/op 1.41
forkChoice updateHead vc 600000 bc 7200 eq 0 4.4188 ms/op 2.7267 ms/op 1.62
forkChoice updateHead vc 600000 bc 64 eq 1000 10.641 ms/op 9.5770 ms/op 1.11
forkChoice updateHead vc 600000 bc 64 eq 10000 10.606 ms/op 9.5504 ms/op 1.11
forkChoice updateHead vc 600000 bc 64 eq 300000 14.051 ms/op 11.809 ms/op 1.19
computeDeltas 500000 validators 300 proto nodes 4.2037 ms/op 3.4093 ms/op 1.23
computeDeltas 500000 validators 1200 proto nodes 4.1920 ms/op 3.3709 ms/op 1.24
computeDeltas 500000 validators 7200 proto nodes 4.2392 ms/op 3.4934 ms/op 1.21
computeDeltas 750000 validators 300 proto nodes 6.1653 ms/op 5.1454 ms/op 1.20
computeDeltas 750000 validators 1200 proto nodes 6.4952 ms/op 5.1250 ms/op 1.27
computeDeltas 750000 validators 7200 proto nodes 6.6971 ms/op 5.2201 ms/op 1.28
computeDeltas 1400000 validators 300 proto nodes 12.871 ms/op 9.8807 ms/op 1.30
computeDeltas 1400000 validators 1200 proto nodes 13.445 ms/op 9.6585 ms/op 1.39
computeDeltas 1400000 validators 7200 proto nodes 13.954 ms/op 10.899 ms/op 1.28
computeDeltas 2100000 validators 300 proto nodes 21.337 ms/op 19.094 ms/op 1.12
computeDeltas 2100000 validators 1200 proto nodes 20.509 ms/op 21.321 ms/op 0.96
computeDeltas 2100000 validators 7200 proto nodes 19.786 ms/op 23.969 ms/op 0.83
altair processAttestation - 250000 vs - 7PWei normalcase 2.6112 ms/op 1.9593 ms/op 1.33
altair processAttestation - 250000 vs - 7PWei worstcase 3.8996 ms/op 2.9925 ms/op 1.30
altair processAttestation - setStatus - 1/6 committees join 120.54 us/op 128.27 us/op 0.94
altair processAttestation - setStatus - 1/3 committees join 214.48 us/op 226.08 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 281.17 us/op 316.20 us/op 0.89
altair processAttestation - setStatus - 2/3 committees join 395.25 us/op 371.16 us/op 1.06
altair processAttestation - setStatus - 4/5 committees join 634.44 us/op 520.30 us/op 1.22
altair processAttestation - setStatus - 100% committees join 735.62 us/op 624.76 us/op 1.18
altair processBlock - 250000 vs - 7PWei normalcase 8.3684 ms/op 5.4820 ms/op 1.53
altair processBlock - 250000 vs - 7PWei normalcase hashState 29.136 ms/op 26.030 ms/op 1.12
altair processBlock - 250000 vs - 7PWei worstcase 39.022 ms/op 34.020 ms/op 1.15
altair processBlock - 250000 vs - 7PWei worstcase hashState 76.665 ms/op 69.640 ms/op 1.10
phase0 processBlock - 250000 vs - 7PWei normalcase 2.4619 ms/op 1.9036 ms/op 1.29
phase0 processBlock - 250000 vs - 7PWei worstcase 25.746 ms/op 25.087 ms/op 1.03
altair processEth1Data - 250000 vs - 7PWei normalcase 482.19 us/op 328.36 us/op 1.47
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.6920 us/op 4.4190 us/op 1.97
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 45.461 us/op 28.808 us/op 1.58
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 11.169 us/op 6.9410 us/op 1.61
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.7030 us/op 6.7480 us/op 0.99
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 162.06 us/op 128.69 us/op 1.26
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.2499 ms/op 828.40 us/op 1.51
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.6639 ms/op 1.1145 ms/op 1.49
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.7071 ms/op 1.1441 ms/op 1.49
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.9801 ms/op 2.7872 ms/op 1.43
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.6693 ms/op 1.1994 ms/op 1.39
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.1622 ms/op 2.8647 ms/op 1.45
Tree 40 250000 create 270.52 ms/op 187.82 ms/op 1.44
Tree 40 250000 get(125000) 166.88 ns/op 113.83 ns/op 1.47
Tree 40 250000 set(125000) 799.53 ns/op 560.84 ns/op 1.43
Tree 40 250000 toArray() 21.250 ms/op 16.751 ms/op 1.27
Tree 40 250000 iterate all - toArray() + loop 21.001 ms/op 16.938 ms/op 1.24
Tree 40 250000 iterate all - get(i) 63.877 ms/op 45.591 ms/op 1.40
Array 250000 create 3.9346 ms/op 2.9778 ms/op 1.32
Array 250000 clone - spread 1.6967 ms/op 1.2812 ms/op 1.32
Array 250000 get(125000) 0.46400 ns/op 0.35300 ns/op 1.31
Array 250000 set(125000) 0.48500 ns/op 0.36000 ns/op 1.35
Array 250000 iterate all - loop 87.160 us/op 74.576 us/op 1.17
phase0 afterProcessEpoch - 250000 vs - 7PWei 57.436 ms/op 41.338 ms/op 1.39
Array.fill - length 1000000 8.3778 ms/op 2.5817 ms/op 3.25
Array push - length 1000000 35.066 ms/op 13.789 ms/op 2.54
Array.get 0.29917 ns/op 0.25894 ns/op 1.16
Uint8Array.get 0.46100 ns/op 0.33866 ns/op 1.36
phase0 beforeProcessEpoch - 250000 vs - 7PWei 43.008 ms/op 12.122 ms/op 3.55
altair processEpoch - mainnet_e81889 362.01 ms/op 281.34 ms/op 1.29
mainnet_e81889 - altair beforeProcessEpoch 25.489 ms/op 19.473 ms/op 1.31
mainnet_e81889 - altair processJustificationAndFinalization 25.957 us/op 12.843 us/op 2.02
mainnet_e81889 - altair processInactivityUpdates 8.1256 ms/op 4.0961 ms/op 1.98
mainnet_e81889 - altair processRewardsAndPenalties 55.379 ms/op 48.593 ms/op 1.14
mainnet_e81889 - altair processRegistryUpdates 3.3790 us/op 1.2500 us/op 2.70
mainnet_e81889 - altair processSlashings 1.0210 us/op 273.00 ns/op 3.74
mainnet_e81889 - altair processEth1DataReset 1.2570 us/op 253.00 ns/op 4.97
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.1865 ms/op 1.7566 ms/op 1.24
mainnet_e81889 - altair processSlashingsReset 5.9130 us/op 2.9420 us/op 2.01
mainnet_e81889 - altair processRandaoMixesReset 9.2960 us/op 3.4140 us/op 2.72
mainnet_e81889 - altair processHistoricalRootsUpdate 819.00 ns/op 352.00 ns/op 2.33
mainnet_e81889 - altair processParticipationFlagUpdates 3.4850 us/op 1.5100 us/op 2.31
mainnet_e81889 - altair processSyncCommitteeUpdates 476.00 ns/op 314.00 ns/op 1.52
mainnet_e81889 - altair afterProcessEpoch 59.859 ms/op 43.775 ms/op 1.37
capella processEpoch - mainnet_e217614 1.4631 s/op 1.1019 s/op 1.33
mainnet_e217614 - capella beforeProcessEpoch 127.39 ms/op 69.541 ms/op 1.83
mainnet_e217614 - capella processJustificationAndFinalization 23.701 us/op 18.628 us/op 1.27
mainnet_e217614 - capella processInactivityUpdates 23.041 ms/op 15.927 ms/op 1.45
mainnet_e217614 - capella processRewardsAndPenalties 239.08 ms/op 237.04 ms/op 1.01
mainnet_e217614 - capella processRegistryUpdates 12.981 us/op 11.889 us/op 1.09
mainnet_e217614 - capella processSlashings 433.00 ns/op 868.00 ns/op 0.50
mainnet_e217614 - capella processEth1DataReset 350.00 ns/op 327.00 ns/op 1.07
mainnet_e217614 - capella processEffectiveBalanceUpdates 15.872 ms/op 17.311 ms/op 0.92
mainnet_e217614 - capella processSlashingsReset 2.5550 us/op 2.0290 us/op 1.26
mainnet_e217614 - capella processRandaoMixesReset 3.8530 us/op 2.2400 us/op 1.72
mainnet_e217614 - capella processHistoricalRootsUpdate 521.00 ns/op 410.00 ns/op 1.27
mainnet_e217614 - capella processParticipationFlagUpdates 3.4670 us/op 1.9100 us/op 1.82
mainnet_e217614 - capella afterProcessEpoch 131.90 ms/op 105.74 ms/op 1.25
phase0 processEpoch - mainnet_e58758 387.78 ms/op 285.77 ms/op 1.36
mainnet_e58758 - phase0 beforeProcessEpoch 88.765 ms/op 63.418 ms/op 1.40
mainnet_e58758 - phase0 processJustificationAndFinalization 17.123 us/op 12.248 us/op 1.40
mainnet_e58758 - phase0 processRewardsAndPenalties 40.015 ms/op 35.465 ms/op 1.13
mainnet_e58758 - phase0 processRegistryUpdates 8.9270 us/op 11.859 us/op 0.75
mainnet_e58758 - phase0 processSlashings 399.00 ns/op 548.00 ns/op 0.73
mainnet_e58758 - phase0 processEth1DataReset 415.00 ns/op 261.00 ns/op 1.59
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.7656 ms/op 2.1376 ms/op 0.83
mainnet_e58758 - phase0 processSlashingsReset 3.7360 us/op 4.3990 us/op 0.85
mainnet_e58758 - phase0 processRandaoMixesReset 6.0140 us/op 5.9710 us/op 1.01
mainnet_e58758 - phase0 processHistoricalRootsUpdate 434.00 ns/op 576.00 ns/op 0.75
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.6550 us/op 4.6490 us/op 0.79
mainnet_e58758 - phase0 afterProcessEpoch 47.442 ms/op 37.535 ms/op 1.26
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9358 ms/op 1.0482 ms/op 1.85
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.5255 ms/op 3.4674 ms/op 0.73
altair processInactivityUpdates - 250000 normalcase 16.717 ms/op 19.626 ms/op 0.85
altair processInactivityUpdates - 250000 worstcase 18.507 ms/op 19.547 ms/op 0.95
phase0 processRegistryUpdates - 250000 normalcase 9.4390 us/op 12.936 us/op 0.73
phase0 processRegistryUpdates - 250000 badcase_full_deposits 297.39 us/op 437.04 us/op 0.68
phase0 processRegistryUpdates - 250000 worstcase 0.5 137.28 ms/op 134.76 ms/op 1.02
altair processRewardsAndPenalties - 250000 normalcase 39.930 ms/op 43.517 ms/op 0.92
altair processRewardsAndPenalties - 250000 worstcase 48.453 ms/op 44.718 ms/op 1.08
phase0 getAttestationDeltas - 250000 normalcase 11.351 ms/op 8.5952 ms/op 1.32
phase0 getAttestationDeltas - 250000 worstcase 8.5917 ms/op 7.3601 ms/op 1.17
phase0 processSlashings - 250000 worstcase 96.596 us/op 92.803 us/op 1.04
altair processSyncCommitteeUpdates - 250000 139.79 ms/op 104.22 ms/op 1.34
BeaconState.hashTreeRoot - No change 236.00 ns/op 186.00 ns/op 1.27
BeaconState.hashTreeRoot - 1 full validator 117.21 us/op 104.54 us/op 1.12
BeaconState.hashTreeRoot - 32 full validator 1.2724 ms/op 1.5358 ms/op 0.83
BeaconState.hashTreeRoot - 512 full validator 12.331 ms/op 12.621 ms/op 0.98
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 151.63 us/op 150.84 us/op 1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.0259 ms/op 2.2765 ms/op 0.89
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 31.263 ms/op 31.186 ms/op 1.00
BeaconState.hashTreeRoot - 1 balances 163.77 us/op 139.06 us/op 1.18
BeaconState.hashTreeRoot - 32 balances 1.5026 ms/op 1.1991 ms/op 1.25
BeaconState.hashTreeRoot - 512 balances 11.504 ms/op 10.088 ms/op 1.14
BeaconState.hashTreeRoot - 250000 balances 219.19 ms/op 189.48 ms/op 1.16
aggregationBits - 2048 els - zipIndexesInBitList 43.999 us/op 37.106 us/op 1.19
byteArrayEquals 32 58.223 ns/op 48.562 ns/op 1.20
Buffer.compare 32 19.466 ns/op 16.254 ns/op 1.20
byteArrayEquals 1024 1.7665 us/op 1.3124 us/op 1.35
Buffer.compare 1024 28.836 ns/op 24.387 ns/op 1.18
byteArrayEquals 16384 28.517 us/op 20.933 us/op 1.36
Buffer.compare 16384 232.52 ns/op 175.80 ns/op 1.32
byteArrayEquals 123687377 212.38 ms/op 161.69 ms/op 1.31
Buffer.compare 123687377 10.836 ms/op 7.4250 ms/op 1.46
byteArrayEquals 32 - diff last byte 58.937 ns/op 52.658 ns/op 1.12
Buffer.compare 32 - diff last byte 19.730 ns/op 16.208 ns/op 1.22
byteArrayEquals 1024 - diff last byte 1.8189 us/op 1.4015 us/op 1.30
Buffer.compare 1024 - diff last byte 29.940 ns/op 23.720 ns/op 1.26
byteArrayEquals 16384 - diff last byte 29.606 us/op 21.348 us/op 1.39
Buffer.compare 16384 - diff last byte 244.94 ns/op 225.56 ns/op 1.09
byteArrayEquals 123687377 - diff last byte 207.59 ms/op 163.30 ms/op 1.27
Buffer.compare 123687377 - diff last byte 11.891 ms/op 7.9360 ms/op 1.50
byteArrayEquals 32 - random bytes 5.7210 ns/op 4.9410 ns/op 1.16
Buffer.compare 32 - random bytes 18.703 ns/op 16.156 ns/op 1.16
byteArrayEquals 1024 - random bytes 6.0630 ns/op 5.0270 ns/op 1.21
Buffer.compare 1024 - random bytes 18.523 ns/op 15.948 ns/op 1.16
byteArrayEquals 16384 - random bytes 5.5750 ns/op 5.2280 ns/op 1.07
Buffer.compare 16384 - random bytes 18.412 ns/op 16.625 ns/op 1.11
byteArrayEquals 123687377 - random bytes 7.0300 ns/op 6.1500 ns/op 1.14
Buffer.compare 123687377 - random bytes 20.740 ns/op 20.000 ns/op 1.04
regular array get 100000 times 43.583 us/op 32.518 us/op 1.34
wrappedArray get 100000 times 42.674 us/op 32.469 us/op 1.31
arrayWithProxy get 100000 times 16.479 ms/op 12.961 ms/op 1.27
ssz.Root.equals 56.239 ns/op 52.452 ns/op 1.07
byteArrayEquals 49.609 ns/op 45.968 ns/op 1.08
Buffer.compare 11.561 ns/op 9.5730 ns/op 1.21
processSlot - 1 slots 18.161 us/op 16.503 us/op 1.10
processSlot - 32 slots 3.5991 ms/op 3.2445 ms/op 1.11
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 38.818 ms/op 40.355 ms/op 0.96
getCommitteeAssignments - req 1 vs - 250000 vc 2.2430 ms/op 1.8572 ms/op 1.21
getCommitteeAssignments - req 100 vs - 250000 vc 4.4711 ms/op 3.6669 ms/op 1.22
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6531 ms/op 3.9910 ms/op 1.17
findModifiedValidators - 10000 modified validators 282.23 ms/op 340.62 ms/op 0.83
findModifiedValidators - 1000 modified validators 195.83 ms/op 289.83 ms/op 0.68
findModifiedValidators - 100 modified validators 183.70 ms/op 190.31 ms/op 0.97
findModifiedValidators - 10 modified validators 177.98 ms/op 232.28 ms/op 0.77
findModifiedValidators - 1 modified validators 171.25 ms/op 215.38 ms/op 0.80
findModifiedValidators - no difference 197.83 ms/op 226.42 ms/op 0.87
compare ViewDUs 3.3921 s/op 3.8806 s/op 0.87
compare each validator Uint8Array 1.6849 s/op 1.9211 s/op 0.88
compare ViewDU to Uint8Array 1.2189 s/op 1.0756 s/op 1.13
migrate state 1000000 validators, 24 modified, 0 new 732.63 ms/op 751.61 ms/op 0.97
migrate state 1000000 validators, 1700 modified, 1000 new 981.11 ms/op 967.55 ms/op 1.01
migrate state 1000000 validators, 3400 modified, 2000 new 1.1486 s/op 1.1651 s/op 0.99
migrate state 1500000 validators, 24 modified, 0 new 720.65 ms/op 790.80 ms/op 0.91
migrate state 1500000 validators, 1700 modified, 1000 new 954.52 ms/op 1.2110 s/op 0.79
migrate state 1500000 validators, 3400 modified, 2000 new 1.1592 s/op 1.3024 s/op 0.89
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.1900 ns/op 4.8600 ns/op 0.86
state getBlockRootAtSlot - 250000 vs - 7PWei 774.95 ns/op 988.12 ns/op 0.78
computeProposers - vc 250000 7.4950 ms/op 7.4131 ms/op 1.01
computeEpochShuffling - vc 250000 40.122 ms/op 36.312 ms/op 1.10
getNextSyncCommittee - vc 250000 125.44 ms/op 124.84 ms/op 1.00
computeSigningRoot for AttestationData 24.906 us/op 26.513 us/op 0.94
hash AttestationData serialized data then Buffer.toString(base64) 1.5157 us/op 1.3141 us/op 1.15
toHexString serialized data 860.95 ns/op 875.04 ns/op 0.98
Buffer.toString(base64) 178.62 ns/op 213.15 ns/op 0.84
nodejs block root to RootHex using toHex 157.81 ns/op 174.73 ns/op 0.90
nodejs block root to RootHex using toRootHex 91.594 ns/op 89.673 ns/op 1.02
browser block root to RootHex using the deprecated toHexString 226.32 ns/op 221.92 ns/op 1.02
browser block root to RootHex using toHex 179.49 ns/op 241.01 ns/op 0.74
browser block root to RootHex using toRootHex 166.63 ns/op 210.03 ns/op 0.79

by benchmarkbot/action

philknows pushed a commit that referenced this pull request Nov 29, 2024
@nflaig @philknows
chore: skip web3_provider unit tests (#7252)
9f4e7e6
@philknows philknows mentioned this pull request Nov 29, 2024
Merged
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.23.1 🎉

wemeetagain added a commit that referenced this pull request Dec 20, 2024
@wemeetagain @nflaig
@nazarhussain @g11tech @matthewkeil @ensi321 @twoeths @philknows @dependabot @acolytec3 @varunguleriaCodes @ClockworkYuzu
chore: release v1.24.0 (#7325)
11f35a8 
* feat: add keymanager endpoint to retrieve proposer config (#7210)

* feat: add keymanager endpoint to retrieve proposer config

* Do not return empty builder config

* Check all builder proposer config values

* Fix settings builder config if undefined

* Fix builder config parsing

* Use ssz type to handle json serialization

Default parsing can't handle BigInt

* Revert "Use ssz type to handle json serialization"

This reverts commit 01fcea7.

* Fix boost factor json serialization

* Remove unused import

* Update test data

* Update proposer config test

* feat: add mekong network option (#7212)

* chore: fix import order with biome syntax (#7211)

Fix import order

* fix: consistently validate pubkey and throw 404 if not found (#7214)

* Throw error if pubkey is unknown when getting graffiti

* Consistently validate pubkey and throw 404 if not found

* fix: only return local keys from /eth/v1/keystores (#7215)

* fix: only return local keys from /eth/v1/keystores

* Fix fetching remote keys in node assertion

* feat: add and use getBlobsV1 to expedite gossip import (#7134)

* hookup the getblobs api to get bob and proof data from el

remove unused

fix import

metrics overhault, test, debugging testing, some feeback

fix

add nethermind bug dicussion link

fix

resolve conflicts

* deblobs timeout

* fix metric

* chore: revert async aggregate with randomness (#7218)

Revert "feat: asyncAggregateWithRandomness (#7204)"

This reverts commit e31d535.

* fix: update config for relaunched mekong network (#7220)

* fix: light client generating `LightClientUpdate` with wrong length of branches (#7187)

* initial commit

* Rewrite SyncCommitteeWitnessRepository

* Fix finality branch

* Update unit test

* fix e2e

* Review PR

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* fix: archive finalized state when shutting down beacon node (#7221)

* Fix typo

* feat: remove unfinalized pubkey cache (#7230)

* Remove unfinalized pubkey cache

* lint

* Fix unit test

* chore: skip web3_provider unit tests (#7252)

* fix: prune checkpoint states at syncing time (#7241)

* fix: prune checkpoint states at syncing time

* fix: lint

* fix: check-types in test

* fix: sync cached isCompoundingValidatorArr at epoch transition (#7247)

* fix: handle outOfRangeData when range sync Deneb (#7249)

* fix: handle outOfRangeData for beaconBlocksMaybeBlobsByRange()

* fix: lint

* fix: archiveBlocks - handle deneb outOfRangeData block

* fix: sync cached balance when adding new validator to registry (#7255)

* fix: sync cached balance when adding new validator to registry

* chore: add more comments

* fix: remove persisted checkpoint states from the previous run at startup

* fix: do not throw error when trying to prune missing directory (#7257)

* docs: update documentation Oct 2024 (#7178)

* docs update oct 2024 init

* Reconfig quickstart nav and minor fixes

* fix lint

* spelling fixes

* minor fixes and add to wordlist

* prettier fix

* add to wordlist

* sort wordlist

* modify dominance to include lighthouse

* fix typescript casing and add recommendation

* add selection and boost_factor with keymanager notice

* update wordlist

* remove builder enabled and add keymanager api

* spelling

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (#7268)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add error log to notifier if execution client auth failed (#7239)

* feat: add error log to notifier if execution client auth failed

* Update packages/beacon-node/src/node/notifier.ts

---------

Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>

* docs: display rcConfig flag on CLI reference page (#7270)

* docs: display rcConfig flag on CLI reference page

* Update word list

* chore: remove prettier as default formatter for all file types (#7275)

* chore: unhide flags relevant for devnets / testing (#7271)

* feat: debug too many shuffling promises (#7251)

* feat: add asyncShufflingCalculation to StateTransitionOpts

* feat: add asyncShufflingCalculation to all regen / processSlots consumers

* fix: default to false for async shuffling and remove unnecessary props

* fix: remove unnecessary flags from stateTransition

* feat: implement conditional build of shuffling for prepareNextSlot

* fix: spec test bug where shufflingCache is present from BeaconChain constructor

* feat: sync build next shuffling if not queued async

* fix: use getSync to pull next shuffling correctly

* docs: add comment to prepareNextSlot

* refactor: rename StateCloneOpts to StateRegenerationOpts

* feat: pass asyncShufflingCalculation through to afterProcessEpoch and refactor conditional to run purely sync

* docs: add issue number to comment

* chore: lint

* chore: unpin nodejs version from 22.4 (#6982)

* Revert "chore: pin nodejs version to 22.4 (#6964)"

This reverts commit f20484b.

* Don't revert formatting changes

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Cayman <caymannava@gmail.com>

* chore: update bootnodes file url for holesky and sepolia (#7276)

* feat: add `debug_getHistoricalSummaries` endpoint (#7245)

* feat: add new getHistoricalSummaries endpoint to debug namespace

* Add JSON response

* Restructure to use stateId and add proof to response

* add test scaffolding

* Address feedback

* Move getHistoricalSummaries to lodestar namespace

* add lodestar namespace unit test

* update route name to lodestar namespace

* cast state object as Capella state

* Lint

* json properties need to be lower case

* Make it v1 since it's now part of lodestar namespace

* Group with other /lodestar endpoints

* Simplify beacon node impl

* Rename return type

* Update test description

* Fix variable name

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore: log sync committee signature errors as `error` (#7283)

* fix: update engine_getClientVersionV1 commit encoding (#7282)

* fix: check pubkey or validator index known to a state (#7284)

* fix: check pubkey or validator index known to a state

* chore: add more comments

* feat: lodestar script setup (#7254)

* feat: lodestar_setup

* feat: script_updates + docs

* feat: script_addition_in_docs + command_update

* Remove duplicate script from docs folder

* Minor script updates

* Update script to prepare docs and ignore copied file

* Update installation page

* Wording

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* feat: add terminal-sized Electra giraffe banner (#7286)

* Create giraffeBanners.ts

* Wire in banner

* Fix file name

* lint

* Address @nflaig's comment

---------

Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>

* chore: pin nodejs version to 22.4 (#7291)

Revert "chore: unpin nodejs version from 22.4 (#6982)"

This reverts commit 69ae688.

* feat: expose `DOMAIN_APPLICATION_MASK` in config/spec api (#7296)

* feat: expose DOMAIN_APPLICATION_MASK in config/spec api

* Lint

* feat: make `MAX_REQUEST_BLOB_SIDECARS` and `MAX_BLOBS_PER_BLOCK` configurable (#7294)

* Init commit

* Fix check-types

* Add comment on how MAX_REQUEST_BLOB_SIDECARS is calculated

* Ensure proper config object is passed

* Address comment

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* feat: use `BLOB_SIDECAR_SUBNET_COUNT` to configure blob subnets (#7297)

feat: use BLOB_SIDECAR_SUBNET_COUNT to configure blob subnets

* chore: log sync aggregate participants when producing beacon block body (#7300)

* chore: log sync aggregate participants when producing beacon block body

* Use isForkLightClient instead of ForkSeq

* Fix produce block unit tests

* chore: print graffiti when producing beacon block body (#7303)

* fix: warn if engine / builder failed to produce block within cutoff time (#7305)

* feat: add kzg commitment length check when validating gossip blocks (#7302)

* feat: add blob sidecar index check (#7313)

Validate blobSidecar index

* fix: fix blob sidecar index check (#7315)

Fix index check

* chore: fix format of printed graffiti from hex to utf-8 (#7306)

* chore: fix format of printed graffiti from hex to utf-8

* Use Buffer.from no copy with offset

* docs: batch commit typos and update contributor readme (#7312)

* batch commit typos and update contributor readme

* update donation text

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* correct spelling

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore: remove trailing null bytes from printed graffiti (#7320)

* chore: remove trailing null bytes from printed graffiti

* Use replaceAll instead of regex

* chore: unpin nodejs version from 22.4 (#7324)

Revert "chore: pin nodejs version to 22.4 (#7291)"

This reverts commit 99794d3.

* chore: bump package versions to 1.24.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>
Co-authored-by: g11tech <develop@g11tech.io>
Co-authored-by: Matthew Keil <me@matthewkeil.com>
Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>
Co-authored-by: twoeths <tuyen@chainsafe.io>
Co-authored-by: Phil Ngo <58080811+philknows@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: Varun Guleria <152203177+varunguleriaCodes@users.noreply.github.com>
Co-authored-by: ClockworkYuzu <yvetteheh@gmail.com>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.24.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflaig @wemeetagain @twoeths