Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unpin nodejs version from 22.4 #7324

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: unpin nodejs version from 22.4 #7324

merged 1 commit into from
Dec 20, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Dec 20, 2024

This reverts commit 99794d3.

unpin nodejs version from 22.4

@nflaig nflaig requested a review from a team as a code owner December 20, 2024 13:55
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.75%. Comparing base (ffdfb2e) to head (43c743b).
Report is 2 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7324   +/-   ##
=========================================
  Coverage     48.75%   48.75%           
=========================================
  Files           601      601           
  Lines         40222    40222           
  Branches       2061     2061           
=========================================
  Hits          19609    19609           
  Misses        20575    20575           
  Partials         38       38

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 315592c Previous: ffdfb2e Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.8727 ms/op 2.2827 ms/op 0.82
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 50.605 us/op 54.829 us/op 0.92
BLS verify - blst 822.90 us/op 1.1079 ms/op 0.74
BLS verifyMultipleSignatures 3 - blst 1.2616 ms/op 1.5723 ms/op 0.80
BLS verifyMultipleSignatures 8 - blst 1.7582 ms/op 1.9587 ms/op 0.90
BLS verifyMultipleSignatures 32 - blst 5.0281 ms/op 6.0627 ms/op 0.83
BLS verifyMultipleSignatures 64 - blst 9.5478 ms/op 11.562 ms/op 0.83
BLS verifyMultipleSignatures 128 - blst 18.048 ms/op 18.458 ms/op 0.98
BLS deserializing 10000 signatures 722.80 ms/op 753.05 ms/op 0.96
BLS deserializing 100000 signatures 7.1178 s/op 7.4136 s/op 0.96
BLS verifyMultipleSignatures - same message - 3 - blst 945.56 us/op 1.0817 ms/op 0.87
BLS verifyMultipleSignatures - same message - 8 - blst 1.0859 ms/op 1.1420 ms/op 0.95
BLS verifyMultipleSignatures - same message - 32 - blst 1.7493 ms/op 1.9394 ms/op 0.90
BLS verifyMultipleSignatures - same message - 64 - blst 2.6308 ms/op 2.8616 ms/op 0.92
BLS verifyMultipleSignatures - same message - 128 - blst 4.4144 ms/op 5.0042 ms/op 0.88
BLS aggregatePubkeys 32 - blst 20.027 us/op 22.404 us/op 0.89
BLS aggregatePubkeys 128 - blst 71.041 us/op 83.138 us/op 0.85
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 63.622 ms/op 67.414 ms/op 0.94
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 52.496 ms/op 64.765 ms/op 0.81
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 43.726 ms/op 54.091 ms/op 0.81
getSlashingsAndExits - default max 143.06 us/op 139.42 us/op 1.03
getSlashingsAndExits - 2k 506.20 us/op 336.46 us/op 1.50
proposeBlockBody type=full, size=empty 5.9916 ms/op 6.2594 ms/op 0.96
isKnown best case - 1 super set check 314.00 ns/op 346.00 ns/op 0.91
isKnown normal case - 2 super set checks 316.00 ns/op 364.00 ns/op 0.87
isKnown worse case - 16 super set checks 285.00 ns/op 366.00 ns/op 0.78
InMemoryCheckpointStateCache - add get delete 2.9320 us/op 2.9100 us/op 1.01
validate api signedAggregateAndProof - struct 1.5276 ms/op 2.3678 ms/op 0.65
validate gossip signedAggregateAndProof - struct 1.4447 ms/op 2.3896 ms/op 0.60
batch validate gossip attestation - vc 640000 - chunk 32 132.32 us/op 142.53 us/op 0.93
batch validate gossip attestation - vc 640000 - chunk 64 117.46 us/op 123.73 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 128 108.69 us/op 112.06 us/op 0.97
batch validate gossip attestation - vc 640000 - chunk 256 104.16 us/op 106.53 us/op 0.98
pickEth1Vote - no votes 1.0675 ms/op 1.1484 ms/op 0.93
pickEth1Vote - max votes 5.5100 ms/op 6.4550 ms/op 0.85
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.913 ms/op 13.295 ms/op 1.05
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 16.214 ms/op 25.090 ms/op 0.65
pickEth1Vote - Eth1Data fastSerialize value x2048 475.48 us/op 596.90 us/op 0.80
pickEth1Vote - Eth1Data fastSerialize tree x2048 2.4365 ms/op 3.1947 ms/op 0.76
bytes32 toHexString 426.00 ns/op 510.00 ns/op 0.84
bytes32 Buffer.toString(hex) 240.00 ns/op 296.00 ns/op 0.81
bytes32 Buffer.toString(hex) from Uint8Array 376.00 ns/op 440.00 ns/op 0.85
bytes32 Buffer.toString(hex) + 0x 240.00 ns/op 290.00 ns/op 0.83
Object access 1 prop 0.13900 ns/op 0.15300 ns/op 0.91
Map access 1 prop 0.13900 ns/op 0.14900 ns/op 0.93
Object get x1000 6.2970 ns/op 6.4430 ns/op 0.98
Map get x1000 7.0850 ns/op 6.7650 ns/op 1.05
Object set x1000 36.731 ns/op 37.364 ns/op 0.98
Map set x1000 22.869 ns/op 24.613 ns/op 0.93
Return object 10000 times 0.29760 ns/op 0.30910 ns/op 0.96
Throw Error 10000 times 3.4292 us/op 3.5445 us/op 0.97
toHex 142.30 ns/op 186.31 ns/op 0.76
Buffer.from 148.79 ns/op 158.88 ns/op 0.94
shared Buffer 90.417 ns/op 117.90 ns/op 0.77
fastMsgIdFn sha256 / 200 bytes 2.2970 us/op 2.3340 us/op 0.98
fastMsgIdFn h32 xxhash / 200 bytes 242.00 ns/op 276.00 ns/op 0.88
fastMsgIdFn h64 xxhash / 200 bytes 275.00 ns/op 286.00 ns/op 0.96
fastMsgIdFn sha256 / 1000 bytes 7.6630 us/op 7.9530 us/op 0.96
fastMsgIdFn h32 xxhash / 1000 bytes 392.00 ns/op 420.00 ns/op 0.93
fastMsgIdFn h64 xxhash / 1000 bytes 357.00 ns/op 361.00 ns/op 0.99
fastMsgIdFn sha256 / 10000 bytes 66.151 us/op 69.093 us/op 0.96
fastMsgIdFn h32 xxhash / 10000 bytes 1.9230 us/op 1.9740 us/op 0.97
fastMsgIdFn h64 xxhash / 10000 bytes 1.2300 us/op 1.2940 us/op 0.95
send data - 1000 256B messages 12.109 ms/op 15.039 ms/op 0.81
send data - 1000 512B messages 16.490 ms/op 17.899 ms/op 0.92
send data - 1000 1024B messages 26.986 ms/op 28.288 ms/op 0.95
send data - 1000 1200B messages 24.731 ms/op 27.032 ms/op 0.91
send data - 1000 2048B messages 32.048 ms/op 32.138 ms/op 1.00
send data - 1000 4096B messages 30.597 ms/op 35.734 ms/op 0.86
send data - 1000 16384B messages 74.785 ms/op 77.927 ms/op 0.96
send data - 1000 65536B messages 222.82 ms/op 283.99 ms/op 0.78
enrSubnets - fastDeserialize 64 bits 1.3060 us/op 1.3300 us/op 0.98
enrSubnets - ssz BitVector 64 bits 419.00 ns/op 474.00 ns/op 0.88
enrSubnets - fastDeserialize 4 bits 167.00 ns/op 214.00 ns/op 0.78
enrSubnets - ssz BitVector 4 bits 358.00 ns/op 463.00 ns/op 0.77
prioritizePeers score -10:0 att 32-0.1 sync 2-0 140.86 us/op 205.39 us/op 0.69
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 187.92 us/op 211.29 us/op 0.89
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 264.59 us/op 322.37 us/op 0.82
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 424.50 us/op 510.54 us/op 0.83
prioritizePeers score 0:0 att 64-1 sync 4-1 540.43 us/op 881.92 us/op 0.61
array of 16000 items push then shift 1.7618 us/op 1.8991 us/op 0.93
LinkedList of 16000 items push then shift 7.5920 ns/op 8.6400 ns/op 0.88
array of 16000 items push then pop 110.24 ns/op 145.42 ns/op 0.76
LinkedList of 16000 items push then pop 7.6300 ns/op 8.2320 ns/op 0.93
array of 24000 items push then shift 2.5578 us/op 2.6910 us/op 0.95
LinkedList of 24000 items push then shift 7.8780 ns/op 8.9190 ns/op 0.88
array of 24000 items push then pop 136.14 ns/op 198.99 ns/op 0.68
LinkedList of 24000 items push then pop 7.0360 ns/op 8.1670 ns/op 0.86
intersect bitArray bitLen 8 6.5190 ns/op 7.0480 ns/op 0.92
intersect array and set length 8 44.741 ns/op 65.864 ns/op 0.68
intersect bitArray bitLen 128 30.388 ns/op 32.164 ns/op 0.94
intersect array and set length 128 677.29 ns/op 937.46 ns/op 0.72
bitArray.getTrueBitIndexes() bitLen 128 1.4460 us/op 2.3700 us/op 0.61
bitArray.getTrueBitIndexes() bitLen 248 2.4410 us/op 4.3020 us/op 0.57
bitArray.getTrueBitIndexes() bitLen 512 4.5510 us/op 9.1500 us/op 0.50
Buffer.concat 32 items 766.00 ns/op 1.0870 us/op 0.70
Uint8Array.set 32 items 1.4360 us/op 1.9840 us/op 0.72
Buffer.copy 2.5060 us/op 1.9550 us/op 1.28
Uint8Array.set - with subarray 2.0730 us/op 3.5160 us/op 0.59
Uint8Array.set - without subarray 1.3070 us/op 1.7050 us/op 0.77
getUint32 - dataview 234.00 ns/op 325.00 ns/op 0.72
getUint32 - manual 154.00 ns/op 260.00 ns/op 0.59
Set add up to 64 items then delete first 2.2601 us/op 3.0680 us/op 0.74
OrderedSet add up to 64 items then delete first 3.3303 us/op 4.3002 us/op 0.77
Set add up to 64 items then delete last 2.7124 us/op 3.5031 us/op 0.77
OrderedSet add up to 64 items then delete last 3.9475 us/op 5.0716 us/op 0.78
Set add up to 64 items then delete middle 2.6069 us/op 3.3550 us/op 0.78
OrderedSet add up to 64 items then delete middle 5.4586 us/op 6.6866 us/op 0.82
Set add up to 128 items then delete first 5.2355 us/op 6.7746 us/op 0.77
OrderedSet add up to 128 items then delete first 7.7792 us/op 11.977 us/op 0.65
Set add up to 128 items then delete last 5.2394 us/op 7.2615 us/op 0.72
OrderedSet add up to 128 items then delete last 7.8156 us/op 11.768 us/op 0.66
Set add up to 128 items then delete middle 5.1382 us/op 7.0978 us/op 0.72
OrderedSet add up to 128 items then delete middle 14.078 us/op 18.472 us/op 0.76
Set add up to 256 items then delete first 10.392 us/op 14.535 us/op 0.71
OrderedSet add up to 256 items then delete first 15.406 us/op 23.460 us/op 0.66
Set add up to 256 items then delete last 11.302 us/op 13.913 us/op 0.81
OrderedSet add up to 256 items then delete last 17.124 us/op 22.156 us/op 0.77
Set add up to 256 items then delete middle 10.380 us/op 13.422 us/op 0.77
OrderedSet add up to 256 items then delete middle 42.558 us/op 49.952 us/op 0.85
transfer serialized Status (84 B) 2.8090 us/op 1.5400 us/op 1.82
copy serialized Status (84 B) 1.4590 us/op 1.3550 us/op 1.08
transfer serialized SignedVoluntaryExit (112 B) 3.0610 us/op 1.5900 us/op 1.93
copy serialized SignedVoluntaryExit (112 B) 1.6890 us/op 1.4270 us/op 1.18
transfer serialized ProposerSlashing (416 B) 3.7860 us/op 1.8740 us/op 2.02
copy serialized ProposerSlashing (416 B) 2.1950 us/op 1.8940 us/op 1.16
transfer serialized Attestation (485 B) 3.6030 us/op 2.1280 us/op 1.69
copy serialized Attestation (485 B) 2.1370 us/op 1.9250 us/op 1.11
transfer serialized AttesterSlashing (33232 B) 3.4050 us/op 1.8790 us/op 1.81
copy serialized AttesterSlashing (33232 B) 5.3640 us/op 7.9460 us/op 0.68
transfer serialized Small SignedBeaconBlock (128000 B) 4.3110 us/op 2.7120 us/op 1.59
copy serialized Small SignedBeaconBlock (128000 B) 14.729 us/op 27.012 us/op 0.55
transfer serialized Avg SignedBeaconBlock (200000 B) 4.5900 us/op 4.0780 us/op 1.13
copy serialized Avg SignedBeaconBlock (200000 B) 21.013 us/op 37.509 us/op 0.56
transfer serialized BlobsSidecar (524380 B) 4.6670 us/op 4.1820 us/op 1.12
copy serialized BlobsSidecar (524380 B) 83.836 us/op 105.24 us/op 0.80
transfer serialized Big SignedBeaconBlock (1000000 B) 4.7010 us/op 4.2500 us/op 1.11
copy serialized Big SignedBeaconBlock (1000000 B) 166.50 us/op 202.32 us/op 0.82
pass gossip attestations to forkchoice per slot 2.8524 ms/op 3.0851 ms/op 0.92
forkChoice updateHead vc 100000 bc 64 eq 0 466.65 us/op 497.96 us/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 0 2.9111 ms/op 4.7493 ms/op 0.61
forkChoice updateHead vc 1000000 bc 64 eq 0 5.2847 ms/op 6.5941 ms/op 0.80
forkChoice updateHead vc 600000 bc 320 eq 0 2.8152 ms/op 3.3644 ms/op 0.84
forkChoice updateHead vc 600000 bc 1200 eq 0 2.9089 ms/op 3.2884 ms/op 0.88
forkChoice updateHead vc 600000 bc 7200 eq 0 3.8899 ms/op 5.9929 ms/op 0.65
forkChoice updateHead vc 600000 bc 64 eq 1000 10.916 ms/op 11.575 ms/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 10000 10.718 ms/op 10.989 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 300000 14.902 ms/op 16.124 ms/op 0.92
computeDeltas 500000 validators 300 proto nodes 4.4571 ms/op 4.6668 ms/op 0.96
computeDeltas 500000 validators 1200 proto nodes 4.5980 ms/op 4.8292 ms/op 0.95
computeDeltas 500000 validators 7200 proto nodes 4.4108 ms/op 4.5104 ms/op 0.98
computeDeltas 750000 validators 300 proto nodes 6.6750 ms/op 6.7989 ms/op 0.98
computeDeltas 750000 validators 1200 proto nodes 6.9167 ms/op 7.2264 ms/op 0.96
computeDeltas 750000 validators 7200 proto nodes 6.5421 ms/op 6.8860 ms/op 0.95
computeDeltas 1400000 validators 300 proto nodes 13.161 ms/op 13.198 ms/op 1.00
computeDeltas 1400000 validators 1200 proto nodes 14.041 ms/op 14.674 ms/op 0.96
computeDeltas 1400000 validators 7200 proto nodes 12.251 ms/op 14.671 ms/op 0.84
computeDeltas 2100000 validators 300 proto nodes 18.272 ms/op 20.875 ms/op 0.88
computeDeltas 2100000 validators 1200 proto nodes 18.964 ms/op 21.144 ms/op 0.90
computeDeltas 2100000 validators 7200 proto nodes 17.819 ms/op 20.784 ms/op 0.86
altair processAttestation - 250000 vs - 7PWei normalcase 1.9582 ms/op 2.7340 ms/op 0.72
altair processAttestation - 250000 vs - 7PWei worstcase 2.7921 ms/op 3.6362 ms/op 0.77
altair processAttestation - setStatus - 1/6 committees join 105.50 us/op 124.56 us/op 0.85
altair processAttestation - setStatus - 1/3 committees join 185.85 us/op 224.42 us/op 0.83
altair processAttestation - setStatus - 1/2 committees join 263.44 us/op 335.67 us/op 0.78
altair processAttestation - setStatus - 2/3 committees join 341.30 us/op 412.60 us/op 0.83
altair processAttestation - setStatus - 4/5 committees join 495.39 us/op 598.01 us/op 0.83
altair processAttestation - setStatus - 100% committees join 604.96 us/op 707.80 us/op 0.85
altair processBlock - 250000 vs - 7PWei normalcase 4.1370 ms/op 9.1218 ms/op 0.45
altair processBlock - 250000 vs - 7PWei normalcase hashState 30.838 ms/op 29.873 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase 34.693 ms/op 51.573 ms/op 0.67
altair processBlock - 250000 vs - 7PWei worstcase hashState 70.632 ms/op 88.399 ms/op 0.80
phase0 processBlock - 250000 vs - 7PWei normalcase 1.6560 ms/op 2.8068 ms/op 0.59
phase0 processBlock - 250000 vs - 7PWei worstcase 20.824 ms/op 29.534 ms/op 0.71
altair processEth1Data - 250000 vs - 7PWei normalcase 319.00 us/op 532.62 us/op 0.60
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 6.3040 us/op 7.6390 us/op 0.83
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 47.021 us/op 44.292 us/op 1.06
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 13.426 us/op 14.513 us/op 0.93
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.7100 us/op 7.3930 us/op 0.91
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 172.61 us/op 165.63 us/op 1.04
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0188 ms/op 1.4907 ms/op 0.68
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.4525 ms/op 1.6192 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.4896 ms/op 2.1657 ms/op 0.69
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.9116 ms/op 4.1997 ms/op 0.93
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.8089 ms/op 1.9807 ms/op 0.91
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.6891 ms/op 4.3100 ms/op 1.09
Tree 40 250000 create 205.64 ms/op 255.91 ms/op 0.80
Tree 40 250000 get(125000) 140.20 ns/op 165.44 ns/op 0.85
Tree 40 250000 set(125000) 629.82 ns/op 766.35 ns/op 0.82
Tree 40 250000 toArray() 14.881 ms/op 18.205 ms/op 0.82
Tree 40 250000 iterate all - toArray() + loop 14.857 ms/op 20.347 ms/op 0.73
Tree 40 250000 iterate all - get(i) 47.624 ms/op 57.827 ms/op 0.82
Array 250000 create 2.7775 ms/op 3.6490 ms/op 0.76
Array 250000 clone - spread 1.3973 ms/op 1.6549 ms/op 0.84
Array 250000 get(125000) 0.39500 ns/op 0.44000 ns/op 0.90
Array 250000 set(125000) 0.42200 ns/op 0.47600 ns/op 0.89
Array 250000 iterate all - loop 80.414 us/op 86.137 us/op 0.93
phase0 afterProcessEpoch - 250000 vs - 7PWei 48.537 ms/op 54.669 ms/op 0.89
Array.fill - length 1000000 3.5701 ms/op 3.9513 ms/op 0.90
Array push - length 1000000 16.682 ms/op 19.813 ms/op 0.84
Array.get 0.26779 ns/op 0.27344 ns/op 0.98
Uint8Array.get 0.42987 ns/op 0.45088 ns/op 0.95
phase0 beforeProcessEpoch - 250000 vs - 7PWei 15.769 ms/op 20.107 ms/op 0.78
altair processEpoch - mainnet_e81889 270.59 ms/op 338.47 ms/op 0.80
mainnet_e81889 - altair beforeProcessEpoch 17.470 ms/op 24.356 ms/op 0.72
mainnet_e81889 - altair processJustificationAndFinalization 14.167 us/op 18.340 us/op 0.77
mainnet_e81889 - altair processInactivityUpdates 5.0043 ms/op 6.4053 ms/op 0.78
mainnet_e81889 - altair processRewardsAndPenalties 43.984 ms/op 47.929 ms/op 0.92
mainnet_e81889 - altair processRegistryUpdates 2.3720 us/op 3.8570 us/op 0.61
mainnet_e81889 - altair processSlashings 402.00 ns/op 876.00 ns/op 0.46
mainnet_e81889 - altair processEth1DataReset 460.00 ns/op 626.00 ns/op 0.73
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3533 ms/op 2.4535 ms/op 0.55
mainnet_e81889 - altair processSlashingsReset 3.4600 us/op 6.8650 us/op 0.50
mainnet_e81889 - altair processRandaoMixesReset 5.0320 us/op 7.4900 us/op 0.67
mainnet_e81889 - altair processHistoricalRootsUpdate 703.00 ns/op 708.00 ns/op 0.99
mainnet_e81889 - altair processParticipationFlagUpdates 2.0470 us/op 2.6960 us/op 0.76
mainnet_e81889 - altair processSyncCommitteeUpdates 636.00 ns/op 761.00 ns/op 0.84
mainnet_e81889 - altair afterProcessEpoch 50.795 ms/op 54.237 ms/op 0.94
capella processEpoch - mainnet_e217614 975.70 ms/op 1.1883 s/op 0.82
mainnet_e217614 - capella beforeProcessEpoch 71.220 ms/op 76.392 ms/op 0.93
mainnet_e217614 - capella processJustificationAndFinalization 13.452 us/op 19.955 us/op 0.67
mainnet_e217614 - capella processInactivityUpdates 16.589 ms/op 19.578 ms/op 0.85
mainnet_e217614 - capella processRewardsAndPenalties 211.91 ms/op 276.59 ms/op 0.77
mainnet_e217614 - capella processRegistryUpdates 19.760 us/op 20.706 us/op 0.95
mainnet_e217614 - capella processSlashings 517.00 ns/op 755.00 ns/op 0.68
mainnet_e217614 - capella processEth1DataReset 597.00 ns/op 876.00 ns/op 0.68
mainnet_e217614 - capella processEffectiveBalanceUpdates 14.250 ms/op 20.726 ms/op 0.69
mainnet_e217614 - capella processSlashingsReset 3.2110 us/op 5.2000 us/op 0.62
mainnet_e217614 - capella processRandaoMixesReset 4.8630 us/op 8.7320 us/op 0.56
mainnet_e217614 - capella processHistoricalRootsUpdate 639.00 ns/op 509.00 ns/op 1.26
mainnet_e217614 - capella processParticipationFlagUpdates 1.9380 us/op 3.1100 us/op 0.62
mainnet_e217614 - capella afterProcessEpoch 126.14 ms/op 132.32 ms/op 0.95
phase0 processEpoch - mainnet_e58758 334.02 ms/op 390.30 ms/op 0.86
mainnet_e58758 - phase0 beforeProcessEpoch 71.176 ms/op 110.48 ms/op 0.64
mainnet_e58758 - phase0 processJustificationAndFinalization 12.024 us/op 25.928 us/op 0.46
mainnet_e58758 - phase0 processRewardsAndPenalties 28.558 ms/op 37.087 ms/op 0.77
mainnet_e58758 - phase0 processRegistryUpdates 11.615 us/op 16.915 us/op 0.69
mainnet_e58758 - phase0 processSlashings 463.00 ns/op 727.00 ns/op 0.64
mainnet_e58758 - phase0 processEth1DataReset 380.00 ns/op 610.00 ns/op 0.62
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0816 ms/op 1.6752 ms/op 0.65
mainnet_e58758 - phase0 processSlashingsReset 2.3120 us/op 5.6650 us/op 0.41
mainnet_e58758 - phase0 processRandaoMixesReset 4.1540 us/op 9.3200 us/op 0.45
mainnet_e58758 - phase0 processHistoricalRootsUpdate 413.00 ns/op 1.1290 us/op 0.37
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.3190 us/op 6.4330 us/op 0.52
mainnet_e58758 - phase0 afterProcessEpoch 41.208 ms/op 49.170 ms/op 0.84
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3439 ms/op 1.7809 ms/op 0.75
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.7853 ms/op 4.1652 ms/op 0.43
altair processInactivityUpdates - 250000 normalcase 13.596 ms/op 20.619 ms/op 0.66
altair processInactivityUpdates - 250000 worstcase 13.862 ms/op 20.707 ms/op 0.67
phase0 processRegistryUpdates - 250000 normalcase 8.9960 us/op 10.057 us/op 0.89
phase0 processRegistryUpdates - 250000 badcase_full_deposits 260.76 us/op 328.72 us/op 0.79
phase0 processRegistryUpdates - 250000 worstcase 0.5 101.51 ms/op 128.64 ms/op 0.79
altair processRewardsAndPenalties - 250000 normalcase 38.602 ms/op 43.187 ms/op 0.89
altair processRewardsAndPenalties - 250000 worstcase 37.426 ms/op 43.427 ms/op 0.86
phase0 getAttestationDeltas - 250000 normalcase 7.1695 ms/op 9.3477 ms/op 0.77
phase0 getAttestationDeltas - 250000 worstcase 7.0505 ms/op 8.1400 ms/op 0.87
phase0 processSlashings - 250000 worstcase 78.333 us/op 110.60 us/op 0.71
altair processSyncCommitteeUpdates - 250000 128.27 ms/op 137.99 ms/op 0.93
BeaconState.hashTreeRoot - No change 243.00 ns/op 246.00 ns/op 0.99
BeaconState.hashTreeRoot - 1 full validator 116.64 us/op 142.94 us/op 0.82
BeaconState.hashTreeRoot - 32 full validator 1.1939 ms/op 969.89 us/op 1.23
BeaconState.hashTreeRoot - 512 full validator 10.576 ms/op 11.539 ms/op 0.92
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 131.49 us/op 153.98 us/op 0.85
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.8516 ms/op 2.1332 ms/op 0.87
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 24.180 ms/op 30.753 ms/op 0.79
BeaconState.hashTreeRoot - 1 balances 123.88 us/op 142.05 us/op 0.87
BeaconState.hashTreeRoot - 32 balances 955.75 us/op 1.2810 ms/op 0.75
BeaconState.hashTreeRoot - 512 balances 7.8541 ms/op 9.7774 ms/op 0.80
BeaconState.hashTreeRoot - 250000 balances 163.20 ms/op 162.31 ms/op 1.01
aggregationBits - 2048 els - zipIndexesInBitList 23.826 us/op 25.895 us/op 0.92
byteArrayEquals 32 54.544 ns/op 54.945 ns/op 0.99
Buffer.compare 32 17.489 ns/op 17.958 ns/op 0.97
byteArrayEquals 1024 1.6228 us/op 1.6539 us/op 0.98
Buffer.compare 1024 26.928 ns/op 25.243 ns/op 1.07
byteArrayEquals 16384 25.792 us/op 25.893 us/op 1.00
Buffer.compare 16384 202.18 ns/op 204.61 ns/op 0.99
byteArrayEquals 123687377 196.25 ms/op 196.42 ms/op 1.00
Buffer.compare 123687377 12.619 ms/op 7.1633 ms/op 1.76
byteArrayEquals 32 - diff last byte 65.589 ns/op 53.607 ns/op 1.22
Buffer.compare 32 - diff last byte 24.988 ns/op 20.426 ns/op 1.22
byteArrayEquals 1024 - diff last byte 1.9399 us/op 1.6164 us/op 1.20
Buffer.compare 1024 - diff last byte 34.923 ns/op 27.440 ns/op 1.27
byteArrayEquals 16384 - diff last byte 32.658 us/op 25.964 us/op 1.26
Buffer.compare 16384 - diff last byte 279.80 ns/op 192.94 ns/op 1.45
byteArrayEquals 123687377 - diff last byte 266.35 ms/op 195.36 ms/op 1.36
Buffer.compare 123687377 - diff last byte 13.508 ms/op 6.5468 ms/op 2.06
byteArrayEquals 32 - random bytes 6.9440 ns/op 5.2710 ns/op 1.32
Buffer.compare 32 - random bytes 19.829 ns/op 17.594 ns/op 1.13
byteArrayEquals 1024 - random bytes 6.5390 ns/op 5.2450 ns/op 1.25
Buffer.compare 1024 - random bytes 20.182 ns/op 17.597 ns/op 1.15
byteArrayEquals 16384 - random bytes 6.5910 ns/op 5.2660 ns/op 1.25
Buffer.compare 16384 - random bytes 19.931 ns/op 17.573 ns/op 1.13
byteArrayEquals 123687377 - random bytes 8.4900 ns/op 6.5900 ns/op 1.29
Buffer.compare 123687377 - random bytes 22.400 ns/op 18.850 ns/op 1.19
regular array get 100000 times 42.990 us/op 36.896 us/op 1.17
wrappedArray get 100000 times 38.301 us/op 32.616 us/op 1.17
arrayWithProxy get 100000 times 17.771 ms/op 13.431 ms/op 1.32
ssz.Root.equals 53.532 ns/op 45.868 ns/op 1.17
byteArrayEquals 52.526 ns/op 45.243 ns/op 1.16
Buffer.compare 12.508 ns/op 10.361 ns/op 1.21
processSlot - 1 slots 19.147 us/op 14.231 us/op 1.35
processSlot - 32 slots 3.6001 ms/op 3.0744 ms/op 1.17
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 51.581 ms/op 40.294 ms/op 1.28
getCommitteeAssignments - req 1 vs - 250000 vc 2.6386 ms/op 2.2113 ms/op 1.19
getCommitteeAssignments - req 100 vs - 250000 vc 5.2841 ms/op 4.0760 ms/op 1.30
getCommitteeAssignments - req 1000 vs - 250000 vc 5.3410 ms/op 4.3776 ms/op 1.22
findModifiedValidators - 10000 modified validators 555.57 ms/op 246.06 ms/op 2.26
findModifiedValidators - 1000 modified validators 333.34 ms/op 171.43 ms/op 1.94
findModifiedValidators - 100 modified validators 308.57 ms/op 191.80 ms/op 1.61
findModifiedValidators - 10 modified validators 292.63 ms/op 159.91 ms/op 1.83
findModifiedValidators - 1 modified validators 307.39 ms/op 140.82 ms/op 2.18
findModifiedValidators - no difference 303.99 ms/op 154.88 ms/op 1.96
compare ViewDUs 4.3292 s/op 3.1890 s/op 1.36
compare each validator Uint8Array 1.9284 s/op 1.5326 s/op 1.26
compare ViewDU to Uint8Array 1.4773 s/op 1.1445 s/op 1.29
migrate state 1000000 validators, 24 modified, 0 new 1.1034 s/op 730.09 ms/op 1.51
migrate state 1000000 validators, 1700 modified, 1000 new 1.3642 s/op 993.11 ms/op 1.37
migrate state 1000000 validators, 3400 modified, 2000 new 1.6120 s/op 1.2193 s/op 1.32
migrate state 1500000 validators, 24 modified, 0 new 1.0303 s/op 759.91 ms/op 1.36
migrate state 1500000 validators, 1700 modified, 1000 new 1.3137 s/op 999.77 ms/op 1.31
migrate state 1500000 validators, 3400 modified, 2000 new 1.5631 s/op 1.1905 s/op 1.31
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.4700 ns/op 4.5500 ns/op 1.20
state getBlockRootAtSlot - 250000 vs - 7PWei 598.53 ns/op 867.52 ns/op 0.69
computeProposers - vc 250000 7.8184 ms/op 7.8388 ms/op 1.00
computeEpochShuffling - vc 250000 47.901 ms/op 41.657 ms/op 1.15
getNextSyncCommittee - vc 250000 158.44 ms/op 116.40 ms/op 1.36
computeSigningRoot for AttestationData 30.971 us/op 21.563 us/op 1.44
hash AttestationData serialized data then Buffer.toString(base64) 1.8354 us/op 1.5908 us/op 1.15
toHexString serialized data 1.1150 us/op 898.84 ns/op 1.24
Buffer.toString(base64) 228.01 ns/op 177.97 ns/op 1.28
nodejs block root to RootHex using toHex 184.57 ns/op 195.00 ns/op 0.95
nodejs block root to RootHex using toRootHex 108.37 ns/op 106.94 ns/op 1.01
browser block root to RootHex using the deprecated toHexString 382.98 ns/op 242.00 ns/op 1.58
browser block root to RootHex using toHex 283.52 ns/op 188.93 ns/op 1.50
browser block root to RootHex using toRootHex 228.25 ns/op 167.94 ns/op 1.36

by benchmarkbot/action

@wemeetagain wemeetagain merged commit d25018a into unstable Dec 20, 2024
19 of 20 checks passed
@wemeetagain wemeetagain deleted the nflaig/unpin-node branch December 20, 2024 15:10
wemeetagain added a commit that referenced this pull request Dec 20, 2024
@wemeetagain @nflaig
@nazarhussain @g11tech @matthewkeil @ensi321 @twoeths @philknows @dependabot @acolytec3 @varunguleriaCodes @ClockworkYuzu
chore: release v1.24.0 (#7325)
11f35a8 
* feat: add keymanager endpoint to retrieve proposer config (#7210)

* feat: add keymanager endpoint to retrieve proposer config

* Do not return empty builder config

* Check all builder proposer config values

* Fix settings builder config if undefined

* Fix builder config parsing

* Use ssz type to handle json serialization

Default parsing can't handle BigInt

* Revert "Use ssz type to handle json serialization"

This reverts commit 01fcea7.

* Fix boost factor json serialization

* Remove unused import

* Update test data

* Update proposer config test

* feat: add mekong network option (#7212)

* chore: fix import order with biome syntax (#7211)

Fix import order

* fix: consistently validate pubkey and throw 404 if not found (#7214)

* Throw error if pubkey is unknown when getting graffiti

* Consistently validate pubkey and throw 404 if not found

* fix: only return local keys from /eth/v1/keystores (#7215)

* fix: only return local keys from /eth/v1/keystores

* Fix fetching remote keys in node assertion

* feat: add and use getBlobsV1 to expedite gossip import (#7134)

* hookup the getblobs api to get bob and proof data from el

remove unused

fix import

metrics overhault, test, debugging testing, some feeback

fix

add nethermind bug dicussion link

fix

resolve conflicts

* deblobs timeout

* fix metric

* chore: revert async aggregate with randomness (#7218)

Revert "feat: asyncAggregateWithRandomness (#7204)"

This reverts commit e31d535.

* fix: update config for relaunched mekong network (#7220)

* fix: light client generating `LightClientUpdate` with wrong length of branches (#7187)

* initial commit

* Rewrite SyncCommitteeWitnessRepository

* Fix finality branch

* Update unit test

* fix e2e

* Review PR

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* fix: archive finalized state when shutting down beacon node (#7221)

* Fix typo

* feat: remove unfinalized pubkey cache (#7230)

* Remove unfinalized pubkey cache

* lint

* Fix unit test

* chore: skip web3_provider unit tests (#7252)

* fix: prune checkpoint states at syncing time (#7241)

* fix: prune checkpoint states at syncing time

* fix: lint

* fix: check-types in test

* fix: sync cached isCompoundingValidatorArr at epoch transition (#7247)

* fix: handle outOfRangeData when range sync Deneb (#7249)

* fix: handle outOfRangeData for beaconBlocksMaybeBlobsByRange()

* fix: lint

* fix: archiveBlocks - handle deneb outOfRangeData block

* fix: sync cached balance when adding new validator to registry (#7255)

* fix: sync cached balance when adding new validator to registry

* chore: add more comments

* fix: remove persisted checkpoint states from the previous run at startup

* fix: do not throw error when trying to prune missing directory (#7257)

* docs: update documentation Oct 2024 (#7178)

* docs update oct 2024 init

* Reconfig quickstart nav and minor fixes

* fix lint

* spelling fixes

* minor fixes and add to wordlist

* prettier fix

* add to wordlist

* sort wordlist

* modify dominance to include lighthouse

* fix typescript casing and add recommendation

* add selection and boost_factor with keymanager notice

* update wordlist

* remove builder enabled and add keymanager api

* spelling

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (#7268)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add error log to notifier if execution client auth failed (#7239)

* feat: add error log to notifier if execution client auth failed

* Update packages/beacon-node/src/node/notifier.ts

---------

Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>

* docs: display rcConfig flag on CLI reference page (#7270)

* docs: display rcConfig flag on CLI reference page

* Update word list

* chore: remove prettier as default formatter for all file types (#7275)

* chore: unhide flags relevant for devnets / testing (#7271)

* feat: debug too many shuffling promises (#7251)

* feat: add asyncShufflingCalculation to StateTransitionOpts

* feat: add asyncShufflingCalculation to all regen / processSlots consumers

* fix: default to false for async shuffling and remove unnecessary props

* fix: remove unnecessary flags from stateTransition

* feat: implement conditional build of shuffling for prepareNextSlot

* fix: spec test bug where shufflingCache is present from BeaconChain constructor

* feat: sync build next shuffling if not queued async

* fix: use getSync to pull next shuffling correctly

* docs: add comment to prepareNextSlot

* refactor: rename StateCloneOpts to StateRegenerationOpts

* feat: pass asyncShufflingCalculation through to afterProcessEpoch and refactor conditional to run purely sync

* docs: add issue number to comment

* chore: lint

* chore: unpin nodejs version from 22.4 (#6982)

* Revert "chore: pin nodejs version to 22.4 (#6964)"

This reverts commit f20484b.

* Don't revert formatting changes

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Cayman <caymannava@gmail.com>

* chore: update bootnodes file url for holesky and sepolia (#7276)

* feat: add `debug_getHistoricalSummaries` endpoint (#7245)

* feat: add new getHistoricalSummaries endpoint to debug namespace

* Add JSON response

* Restructure to use stateId and add proof to response

* add test scaffolding

* Address feedback

* Move getHistoricalSummaries to lodestar namespace

* add lodestar namespace unit test

* update route name to lodestar namespace

* cast state object as Capella state

* Lint

* json properties need to be lower case

* Make it v1 since it's now part of lodestar namespace

* Group with other /lodestar endpoints

* Simplify beacon node impl

* Rename return type

* Update test description

* Fix variable name

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore: log sync committee signature errors as `error` (#7283)

* fix: update engine_getClientVersionV1 commit encoding (#7282)

* fix: check pubkey or validator index known to a state (#7284)

* fix: check pubkey or validator index known to a state

* chore: add more comments

* feat: lodestar script setup (#7254)

* feat: lodestar_setup

* feat: script_updates + docs

* feat: script_addition_in_docs + command_update

* Remove duplicate script from docs folder

* Minor script updates

* Update script to prepare docs and ignore copied file

* Update installation page

* Wording

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* feat: add terminal-sized Electra giraffe banner (#7286)

* Create giraffeBanners.ts

* Wire in banner

* Fix file name

* lint

* Address @nflaig's comment

---------

Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>

* chore: pin nodejs version to 22.4 (#7291)

Revert "chore: unpin nodejs version from 22.4 (#6982)"

This reverts commit 69ae688.

* feat: expose `DOMAIN_APPLICATION_MASK` in config/spec api (#7296)

* feat: expose DOMAIN_APPLICATION_MASK in config/spec api

* Lint

* feat: make `MAX_REQUEST_BLOB_SIDECARS` and `MAX_BLOBS_PER_BLOCK` configurable (#7294)

* Init commit

* Fix check-types

* Add comment on how MAX_REQUEST_BLOB_SIDECARS is calculated

* Ensure proper config object is passed

* Address comment

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* feat: use `BLOB_SIDECAR_SUBNET_COUNT` to configure blob subnets (#7297)

feat: use BLOB_SIDECAR_SUBNET_COUNT to configure blob subnets

* chore: log sync aggregate participants when producing beacon block body (#7300)

* chore: log sync aggregate participants when producing beacon block body

* Use isForkLightClient instead of ForkSeq

* Fix produce block unit tests

* chore: print graffiti when producing beacon block body (#7303)

* fix: warn if engine / builder failed to produce block within cutoff time (#7305)

* feat: add kzg commitment length check when validating gossip blocks (#7302)

* feat: add blob sidecar index check (#7313)

Validate blobSidecar index

* fix: fix blob sidecar index check (#7315)

Fix index check

* chore: fix format of printed graffiti from hex to utf-8 (#7306)

* chore: fix format of printed graffiti from hex to utf-8

* Use Buffer.from no copy with offset

* docs: batch commit typos and update contributor readme (#7312)

* batch commit typos and update contributor readme

* update donation text

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* correct spelling

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore: remove trailing null bytes from printed graffiti (#7320)

* chore: remove trailing null bytes from printed graffiti

* Use replaceAll instead of regex

* chore: unpin nodejs version from 22.4 (#7324)

Revert "chore: pin nodejs version to 22.4 (#7291)"

This reverts commit 99794d3.

* chore: bump package versions to 1.24.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>
Co-authored-by: g11tech <develop@g11tech.io>
Co-authored-by: Matthew Keil <me@matthewkeil.com>
Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>
Co-authored-by: twoeths <tuyen@chainsafe.io>
Co-authored-by: Phil Ngo <58080811+philknows@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: Varun Guleria <152203177+varunguleriaCodes@users.noreply.github.com>
Co-authored-by: ClockworkYuzu <yvetteheh@gmail.com>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.24.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain