Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consistently validate pubkey and throw 404 if not found #7214

Merged
merged 2 commits into from
Nov 3, 2024
Merged

fix: consistently validate pubkey and throw 404 if not found #7214

merged 2 commits into from
Nov 3, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Nov 1, 2024

Motivation

See #7213

Description

Consistently validate pubkey and throw 404 if not found in keymanager api implementation before querying validator store.

@nflaig nflaig requested a review from a team as a code owner November 1, 2024 17:24
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.38%. Comparing base (06b4c2d) to head (1b95445).
Report is 1 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7214   +/-   ##
=========================================
  Coverage     49.38%   49.38%           
=========================================
  Files           599      599           
  Lines         39956    39960    +4     
  Branches       2097     2108   +11     
=========================================
+ Hits          19733    19736    +3     
- Misses        20185    20186    +1     
  Partials         38       38

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: 354750d Previous: 06b4c2d Ratio
getSlashingsAndExits - default max 71.787 us/op 215.80 us/op 0.33
Full benchmark results
Benchmark suite Current: 354750d Previous: 06b4c2d Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.0218 ms/op 2.2642 ms/op 0.89
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 41.943 us/op 69.775 us/op 0.60
BLS verify - blst 906.69 us/op 1.0233 ms/op 0.89
BLS verifyMultipleSignatures 3 - blst 1.5396 ms/op 1.5842 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst 2.1656 ms/op 2.5115 ms/op 0.86
BLS verifyMultipleSignatures 32 - blst 4.7010 ms/op 6.5633 ms/op 0.72
BLS verifyMultipleSignatures 64 - blst 8.5508 ms/op 11.133 ms/op 0.77
BLS verifyMultipleSignatures 128 - blst 16.241 ms/op 20.299 ms/op 0.80
BLS deserializing 10000 signatures 628.71 ms/op 752.85 ms/op 0.84
BLS deserializing 100000 signatures 6.5687 s/op 7.2695 s/op 0.90
BLS verifyMultipleSignatures - same message - 3 - blst 953.14 us/op 935.86 us/op 1.02
BLS verifyMultipleSignatures - same message - 8 - blst 1.1664 ms/op 1.0577 ms/op 1.10
BLS verifyMultipleSignatures - same message - 32 - blst 1.6273 ms/op 1.8107 ms/op 0.90
BLS verifyMultipleSignatures - same message - 64 - blst 2.4286 ms/op 2.7299 ms/op 0.89
BLS verifyMultipleSignatures - same message - 128 - blst 4.1157 ms/op 4.7750 ms/op 0.86
BLS aggregatePubkeys 32 - blst 17.779 us/op 21.806 us/op 0.82
BLS aggregatePubkeys 128 - blst 61.469 us/op 77.726 us/op 0.79
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 61.442 ms/op 79.474 ms/op 0.77
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 49.947 ms/op 68.149 ms/op 0.73
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 36.948 ms/op 54.022 ms/op 0.68
getSlashingsAndExits - default max 71.787 us/op 215.80 us/op 0.33
getSlashingsAndExits - 2k 254.38 us/op 500.51 us/op 0.51
proposeBlockBody type=full, size=empty 5.2239 ms/op 8.3371 ms/op 0.63
isKnown best case - 1 super set check 477.00 ns/op 705.00 ns/op 0.68
isKnown normal case - 2 super set checks 454.00 ns/op 741.00 ns/op 0.61
isKnown worse case - 16 super set checks 453.00 ns/op 734.00 ns/op 0.62
InMemoryCheckpointStateCache - add get delete 2.7330 us/op 5.1650 us/op 0.53
updateUnfinalizedPubkeys - updating 10 pubkeys 1.1737 ms/op 1.6693 ms/op 0.70
updateUnfinalizedPubkeys - updating 100 pubkeys 3.3216 ms/op 6.3416 ms/op 0.52
updateUnfinalizedPubkeys - updating 1000 pubkeys 41.931 ms/op 84.247 ms/op 0.50
validate api signedAggregateAndProof - struct 1.5696 ms/op 1.9358 ms/op 0.81
validate gossip signedAggregateAndProof - struct 1.6082 ms/op 1.8343 ms/op 0.88
batch validate gossip attestation - vc 640000 - chunk 32 127.16 us/op 159.07 us/op 0.80
batch validate gossip attestation - vc 640000 - chunk 64 118.36 us/op 134.14 us/op 0.88
batch validate gossip attestation - vc 640000 - chunk 128 107.24 us/op 119.56 us/op 0.90
batch validate gossip attestation - vc 640000 - chunk 256 104.20 us/op 108.45 us/op 0.96
pickEth1Vote - no votes 905.75 us/op 1.0872 ms/op 0.83
pickEth1Vote - max votes 4.5341 ms/op 6.8299 ms/op 0.66
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.9889 ms/op 14.225 ms/op 0.70
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.379 ms/op 17.707 ms/op 0.87
pickEth1Vote - Eth1Data fastSerialize value x2048 385.27 us/op 489.10 us/op 0.79
pickEth1Vote - Eth1Data fastSerialize tree x2048 2.0737 ms/op 2.9889 ms/op 0.69
bytes32 toHexString 631.00 ns/op 489.00 ns/op 1.29
bytes32 Buffer.toString(hex) 477.00 ns/op 284.00 ns/op 1.68
bytes32 Buffer.toString(hex) from Uint8Array 661.00 ns/op 470.00 ns/op 1.41
bytes32 Buffer.toString(hex) + 0x 489.00 ns/op 288.00 ns/op 1.70
Object access 1 prop 0.35900 ns/op 0.20000 ns/op 1.79
Map access 1 prop 0.33100 ns/op 0.14100 ns/op 2.35
Object get x1000 5.3480 ns/op 6.2420 ns/op 0.86
Map get x1000 6.1400 ns/op 6.5660 ns/op 0.94
Object set x1000 27.859 ns/op 42.821 ns/op 0.65
Map set x1000 20.034 ns/op 30.148 ns/op 0.66
Return object 10000 times 0.30890 ns/op 0.31060 ns/op 0.99
Throw Error 10000 times 2.8093 us/op 3.6302 us/op 0.77
toHex 116.03 ns/op 178.57 ns/op 0.65
Buffer.from 109.19 ns/op 158.32 ns/op 0.69
shared Buffer 74.515 ns/op 99.318 ns/op 0.75
fastMsgIdFn sha256 / 200 bytes 2.0860 us/op 2.3800 us/op 0.88
fastMsgIdFn h32 xxhash / 200 bytes 481.00 ns/op 292.00 ns/op 1.65
fastMsgIdFn h64 xxhash / 200 bytes 470.00 ns/op 283.00 ns/op 1.66
fastMsgIdFn sha256 / 1000 bytes 6.2090 us/op 7.8470 us/op 0.79
fastMsgIdFn h32 xxhash / 1000 bytes 616.00 ns/op 404.00 ns/op 1.52
fastMsgIdFn h64 xxhash / 1000 bytes 548.00 ns/op 360.00 ns/op 1.52
fastMsgIdFn sha256 / 10000 bytes 50.619 us/op 66.916 us/op 0.76
fastMsgIdFn h32 xxhash / 10000 bytes 2.0350 us/op 1.8780 us/op 1.08
fastMsgIdFn h64 xxhash / 10000 bytes 1.3920 us/op 1.2410 us/op 1.12
send data - 1000 256B messages 11.919 ms/op 13.163 ms/op 0.91
send data - 1000 512B messages 16.101 ms/op 17.538 ms/op 0.92
send data - 1000 1024B messages 23.181 ms/op 27.848 ms/op 0.83
send data - 1000 1200B messages 26.421 ms/op 28.765 ms/op 0.92
send data - 1000 2048B messages 30.814 ms/op 34.714 ms/op 0.89
send data - 1000 4096B messages 26.228 ms/op 33.672 ms/op 0.78
send data - 1000 16384B messages 64.028 ms/op 75.829 ms/op 0.84
send data - 1000 65536B messages 261.63 ms/op 226.25 ms/op 1.16
enrSubnets - fastDeserialize 64 bits 1.1410 us/op 1.2320 us/op 0.93
enrSubnets - ssz BitVector 64 bits 538.00 ns/op 416.00 ns/op 1.29
enrSubnets - fastDeserialize 4 bits 339.00 ns/op 178.00 ns/op 1.90
enrSubnets - ssz BitVector 4 bits 558.00 ns/op 439.00 ns/op 1.27
prioritizePeers score -10:0 att 32-0.1 sync 2-0 124.23 us/op 171.78 us/op 0.72
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 127.27 us/op 174.10 us/op 0.73
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 254.10 us/op 271.11 us/op 0.94
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 419.29 us/op 488.27 us/op 0.86
prioritizePeers score 0:0 att 64-1 sync 4-1 456.39 us/op 663.24 us/op 0.69
array of 16000 items push then shift 1.3456 us/op 1.6774 us/op 0.80
LinkedList of 16000 items push then shift 6.5530 ns/op 7.9920 ns/op 0.82
array of 16000 items push then pop 95.913 ns/op 128.96 ns/op 0.74
LinkedList of 16000 items push then pop 6.3730 ns/op 7.7530 ns/op 0.82
array of 24000 items push then shift 1.9476 us/op 2.4967 us/op 0.78
LinkedList of 24000 items push then shift 6.5200 ns/op 8.6550 ns/op 0.75
array of 24000 items push then pop 112.82 ns/op 174.31 ns/op 0.65
LinkedList of 24000 items push then pop 6.3380 ns/op 8.6110 ns/op 0.74
intersect bitArray bitLen 8 6.6950 ns/op 7.1120 ns/op 0.94
intersect array and set length 8 39.774 ns/op 57.282 ns/op 0.69
intersect bitArray bitLen 128 28.648 ns/op 31.722 ns/op 0.90
intersect array and set length 128 590.00 ns/op 848.98 ns/op 0.69
bitArray.getTrueBitIndexes() bitLen 128 1.8320 us/op 1.6110 us/op 1.14
bitArray.getTrueBitIndexes() bitLen 248 3.0360 us/op 2.8010 us/op 1.08
bitArray.getTrueBitIndexes() bitLen 512 6.5980 us/op 6.1080 us/op 1.08
Buffer.concat 32 items 1.0280 us/op 1.0810 us/op 0.95
Uint8Array.set 32 items 1.7450 us/op 2.2080 us/op 0.79
Buffer.copy 1.8160 us/op 2.4250 us/op 0.75
Uint8Array.set - with subarray 2.4490 us/op 3.3440 us/op 0.73
Uint8Array.set - without subarray 1.6550 us/op 1.6840 us/op 0.98
getUint32 - dataview 492.00 ns/op 298.00 ns/op 1.65
getUint32 - manual 456.00 ns/op 233.00 ns/op 1.96
Set add up to 64 items then delete first 1.8928 us/op 2.5983 us/op 0.73
OrderedSet add up to 64 items then delete first 3.0262 us/op 3.9284 us/op 0.77
Set add up to 64 items then delete last 2.2614 us/op 3.1416 us/op 0.72
OrderedSet add up to 64 items then delete last 3.4393 us/op 4.8114 us/op 0.71
Set add up to 64 items then delete middle 2.1333 us/op 3.1527 us/op 0.68
OrderedSet add up to 64 items then delete middle 5.0897 us/op 5.7934 us/op 0.88
Set add up to 128 items then delete first 4.0573 us/op 6.4026 us/op 0.63
OrderedSet add up to 128 items then delete first 6.2982 us/op 9.7599 us/op 0.65
Set add up to 128 items then delete last 4.2156 us/op 6.2224 us/op 0.68
OrderedSet add up to 128 items then delete last 6.4274 us/op 9.1490 us/op 0.70
Set add up to 128 items then delete middle 4.0377 us/op 6.0866 us/op 0.66
OrderedSet add up to 128 items then delete middle 11.772 us/op 16.456 us/op 0.72
Set add up to 256 items then delete first 7.8951 us/op 12.862 us/op 0.61
OrderedSet add up to 256 items then delete first 12.030 us/op 20.081 us/op 0.60
Set add up to 256 items then delete last 7.9483 us/op 11.574 us/op 0.69
OrderedSet add up to 256 items then delete last 12.472 us/op 17.467 us/op 0.71
Set add up to 256 items then delete middle 7.9162 us/op 11.422 us/op 0.69
OrderedSet add up to 256 items then delete middle 35.581 us/op 46.571 us/op 0.76
transfer serialized Status (84 B) 1.4660 us/op 1.6230 us/op 0.90
copy serialized Status (84 B) 1.3350 us/op 1.3300 us/op 1.00
transfer serialized SignedVoluntaryExit (112 B) 1.5630 us/op 1.7150 us/op 0.91
copy serialized SignedVoluntaryExit (112 B) 1.3790 us/op 1.4230 us/op 0.97
transfer serialized ProposerSlashing (416 B) 2.0930 us/op 2.1350 us/op 0.98
copy serialized ProposerSlashing (416 B) 2.1470 us/op 2.5770 us/op 0.83
transfer serialized Attestation (485 B) 1.8780 us/op 2.4090 us/op 0.78
copy serialized Attestation (485 B) 2.0230 us/op 2.6450 us/op 0.76
transfer serialized AttesterSlashing (33232 B) 2.4260 us/op 2.7110 us/op 0.89
copy serialized AttesterSlashing (33232 B) 5.5480 us/op 8.0310 us/op 0.69
transfer serialized Small SignedBeaconBlock (128000 B) 2.7930 us/op 2.5170 us/op 1.11
copy serialized Small SignedBeaconBlock (128000 B) 14.184 us/op 15.688 us/op 0.90
transfer serialized Avg SignedBeaconBlock (200000 B) 2.7510 us/op 3.0360 us/op 0.91
copy serialized Avg SignedBeaconBlock (200000 B) 20.866 us/op 22.966 us/op 0.91
transfer serialized BlobsSidecar (524380 B) 2.7360 us/op 3.5780 us/op 0.76
copy serialized BlobsSidecar (524380 B) 75.204 us/op 75.650 us/op 0.99
transfer serialized Big SignedBeaconBlock (1000000 B) 2.7280 us/op 4.2210 us/op 0.65
copy serialized Big SignedBeaconBlock (1000000 B) 141.76 us/op 171.55 us/op 0.83
pass gossip attestations to forkchoice per slot 2.4087 ms/op 3.0034 ms/op 0.80
forkChoice updateHead vc 100000 bc 64 eq 0 353.38 us/op 480.74 us/op 0.74
forkChoice updateHead vc 600000 bc 64 eq 0 2.4588 ms/op 3.8343 ms/op 0.64
forkChoice updateHead vc 1000000 bc 64 eq 0 4.0571 ms/op 5.1756 ms/op 0.78
forkChoice updateHead vc 600000 bc 320 eq 0 2.1633 ms/op 3.0472 ms/op 0.71
forkChoice updateHead vc 600000 bc 1200 eq 0 2.3179 ms/op 2.9577 ms/op 0.78
forkChoice updateHead vc 600000 bc 7200 eq 0 2.8525 ms/op 5.6023 ms/op 0.51
forkChoice updateHead vc 600000 bc 64 eq 1000 9.1535 ms/op 10.512 ms/op 0.87
forkChoice updateHead vc 600000 bc 64 eq 10000 9.1130 ms/op 10.411 ms/op 0.88
forkChoice updateHead vc 600000 bc 64 eq 300000 11.188 ms/op 14.587 ms/op 0.77
computeDeltas 500000 validators 300 proto nodes 3.2492 ms/op 4.2527 ms/op 0.76
computeDeltas 500000 validators 1200 proto nodes 3.2931 ms/op 4.2477 ms/op 0.78
computeDeltas 500000 validators 7200 proto nodes 3.3392 ms/op 4.2624 ms/op 0.78
computeDeltas 750000 validators 300 proto nodes 4.9665 ms/op 6.1556 ms/op 0.81
computeDeltas 750000 validators 1200 proto nodes 5.0416 ms/op 6.1428 ms/op 0.82
computeDeltas 750000 validators 7200 proto nodes 5.2683 ms/op 6.2998 ms/op 0.84
computeDeltas 1400000 validators 300 proto nodes 9.5039 ms/op 11.790 ms/op 0.81
computeDeltas 1400000 validators 1200 proto nodes 9.3622 ms/op 11.638 ms/op 0.80
computeDeltas 1400000 validators 7200 proto nodes 9.3085 ms/op 11.521 ms/op 0.81
computeDeltas 2100000 validators 300 proto nodes 15.395 ms/op 16.647 ms/op 0.92
computeDeltas 2100000 validators 1200 proto nodes 14.769 ms/op 16.560 ms/op 0.89
computeDeltas 2100000 validators 7200 proto nodes 14.645 ms/op 16.483 ms/op 0.89
altair processAttestation - 250000 vs - 7PWei normalcase 1.5638 ms/op 1.7019 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei worstcase 2.4482 ms/op 2.5084 ms/op 0.98
altair processAttestation - setStatus - 1/6 committees join 71.502 us/op 84.545 us/op 0.85
altair processAttestation - setStatus - 1/3 committees join 145.09 us/op 171.03 us/op 0.85
altair processAttestation - setStatus - 1/2 committees join 221.52 us/op 238.41 us/op 0.93
altair processAttestation - setStatus - 2/3 committees join 294.04 us/op 308.21 us/op 0.95
altair processAttestation - setStatus - 4/5 committees join 441.96 us/op 454.40 us/op 0.97
altair processAttestation - setStatus - 100% committees join 492.57 us/op 537.41 us/op 0.92
altair processBlock - 250000 vs - 7PWei normalcase 5.0062 ms/op 3.7211 ms/op 1.35
altair processBlock - 250000 vs - 7PWei normalcase hashState 27.572 ms/op 26.016 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase 37.300 ms/op 36.113 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase hashState 77.526 ms/op 65.995 ms/op 1.17
phase0 processBlock - 250000 vs - 7PWei normalcase 2.4974 ms/op 1.6803 ms/op 1.49
phase0 processBlock - 250000 vs - 7PWei worstcase 25.521 ms/op 19.411 ms/op 1.31
altair processEth1Data - 250000 vs - 7PWei normalcase 280.97 us/op 301.64 us/op 0.93
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 7.7620 us/op 4.6350 us/op 1.67
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 31.790 us/op 26.285 us/op 1.21
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 10.905 us/op 7.9790 us/op 1.37
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 7.5130 us/op 4.7920 us/op 1.57
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 131.27 us/op 111.10 us/op 1.18
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 881.90 us/op 1.0840 ms/op 0.81
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.3830 ms/op 1.4656 ms/op 0.94
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.1941 ms/op 1.5203 ms/op 0.79
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.9634 ms/op 3.6401 ms/op 0.81
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.2361 ms/op 1.4701 ms/op 0.84
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 2.9789 ms/op 3.4920 ms/op 0.85
Tree 40 250000 create 245.57 ms/op 224.07 ms/op 1.10
Tree 40 250000 get(125000) 121.97 ns/op 147.44 ns/op 0.83
Tree 40 250000 set(125000) 610.38 ns/op 605.79 ns/op 1.01
Tree 40 250000 toArray() 19.159 ms/op 14.249 ms/op 1.34
Tree 40 250000 iterate all - toArray() + loop 19.276 ms/op 14.330 ms/op 1.35
Tree 40 250000 iterate all - get(i) 50.802 ms/op 50.218 ms/op 1.01
Array 250000 create 3.6301 ms/op 2.7128 ms/op 1.34
Array 250000 clone - spread 1.3626 ms/op 1.3091 ms/op 1.04
Array 250000 get(125000) 0.59200 ns/op 0.40300 ns/op 1.47
Array 250000 set(125000) 0.59400 ns/op 0.41500 ns/op 1.43
Array 250000 iterate all - loop 76.201 us/op 101.67 us/op 0.75
phase0 afterProcessEpoch - 250000 vs - 7PWei 44.211 ms/op 49.259 ms/op 0.90
Array.fill - length 1000000 3.4767 ms/op 3.4132 ms/op 1.02
Array push - length 1000000 17.479 ms/op 12.149 ms/op 1.44
Array.get 0.26255 ns/op 0.26555 ns/op 0.99
Uint8Array.get 0.33750 ns/op 0.41810 ns/op 0.81
phase0 beforeProcessEpoch - 250000 vs - 7PWei 21.695 ms/op 17.489 ms/op 1.24
altair processEpoch - mainnet_e81889 295.71 ms/op 276.35 ms/op 1.07
mainnet_e81889 - altair beforeProcessEpoch 22.206 ms/op 17.980 ms/op 1.24
mainnet_e81889 - altair processJustificationAndFinalization 16.737 us/op 12.355 us/op 1.35
mainnet_e81889 - altair processInactivityUpdates 5.2822 ms/op 4.8404 ms/op 1.09
mainnet_e81889 - altair processRewardsAndPenalties 48.317 ms/op 40.039 ms/op 1.21
mainnet_e81889 - altair processRegistryUpdates 2.9290 us/op 1.7880 us/op 1.64
mainnet_e81889 - altair processSlashings 940.00 ns/op 405.00 ns/op 2.32
mainnet_e81889 - altair processEth1DataReset 967.00 ns/op 335.00 ns/op 2.89
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.0877 ms/op 1.8790 ms/op 0.58
mainnet_e81889 - altair processSlashingsReset 3.2120 us/op 2.5660 us/op 1.25
mainnet_e81889 - altair processRandaoMixesReset 3.1320 us/op 4.0640 us/op 0.77
mainnet_e81889 - altair processHistoricalRootsUpdate 882.00 ns/op 659.00 ns/op 1.34
mainnet_e81889 - altair processParticipationFlagUpdates 2.1600 us/op 1.7330 us/op 1.25
mainnet_e81889 - altair processSyncCommitteeUpdates 1.1010 us/op 427.00 ns/op 2.58
mainnet_e81889 - altair afterProcessEpoch 44.566 ms/op 50.772 ms/op 0.88
capella processEpoch - mainnet_e217614 1.1138 s/op 1.0135 s/op 1.10
mainnet_e217614 - capella beforeProcessEpoch 94.898 ms/op 82.383 ms/op 1.15
mainnet_e217614 - capella processJustificationAndFinalization 30.838 us/op 15.842 us/op 1.95
mainnet_e217614 - capella processInactivityUpdates 27.349 ms/op 17.543 ms/op 1.56
mainnet_e217614 - capella processRewardsAndPenalties 272.52 ms/op 223.33 ms/op 1.22
mainnet_e217614 - capella processRegistryUpdates 11.470 us/op 13.418 us/op 0.85
mainnet_e217614 - capella processSlashings 824.00 ns/op 452.00 ns/op 1.82
mainnet_e217614 - capella processEth1DataReset 811.00 ns/op 354.00 ns/op 2.29
mainnet_e217614 - capella processEffectiveBalanceUpdates 16.363 ms/op 14.621 ms/op 1.12
mainnet_e217614 - capella processSlashingsReset 2.3440 us/op 4.1750 us/op 0.56
mainnet_e217614 - capella processRandaoMixesReset 3.4850 us/op 4.7530 us/op 0.73
mainnet_e217614 - capella processHistoricalRootsUpdate 737.00 ns/op 964.00 ns/op 0.76
mainnet_e217614 - capella processParticipationFlagUpdates 4.2160 us/op 2.1010 us/op 2.01
mainnet_e217614 - capella afterProcessEpoch 101.29 ms/op 127.70 ms/op 0.79
phase0 processEpoch - mainnet_e58758 293.03 ms/op 326.50 ms/op 0.90
mainnet_e58758 - phase0 beforeProcessEpoch 86.184 ms/op 77.405 ms/op 1.11
mainnet_e58758 - phase0 processJustificationAndFinalization 14.496 us/op 16.775 us/op 0.86
mainnet_e58758 - phase0 processRewardsAndPenalties 34.230 ms/op 28.938 ms/op 1.18
mainnet_e58758 - phase0 processRegistryUpdates 4.0480 us/op 9.8060 us/op 0.41
mainnet_e58758 - phase0 processSlashings 756.00 ns/op 466.00 ns/op 1.62
mainnet_e58758 - phase0 processEth1DataReset 731.00 ns/op 366.00 ns/op 2.00
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 896.25 us/op 1.2291 ms/op 0.73
mainnet_e58758 - phase0 processSlashingsReset 3.7230 us/op 2.5480 us/op 1.46
mainnet_e58758 - phase0 processRandaoMixesReset 4.8620 us/op 3.7430 us/op 1.30
mainnet_e58758 - phase0 processHistoricalRootsUpdate 702.00 ns/op 376.00 ns/op 1.87
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.2680 us/op 3.1270 us/op 1.36
mainnet_e58758 - phase0 afterProcessEpoch 35.178 ms/op 43.937 ms/op 0.80
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.0924 ms/op 1.9365 ms/op 0.56
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.3649 ms/op 2.2963 ms/op 0.59
altair processInactivityUpdates - 250000 normalcase 16.154 ms/op 14.566 ms/op 1.11
altair processInactivityUpdates - 250000 worstcase 16.653 ms/op 16.141 ms/op 1.03
phase0 processRegistryUpdates - 250000 normalcase 5.6020 us/op 7.0250 us/op 0.80
phase0 processRegistryUpdates - 250000 badcase_full_deposits 294.42 us/op 312.36 us/op 0.94
phase0 processRegistryUpdates - 250000 worstcase 0.5 113.64 ms/op 127.93 ms/op 0.89
altair processRewardsAndPenalties - 250000 normalcase 49.437 ms/op 37.573 ms/op 1.32
altair processRewardsAndPenalties - 250000 worstcase 44.384 ms/op 35.955 ms/op 1.23
phase0 getAttestationDeltas - 250000 normalcase 6.0740 ms/op 7.7508 ms/op 0.78
phase0 getAttestationDeltas - 250000 worstcase 5.8882 ms/op 7.4666 ms/op 0.79
phase0 processSlashings - 250000 worstcase 90.453 us/op 89.296 us/op 1.01
altair processSyncCommitteeUpdates - 250000 94.997 ms/op 124.33 ms/op 0.76
BeaconState.hashTreeRoot - No change 456.00 ns/op 267.00 ns/op 1.71
BeaconState.hashTreeRoot - 1 full validator 71.433 us/op 93.586 us/op 0.76
BeaconState.hashTreeRoot - 32 full validator 718.46 us/op 1.1361 ms/op 0.63
BeaconState.hashTreeRoot - 512 full validator 7.9913 ms/op 10.097 ms/op 0.79
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 95.573 us/op 114.49 us/op 0.83
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.6104 ms/op 1.4589 ms/op 1.10
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 20.308 ms/op 20.835 ms/op 0.97
BeaconState.hashTreeRoot - 1 balances 92.813 us/op 93.184 us/op 1.00
BeaconState.hashTreeRoot - 32 balances 902.27 us/op 840.87 us/op 1.07
BeaconState.hashTreeRoot - 512 balances 6.6915 ms/op 7.6803 ms/op 0.87
BeaconState.hashTreeRoot - 250000 balances 124.40 ms/op 153.77 ms/op 0.81
aggregationBits - 2048 els - zipIndexesInBitList 20.109 us/op 26.247 us/op 0.77
byteArrayEquals 32 49.480 ns/op 54.540 ns/op 0.91
Buffer.compare 32 16.699 ns/op 17.373 ns/op 0.96
byteArrayEquals 1024 1.2950 us/op 1.6156 us/op 0.80
Buffer.compare 1024 24.987 ns/op 24.840 ns/op 1.01
byteArrayEquals 16384 20.770 us/op 25.658 us/op 0.81
Buffer.compare 16384 198.75 ns/op 194.48 ns/op 1.02
byteArrayEquals 123687377 149.80 ms/op 194.38 ms/op 0.77
Buffer.compare 123687377 3.6607 ms/op 7.5644 ms/op 0.48
byteArrayEquals 32 - diff last byte 46.893 ns/op 53.624 ns/op 0.87
Buffer.compare 32 - diff last byte 16.389 ns/op 17.465 ns/op 0.94
byteArrayEquals 1024 - diff last byte 1.2504 us/op 1.6308 us/op 0.77
Buffer.compare 1024 - diff last byte 24.463 ns/op 25.450 ns/op 0.96
byteArrayEquals 16384 - diff last byte 19.858 us/op 25.829 us/op 0.77
Buffer.compare 16384 - diff last byte 202.04 ns/op 202.71 ns/op 1.00
byteArrayEquals 123687377 - diff last byte 141.81 ms/op 189.78 ms/op 0.75
Buffer.compare 123687377 - diff last byte 5.2644 ms/op 6.1649 ms/op 0.85
byteArrayEquals 32 - random bytes 4.4160 ns/op 5.0800 ns/op 0.87
Buffer.compare 32 - random bytes 14.347 ns/op 17.132 ns/op 0.84
byteArrayEquals 1024 - random bytes 4.4200 ns/op 5.1070 ns/op 0.87
Buffer.compare 1024 - random bytes 14.058 ns/op 17.092 ns/op 0.82
byteArrayEquals 16384 - random bytes 4.4190 ns/op 5.0930 ns/op 0.87
Buffer.compare 16384 - random bytes 14.034 ns/op 17.412 ns/op 0.81
byteArrayEquals 123687377 - random bytes 6.9200 ns/op 6.4500 ns/op 1.07
Buffer.compare 123687377 - random bytes 16.540 ns/op 18.490 ns/op 0.89
regular array get 100000 times 27.263 us/op 34.731 us/op 0.78
wrappedArray get 100000 times 27.186 us/op 33.183 us/op 0.82
arrayWithProxy get 100000 times 8.8205 ms/op 13.341 ms/op 0.66
ssz.Root.equals 39.684 ns/op 45.720 ns/op 0.87
byteArrayEquals 38.488 ns/op 45.116 ns/op 0.85
Buffer.compare 8.1330 ns/op 10.330 ns/op 0.79
processSlot - 1 slots 18.303 us/op 11.679 us/op 1.57
processSlot - 32 slots 2.9119 ms/op 2.1561 ms/op 1.35
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 42.956 ms/op 36.599 ms/op 1.17
getCommitteeAssignments - req 1 vs - 250000 vc 1.8116 ms/op 2.1613 ms/op 0.84
getCommitteeAssignments - req 100 vs - 250000 vc 3.5491 ms/op 4.2952 ms/op 0.83
getCommitteeAssignments - req 1000 vs - 250000 vc 3.7565 ms/op 4.4900 ms/op 0.84
findModifiedValidators - 10000 modified validators 242.16 ms/op 258.03 ms/op 0.94
findModifiedValidators - 1000 modified validators 144.91 ms/op 176.68 ms/op 0.82
findModifiedValidators - 100 modified validators 137.06 ms/op 160.38 ms/op 0.85
findModifiedValidators - 10 modified validators 130.18 ms/op 152.13 ms/op 0.86
findModifiedValidators - 1 modified validators 117.33 ms/op 153.14 ms/op 0.77
findModifiedValidators - no difference 145.25 ms/op 167.39 ms/op 0.87
compare ViewDUs 2.9895 s/op 3.3091 s/op 0.90
compare each validator Uint8Array 1.5108 s/op 1.4704 s/op 1.03
compare ViewDU to Uint8Array 634.61 ms/op 1.2361 s/op 0.51
migrate state 1000000 validators, 24 modified, 0 new 692.54 ms/op 757.73 ms/op 0.91
migrate state 1000000 validators, 1700 modified, 1000 new 908.68 ms/op 923.05 ms/op 0.98
migrate state 1000000 validators, 3400 modified, 2000 new 1.0323 s/op 1.1167 s/op 0.92
migrate state 1500000 validators, 24 modified, 0 new 653.05 ms/op 750.72 ms/op 0.87
migrate state 1500000 validators, 1700 modified, 1000 new 913.45 ms/op 994.39 ms/op 0.92
migrate state 1500000 validators, 3400 modified, 2000 new 1.0924 s/op 1.1480 s/op 0.95
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.4800 ns/op 4.3200 ns/op 1.50
state getBlockRootAtSlot - 250000 vs - 7PWei 553.08 ns/op 449.20 ns/op 1.23
computeProposers - vc 250000 5.4205 ms/op 7.8054 ms/op 0.69
computeEpochShuffling - vc 250000 35.283 ms/op 42.055 ms/op 0.84
getNextSyncCommittee - vc 250000 94.471 ms/op 124.04 ms/op 0.76
computeSigningRoot for AttestationData 15.909 us/op 16.864 us/op 0.94
hash AttestationData serialized data then Buffer.toString(base64) 1.1508 us/op 1.5935 us/op 0.72
toHexString serialized data 718.29 ns/op 904.86 ns/op 0.79
Buffer.toString(base64) 136.44 ns/op 185.40 ns/op 0.74
nodejs block root to RootHex using toHex 107.65 ns/op 150.48 ns/op 0.72
nodejs block root to RootHex using toRootHex 77.604 ns/op 95.790 ns/op 0.81
browser block root to RootHex using the deprecated toHexString 211.30 ns/op 228.65 ns/op 0.92
browser block root to RootHex using toHex 166.28 ns/op 183.14 ns/op 0.91
browser block root to RootHex using toRootHex 150.78 ns/op 163.18 ns/op 0.92

by benchmarkbot/action

@nflaig nflaig merged commit 07d1145 into unstable Nov 3, 2024
20 checks passed
@nflaig nflaig deleted the nflaig/keymanager-fixes branch November 3, 2024 07:21
@nflaig nflaig mentioned this pull request Nov 3, 2024
Closed
wemeetagain added a commit that referenced this pull request Dec 20, 2024
@wemeetagain @nflaig
@nazarhussain @g11tech @matthewkeil @ensi321 @twoeths @philknows @dependabot @acolytec3 @varunguleriaCodes @ClockworkYuzu
chore: release v1.24.0 (#7325)
11f35a8 
* feat: add keymanager endpoint to retrieve proposer config (#7210)

* feat: add keymanager endpoint to retrieve proposer config

* Do not return empty builder config

* Check all builder proposer config values

* Fix settings builder config if undefined

* Fix builder config parsing

* Use ssz type to handle json serialization

Default parsing can't handle BigInt

* Revert "Use ssz type to handle json serialization"

This reverts commit 01fcea7.

* Fix boost factor json serialization

* Remove unused import

* Update test data

* Update proposer config test

* feat: add mekong network option (#7212)

* chore: fix import order with biome syntax (#7211)

Fix import order

* fix: consistently validate pubkey and throw 404 if not found (#7214)

* Throw error if pubkey is unknown when getting graffiti

* Consistently validate pubkey and throw 404 if not found

* fix: only return local keys from /eth/v1/keystores (#7215)

* fix: only return local keys from /eth/v1/keystores

* Fix fetching remote keys in node assertion

* feat: add and use getBlobsV1 to expedite gossip import (#7134)

* hookup the getblobs api to get bob and proof data from el

remove unused

fix import

metrics overhault, test, debugging testing, some feeback

fix

add nethermind bug dicussion link

fix

resolve conflicts

* deblobs timeout

* fix metric

* chore: revert async aggregate with randomness (#7218)

Revert "feat: asyncAggregateWithRandomness (#7204)"

This reverts commit e31d535.

* fix: update config for relaunched mekong network (#7220)

* fix: light client generating `LightClientUpdate` with wrong length of branches (#7187)

* initial commit

* Rewrite SyncCommitteeWitnessRepository

* Fix finality branch

* Update unit test

* fix e2e

* Review PR

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* fix: archive finalized state when shutting down beacon node (#7221)

* Fix typo

* feat: remove unfinalized pubkey cache (#7230)

* Remove unfinalized pubkey cache

* lint

* Fix unit test

* chore: skip web3_provider unit tests (#7252)

* fix: prune checkpoint states at syncing time (#7241)

* fix: prune checkpoint states at syncing time

* fix: lint

* fix: check-types in test

* fix: sync cached isCompoundingValidatorArr at epoch transition (#7247)

* fix: handle outOfRangeData when range sync Deneb (#7249)

* fix: handle outOfRangeData for beaconBlocksMaybeBlobsByRange()

* fix: lint

* fix: archiveBlocks - handle deneb outOfRangeData block

* fix: sync cached balance when adding new validator to registry (#7255)

* fix: sync cached balance when adding new validator to registry

* chore: add more comments

* fix: remove persisted checkpoint states from the previous run at startup

* fix: do not throw error when trying to prune missing directory (#7257)

* docs: update documentation Oct 2024 (#7178)

* docs update oct 2024 init

* Reconfig quickstart nav and minor fixes

* fix lint

* spelling fixes

* minor fixes and add to wordlist

* prettier fix

* add to wordlist

* sort wordlist

* modify dominance to include lighthouse

* fix typescript casing and add recommendation

* add selection and boost_factor with keymanager notice

* update wordlist

* remove builder enabled and add keymanager api

* spelling

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (#7268)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add error log to notifier if execution client auth failed (#7239)

* feat: add error log to notifier if execution client auth failed

* Update packages/beacon-node/src/node/notifier.ts

---------

Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>

* docs: display rcConfig flag on CLI reference page (#7270)

* docs: display rcConfig flag on CLI reference page

* Update word list

* chore: remove prettier as default formatter for all file types (#7275)

* chore: unhide flags relevant for devnets / testing (#7271)

* feat: debug too many shuffling promises (#7251)

* feat: add asyncShufflingCalculation to StateTransitionOpts

* feat: add asyncShufflingCalculation to all regen / processSlots consumers

* fix: default to false for async shuffling and remove unnecessary props

* fix: remove unnecessary flags from stateTransition

* feat: implement conditional build of shuffling for prepareNextSlot

* fix: spec test bug where shufflingCache is present from BeaconChain constructor

* feat: sync build next shuffling if not queued async

* fix: use getSync to pull next shuffling correctly

* docs: add comment to prepareNextSlot

* refactor: rename StateCloneOpts to StateRegenerationOpts

* feat: pass asyncShufflingCalculation through to afterProcessEpoch and refactor conditional to run purely sync

* docs: add issue number to comment

* chore: lint

* chore: unpin nodejs version from 22.4 (#6982)

* Revert "chore: pin nodejs version to 22.4 (#6964)"

This reverts commit f20484b.

* Don't revert formatting changes

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Cayman <caymannava@gmail.com>

* chore: update bootnodes file url for holesky and sepolia (#7276)

* feat: add `debug_getHistoricalSummaries` endpoint (#7245)

* feat: add new getHistoricalSummaries endpoint to debug namespace

* Add JSON response

* Restructure to use stateId and add proof to response

* add test scaffolding

* Address feedback

* Move getHistoricalSummaries to lodestar namespace

* add lodestar namespace unit test

* update route name to lodestar namespace

* cast state object as Capella state

* Lint

* json properties need to be lower case

* Make it v1 since it's now part of lodestar namespace

* Group with other /lodestar endpoints

* Simplify beacon node impl

* Rename return type

* Update test description

* Fix variable name

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore: log sync committee signature errors as `error` (#7283)

* fix: update engine_getClientVersionV1 commit encoding (#7282)

* fix: check pubkey or validator index known to a state (#7284)

* fix: check pubkey or validator index known to a state

* chore: add more comments

* feat: lodestar script setup (#7254)

* feat: lodestar_setup

* feat: script_updates + docs

* feat: script_addition_in_docs + command_update

* Remove duplicate script from docs folder

* Minor script updates

* Update script to prepare docs and ignore copied file

* Update installation page

* Wording

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* feat: add terminal-sized Electra giraffe banner (#7286)

* Create giraffeBanners.ts

* Wire in banner

* Fix file name

* lint

* Address @nflaig's comment

---------

Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>

* chore: pin nodejs version to 22.4 (#7291)

Revert "chore: unpin nodejs version from 22.4 (#6982)"

This reverts commit 69ae688.

* feat: expose `DOMAIN_APPLICATION_MASK` in config/spec api (#7296)

* feat: expose DOMAIN_APPLICATION_MASK in config/spec api

* Lint

* feat: make `MAX_REQUEST_BLOB_SIDECARS` and `MAX_BLOBS_PER_BLOCK` configurable (#7294)

* Init commit

* Fix check-types

* Add comment on how MAX_REQUEST_BLOB_SIDECARS is calculated

* Ensure proper config object is passed

* Address comment

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* feat: use `BLOB_SIDECAR_SUBNET_COUNT` to configure blob subnets (#7297)

feat: use BLOB_SIDECAR_SUBNET_COUNT to configure blob subnets

* chore: log sync aggregate participants when producing beacon block body (#7300)

* chore: log sync aggregate participants when producing beacon block body

* Use isForkLightClient instead of ForkSeq

* Fix produce block unit tests

* chore: print graffiti when producing beacon block body (#7303)

* fix: warn if engine / builder failed to produce block within cutoff time (#7305)

* feat: add kzg commitment length check when validating gossip blocks (#7302)

* feat: add blob sidecar index check (#7313)

Validate blobSidecar index

* fix: fix blob sidecar index check (#7315)

Fix index check

* chore: fix format of printed graffiti from hex to utf-8 (#7306)

* chore: fix format of printed graffiti from hex to utf-8

* Use Buffer.from no copy with offset

* docs: batch commit typos and update contributor readme (#7312)

* batch commit typos and update contributor readme

* update donation text

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* correct spelling

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore: remove trailing null bytes from printed graffiti (#7320)

* chore: remove trailing null bytes from printed graffiti

* Use replaceAll instead of regex

* chore: unpin nodejs version from 22.4 (#7324)

Revert "chore: pin nodejs version to 22.4 (#7291)"

This reverts commit 99794d3.

* chore: bump package versions to 1.24.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>
Co-authored-by: g11tech <develop@g11tech.io>
Co-authored-by: Matthew Keil <me@matthewkeil.com>
Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>
Co-authored-by: twoeths <tuyen@chainsafe.io>
Co-authored-by: Phil Ngo <58080811+philknows@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: Varun Guleria <152203177+varunguleriaCodes@users.noreply.github.com>
Co-authored-by: ClockworkYuzu <yvetteheh@gmail.com>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.24.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain