Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb for shared folders should start at the overview #1284

Closed
Tbaut opened this issue Jul 15, 2021 · 15 comments · Fixed by #2195
Closed

Breadcrumb for shared folders should start at the overview #1284

Tbaut opened this issue Jul 15, 2021 · 15 comments · Fixed by #2195
Assignees

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Jul 15, 2021

Edit: look at the last post in this conversation, this is what we want to have.


I find it difficult to know whether I'm in a shared folder or if I'm in my home. Ping @sweetpea22
I'd like to suggest some changes:

  • different colors for the root shared folder
  • different color for the breadcrumb to know right away?
  • the shared folder at the root instead of the home

image
image

@Tbaut Tbaut added Planning: Needs Design 🖼️ This UI component still needs one more designs to complete Product: Files labels Jul 15, 2021
@sweetpea22
Copy link
Contributor

sweetpea22 commented Jul 16, 2021

Hey, great thinking. Having the folders change to blue for sharing is an excellent idea. With breadcrumbs...I'm toying with the idea of changing the root folder icon to something more clearly clickable, for now I think your idea of having it replace the home icon is awesome. Let's fly with that? And if it's still not enough we'll change the color of the breadcrumb too

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jul 16, 2021

Another one that would make it easier to know, clearly show in the nav bar where we are. Either with some blue, or the font change?

@sweetpea22
Copy link
Contributor

Heh, you're ahead of the curve always :P these are the changes to sidebar once the new UI comps are added:

hover:
Screen Shot 2021-07-16 at 8 14 53 AM

active:
Screen Shot 2021-07-16 at 8 14 57 AM

what do you think?

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jul 16, 2021

I'm all for it 🙌

@serenaho
Copy link
Collaborator

Question: In regards to the solution mentioned above (changing folder colors), are we showing shared folders within the Home page too? If not, there may not be a need to do so.

A way to keep things consistent would be to add the shared icon (see examples below):

  1. Above the main header in the Shared Folders page
  2. To the breadcrumb whenever a user clicks into a folder

The icon and breadcrumb addition will help users know where they are within the Files UI

Screen Shot 2022-03-23 at 1 48 22 PM
Screen Shot 2022-03-23 at 1 48 27 PM

Ideally, we should also change the navigation icon for Home to be the same house as in My Files like so:

Screen Shot 2022-03-23 at 1 48 51 PM

@asnaith
Copy link
Member

asnaith commented Mar 23, 2022

Question: In regards to the solution mentioned above (changing folder colors), are we showing shared folders within the Home page too?

@serenaho nope they don't show on the home page, shared folders can only be seen on the /shared-overview page and accessed from there.

An icon difference in the breadcrumb sounds like a good improvement for sure :)

@Tbaut
Copy link
Collaborator Author

Tbaut commented Mar 24, 2022

Agreed that changing the icon would help already. Although to me, back to the origin of this issue

I find it difficult to know whether I'm in a shared folder or if I'm in my home.

I feel that just a breadcrumb icon change would not be enough. The active menu being blue should also help a lot like so
image

Another thought and annoyance that I had while navigating, is that clicking the home/shared breadcrumb button brings you back to the root of the shared folder you're in, not to the shared folder overview. Not sure if that's just me, but I found that somewhat annoying as I expected to be back at the highest level of the tree, the shared folder overview, and not at the highest level of this shared folder. If we do change the breadcrumb icon to look like the shared icon, then we also need to make sure clicking it bring back to the folder overview. lmk your thoughts.

@serenaho
Copy link
Collaborator

I agree that the icon should lead back to the shared folder overview (sorry I wasn't very clear in my post). I think ideally the breadcrumb would be as follows:

i.e. Icon / Folder X
Icon = Overview page
Folder X = Root of shared folder

Also agree that there should be an active state for navigation items. I like the addition of the blue, but perhaps we could introduce it in more of a subtle way by just changing the font color:

image

@asnaith
Copy link
Member

asnaith commented Mar 24, 2022

Agreed that changing the icon would help already. Although to me, back to the origin of this issue

I find it difficult to know whether I'm in a shared folder or if I'm in my home.

I feel that just a breadcrumb icon change would not be enough. The active menu being blue should also help a lot

I agree, the breadcrumb change plus a blue active menu would be great.

Another thought and annoyance that I had while navigating, is that clicking the home/shared breadcrumb button brings you back to the root of the shared folder you're in, not to the shared folder overview. Not sure if that's just me, but I found that somewhat annoying as I expected to be back at the highest level of the tree, the shared folder overview, and not at the highest level of this shared folder. If we do change the breadcrumb icon to look like the shared icon, then we also need to make sure clicking it bring back to the folder overview. lmk your thoughts.

👍 Yeah, agree with this too. I think that seems more logical.

@asnaith
Copy link
Member

asnaith commented Mar 24, 2022

@Tbaut regarding the active menu highlighting - were you thinking of doing that for the mobile slide-out menu too? It's not always visible but maybe it could still be useful for the user to know where they are currently at when they slide it out to navigate elsewhere?

@Tbaut
Copy link
Collaborator Author

Tbaut commented Mar 25, 2022

@serenaho

i.e. Icon / Folder X
Icon = Overview page
Folder X = Root of shared folder

The root of the shared folder has no name though. Did you mean that we should name it with the name of the shared folder? I'm not too sure how that's end up look like, because those names are prob quite long and descriptive, meaning we'd hide part of it.

We could also name it "root" but I feel that it's too techy and would confuse users. I've a hard time coming up with a good idea there...

@tanmoyAtb
Copy link
Contributor

tanmoyAtb commented Mar 25, 2022

@serenaho

i.e. Icon / Folder X
Icon = Overview page
Folder X = Root of shared folder

The root of the shared folder has no name though. Did you mean that we should name it with the name of the shared folder? I'm not too sure how that's end up look like, because those names are prob quite long and descriptive, meaning we'd hide part of it.

We could also name it "root" but I feel that it's too techy and would confuse users. I've a hard time coming up with a good idea there...

How about this for the breadcrumb
"Home/Shared users ICON" (for shared-overview) / "Shared folder name" (This is root of shared folder) / "Folder name" / "Folder name" / ...
Even if the shared folder name itself may be long/descriptive, that really should make the most use to the user IMO

@Tbaut
Copy link
Collaborator Author

Tbaut commented Apr 3, 2022

I'm not sure I understand what you mean with "Home/Shared users ICON" (for shared-overview)"

I agree that the shared folder title as the root would work well.

@serenaho
Copy link
Collaborator

serenaho commented Apr 4, 2022

I'm not sure I understand what you mean with "Home/Shared users ICON" (for shared-overview)"

^ @tanmoyAtb I'm also not sure I understand this because you don't have to access the Home page in order to access the Shared Folders Overview page, so starting with the Shared Folder Overview page (the icon) might be more intuitive.

As for the problem with the Folder name being too long, I think it should be okay since the breadcrumb text size is quite small. As an option though, we could set a maximum length for the breadcrumb and start adding ellipses when the length is reached (except for last folder name)? Like below:

Current:
👥 / Shared Folder Title / Folder Title / Folder Title / Folder Title

Suggested:
👥 / Shared ... / Folder ... / Folder ... / Folder Title

(👥 = Shared Overview)

@FSM1
Copy link
Contributor

FSM1 commented Apr 6, 2022

Hey team! Please add your planning poker estimate with ZenHub @tanmoyAtb @Tbaut

@FSM1 FSM1 removed the Planning: Needs Design 🖼️ This UI component still needs one more designs to complete label Apr 6, 2022
@Tbaut Tbaut changed the title Style difference to figure out right away that we are in a shared folder Breadcrumb for shared folders should start at the overview Jun 15, 2022
@Tbaut Tbaut self-assigned this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants