Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Files] Breadcrumb enhancement for shared folders #2195

Merged
merged 10 commits into from
Jun 30, 2022
Merged

[Files] Breadcrumb enhancement for shared folders #2195

merged 10 commits into from
Jun 30, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jun 17, 2022

closes #1284


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Jun 17, 2022

@render
Copy link

render bot commented Jun 17, 2022

@render
Copy link

render bot commented Jun 17, 2022

@Tbaut Tbaut changed the title all good but the annoying svg Breadcrumb enhancement for shared folders Jun 17, 2022
@Tbaut
Copy link
Collaborator Author

Tbaut commented Jun 21, 2022

Tests failing is unrelated, I opened #2198
Also the SVG is not nice in the Breadcrumb for shared folders, but we'll get this fixed before merging.
image

edit: fixed

@Tbaut Tbaut marked this pull request as ready for review June 21, 2022 11:17
@Tbaut Tbaut changed the title Breadcrumb enhancement for shared folders [Files] Breadcrumb enhancement for shared folders Jun 21, 2022
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: I put the review for other PR, my bad

@juans-chainsafe juans-chainsafe self-requested a review June 21, 2022 16:39
@juans-chainsafe
Copy link
Contributor

juans-chainsafe commented Jun 21, 2022

@Tbaut Looking good in Chrome! I need to test in other browsers too and mobile, but seems good so far. I only have one question:

If I understood correctly, based on #1284 (comment) comment, the last folder name should be complete and not with elipsis:

Screen Shot 2022-06-21 at 15 36 54

Maybe we need more clarification there.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jun 21, 2022

Ah I didn't take this into account here. I didn't touch this part and just went for the Breadcrumb enhancement for shared folders and the root. Any folder with a too long name will have ellipsis as before. I guess we can tackle that in another issue if that's really an issue (which I don't really think it is).

@juans-chainsafe
Copy link
Contributor

Ah I didn't take this into account here. I didn't touch this part and just went for the Breadcrumb enhancement for shared folders and the root. Any folder with a too long name will have ellipsis as before. I guess we can tackle that in another issue if that's really an issue (which I don't really think it is).

Yes, make sense, I can create another ticket and we can discuss it tomorrow

Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is working as expected in all browsers but we have an issue inside the dropdown menu in 'Manage access' option:
Screen Shot 2022-06-21 at 16 33 59

Seems that something happened in the design, in stage is displayed correctly.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jun 22, 2022

Nice catch, this is an issue with the svg as well. Added a quick fix for this particular issue, but the svg still needs attention.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jun 22, 2022

The icon is now fixed and it scales correctly 🎉

@Tbaut Tbaut enabled auto-merge (squash) June 22, 2022 15:03
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all working perfect now! awesome

@tanmoyAtb
Copy link
Contributor

Overall the code looks tight.

I still feel the svgs and icons could get some improvement.

The storybooks icon looks big (not a big deal though)!
Screenshot 2022-06-24 at 12 37 42 AM

In files they look smaller that usual.
Screenshot 2022-06-24 at 12 38 54 AM

Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great 🎉

@Tbaut Tbaut merged commit c791ff4 into dev Jun 30, 2022
@Tbaut Tbaut deleted the tbaut-1284 branch June 30, 2022 09:39
@Tbaut
Copy link
Collaborator Author

Tbaut commented Jun 30, 2022

In files they look smaller that usual.

I missed that sorry. So the home icon should be 20px size, and this shouldn't have changed (in the app, I didn't check storybook).
The shared-folder group icon is new , we can make it more than 20px but this is what we had so far afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb for shared folders should start at the overview
4 participants