Extend ui tests coverage to include file moving and permanent deletion #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://storage-ui-stage-pr-1451.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4e2v4s1nok0bhj6e9ng. |
|
Your Render PR Server URL is https://gaming-ui-stage-pr-1451.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4e2v541nok0bhj6ea40. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1451.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4e2v5k1nok0bhj6eae0. |
github-actions
bot
added
the
Type: Maintenance
asnaith
commented
Aug 17, 2021
| @@ -111,6 +111,7 @@ Cypress.Commands.add("safeClick", { prevSubject: "element" }, $element => { | |||
| return cy | |||
| .wrap($element) | |||
| .should("be.visible") | |||
| .should("be.enabled") | |||
There was a problem hiding this comment.
Fyi just a small mod to add even more safety to the safeClick(). I noticed it eradicated some false failures that I saw whilst running one of the new tests hundreds of times.
RyRy79261
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1442