-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ui tests coverage to include file moving and permanent deletion #1451
Merged
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
27325d1
Define modals in the test suite as separate objects
asnaith a5d78f4
Add new test object for move file modal
asnaith 0261391
Rename recover modal test object for better accuracy
asnaith cafc851
Add test coverage for file moving and permanent deletion
asnaith 71583f4
Merge branch 'dev' into mnt/add-tests-move-and-permanent-delete-1442
asnaith 94a58da
remove debug command
asnaith 792061c
Add additional check to safeClick for even more reliability
asnaith 52a701f
lingui extract
actions-user 7d8fd22
Merge branch 'dev' into mnt/add-tests-move-and-permanent-delete-1442
FSM1 b68552c
Merge branch 'dev' into mnt/add-tests-move-and-permanent-delete-1442
Tbaut 8ac9af3
Merge branch 'dev' into mnt/add-tests-move-and-permanent-delete-1442
Tbaut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
packages/files-ui/cypress/support/page-objects/modals/moveItemModal.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export const moveItemModal = { | ||
body: () => cy.get("[data-testId=modal-container-modal-move-file]"), | ||
cancelButton: () => cy.get("[data-cy=button-cancel-move]"), | ||
errorLabel: () => cy.get("[data-cy=label-move-file-error-message]"), | ||
folderList: () => cy.get("[data-cy=tree-folder-list]"), | ||
moveButton: () => cy.get("[data-cy=button-move-file]") | ||
} |
7 changes: 7 additions & 0 deletions
7
packages/files-ui/cypress/support/page-objects/modals/recoverItemModal.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export const recoverItemModal = { | ||
body: () => cy.get("[data-testId=modal-container-modal-recover-file]"), | ||
cancelButton: () => cy.get("[data-cy=button-cancel-recovery]"), | ||
errorLabel: () => cy.get("[data-cy=label-move-file-error-message]"), | ||
folderList: () => cy.get("[data-cy=tree-folder-list]"), | ||
recoverButton: () => cy.get("[data-cy=button-recover-file]") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi just a small mod to add even more safety to the
safeClick()
. I noticed it eradicated some false failures that I saw whilst running one of the new tests hundreds of times.