Fix typing issues that appeared with cypress v9.1 upgrade #1791
Conversation
|
Your Render PR Server URL is https://storage-ui-stage-pr-1791.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6j4iekobjda2kfphnog. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1791.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6j4if4objda2kfpho50. |
github-actions
bot
added
the
Type: Maintenance
* new user every time * banner test with old test user
packages/files-ui/cypress/support/page-objects/authenticationPage.ts
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Outdated
Show resolved
Hide resolved
|
Added some very minor suggestions just for consistency, I've been putting the element type at the beginning of the string for identifiers (otherwise would have approved in advance but saw that auto-merge was on) :) |
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
| loginPasswordButton: () => cy.get("[data-cy=login-password-button]", { timeout: 20000 }), | ||
| loginPasswordInput: () => cy.get("[data-cy=login-password-input]"), |
There was a problem hiding this comment.
we can change these 2 in another PR @asnaith or feel free to commit here directly before approving so that it's done.
There was a problem hiding this comment.
Yeah, think a separate house-keeping PR is best 👍
| signInExplainerContinueButton: () => cy.get("[data-cy=button-sign-in-explainer-continue]", { timeout: 20000 }), | ||
| signInSetupPasswordInput: () => cy.get("[data-cy=input-sign-in-password]"), | ||
| signInSetupPasswordVerificationInput: () => cy.get("[data-cy=input-sign-in-password-verification]"), | ||
| signInSetupPasswordSubmitButton: () => cy.get("[data-cy=button-sign-in-password]"), | ||
|
|
||
| // save browser section elements | ||
| saveBrowserButton: () => cy.get("[data-cy=save-browser-button]"), |
If you open
packages/files-ui/cypress/support/commands.tsindev, you'll see red squiggles, although the tests run without issue.This PR fixes those typing issues.