Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a new random user for every test run #1792

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Use a new random user for every test run #1792

merged 2 commits into from
Dec 1, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Nov 30, 2021

closes #1696

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Nov 30, 2021
@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Nov 30, 2021
@Tbaut
Copy link
Collaborator Author

Tbaut commented Nov 30, 2021 •
edited
Loading

ah the survey banner fails, that makes sense, will force the test user for this one :)

@Tbaut Tbaut merged commit 47006be into mnt/tbaut-fix-type-issues-cypressv9-1 Dec 1, 2021
@Tbaut Tbaut deleted the mnt/tbaut-new-test-user-every-time-1696 branch December 1, 2021 14:55
Tbaut added a commit that referenced this pull request Dec 1, 2021
@Tbaut @actions-user @FSM1
Fix typing issues that appeared with cypress v9.1 upgrade (#1791)
44fe032 
* no 0 anymore

* more succint

* lingui extract

* fix typing and definitions

* unneeded index.d.ts

* undo other commit

* unneeded void

* Use a new random user for every test run (#1792)

* new user every time

* banner test with old test user

Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@FSM1 FSM1 FSM1 approved these changes

@asnaith asnaith Awaiting requested review from asnaith

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tbaut @RyRy79261 @FSM1