sort Buckets table test #2207
sort Buckets table test #2207
Conversation
juans-chainsafe
added
the
Type: Maintenance
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-2207.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-catjim10gd05b6sj9vug. |
|
Your Render PR Server URL is https://files-ui-stage-pr-2207.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-catjin10gd05b6sja030. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-2207.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-catjio90gd05b6sja0kg. |
packages/storage-ui/cypress/support/page-objects/bucketsPage.ts
Outdated
Show resolved
Hide resolved
| @@ -22,11 +24,19 @@ export const bucketsPage = { | |||
| deleteBucketMenuOption: () => cy.get("[data-cy=menu-delete-bucket]"), | |||
|
|
|||
| // helpers and convenience functions | |||
| createBucket(bucketName: string) { | |||
| createBucket(bucketName: string, bucketType: FILE_SYSTEM_TYPES) { | |||
There was a problem hiding this comment.
I checked after merging, but this is somewhat of an outlier. It's working as you want, but we usually use type in a different way, without using enum, and a little less wordy, but effectively achieving the same, with type safety, this would be something like
type BucketType = "ipfs" | "chainsafe"
createBucket(bucketName: string, bucketType: BucketType) {
// ...
case "ipfs"
// ...
case "chainsafe"
There was a problem hiding this comment.
thanks for that Tbaut! I forget about type, but I remember that I use that to replace the enum 3 years ago haha, I will make this change in the "rename folder and file test" PR
closes #2202
Very similar to the test of sorting Files table.