Rename folder and file in Storage test #2214

juans-chainsafe · 2022-07-05T18:55:33Z

closes #2204

…file-2204-test

render · 2022-07-05T18:55:40Z

Your Render PR Server URL is https://chainsafe-components-stage-pr-2214.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cb28iada4991n33vpgeg.

render · 2022-07-05T18:55:46Z

Your Render PR Server URL is https://files-ui-stage-pr-2214.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cb28ibta4991n33vpgj0.

render · 2022-07-05T18:55:52Z

Your Render PR Server URL is https://storage-ui-stage-pr-2214.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cb28idda4991n33vph4g.

juans-chainsafe · 2022-07-05T18:56:54Z

packages/storage-ui/cypress/support/page-objects/bucketsPage.ts

 import { basePage } from "./basePage"
 import { createBucketModal } from "./modals/createBucketModal"

+type BucketType = "ipfs" | "chainsafe"


improvement suggested by Thibaut in #2207 (comment)

asnaith · 2022-07-06T22:06:46Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      // ensure the original name of the folder persists if the rename submission is blank
+      bucketContentsPage.renameFileOrFolder("{selectall}{del}{esc}")
+      bucketContentsPage.fileRenameInput().should("not.exist")
+      bucketContentsPage.fileItemName().contains(newFolderName)


Original name has already been updated to the new one by this point (see assertion) so just to make the test read better then probably makes sense to swap the order of this check to before the rename, what do you think?

asnaith · 2022-07-06T22:12:19Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      // ensure that the name of the folder is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")
+      bucketContentsPage.fileRenameInput().should("not.exist")
+      bucketContentsPage.fileItemKebabButton().first().click()


I don't think first is necessary as there is only one folder present?

Suggested change

bucketContentsPage.fileItemKebabButton().first().click()

bucketContentsPage.fileItemKebabButton().click()

I will fix this ones and the {selectall}{del} error in Files as well

asnaith · 2022-07-06T22:15:08Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      bucketContentsPage.fileItemName().contains(newFolderName)
+
+      // ensure that the name of the folder is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")


Suggested change

bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")

bucketContentsPage.renameFileOrFolder("{selectall}{del}abc{esc}")

asnaith · 2022-07-06T22:16:56Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      bucketContentsPage.fileItemName().contains(newFolderName)
+
+      // ensure that the name of the folder is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")


Suggested change

bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")

bucketContentsPage.renameFileOrFolder("{selectall}{del}abc{esc}")

asnaith · 2022-07-06T22:17:31Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      bucketContentsPage.fileItemName().contains(newFileName)
+
+      // ensure that the name of the file is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")


Suggested change

bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")

bucketContentsPage.renameFileOrFolder("{selectall}{del}abc{esc}")

asnaith · 2022-07-06T22:17:58Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      bucketContentsPage.fileItemName().contains(newFileName)
+
+      // ensure that the name of the file is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")


Suggested change

bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")

bucketContentsPage.renameFileOrFolder("{selectall}{del}abc{esc}")

asnaith · 2022-07-06T22:18:28Z

packages/storage-ui/cypress/support/page-objects/bucketContentsPage.ts

+  },
+
+  renameFileOrFolder(newName: string) {
+    bucketContentsPage.fileItemKebabButton().first().click()


Suggested change

bucketContentsPage.fileItemKebabButton().first().click()

bucketContentsPage.fileItemKebabButton().click()

asnaith · 2022-07-06T22:18:55Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      // ensure that the name of the folder is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")
+      bucketContentsPage.fileRenameInput().should("not.exist")
+      bucketContentsPage.fileItemKebabButton().first().click()


Suggested change

bucketContentsPage.fileItemKebabButton().first().click()

bucketContentsPage.fileItemKebabButton().click()

asnaith · 2022-07-06T22:19:50Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      // ensure that the name of the file is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")
+      bucketContentsPage.fileRenameInput().should("not.exist")
+      bucketContentsPage.fileItemKebabButton().first().click()


Suggested change

bucketContentsPage.fileItemKebabButton().first().click()

bucketContentsPage.fileItemKebabButton().click()

asnaith · 2022-07-06T22:20:06Z

packages/storage-ui/cypress/tests/bucket-management.cy.ts

+      // ensure that the name of the file is reset when renaming is canceled
+      bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")
+      bucketContentsPage.fileRenameInput().should("not.exist")
+      bucketContentsPage.fileItemKebabButton().first().click()


Suggested change

bucketContentsPage.fileItemKebabButton().first().click()

bucketContentsPage.fileItemKebabButton().click()

asnaith · 2022-07-07T00:16:56Z

packages/storage-ui/cypress/support/page-objects/bucketsPage.ts

+    cy.wait("@refresh")
+  },
+
+  createBucket(bucketName: string, bucketType: BucketType) {


You could do this

Suggested change

createBucket(bucketName: string, bucketType: BucketType) {

createBucket(bucketName: string, bucketType: "ipfs" | "chainsafe") {

and then no need to have type BucketType = "ipfs" | "chainsafe" declared towards the top of the file.

As there are only two types of bucket you could also get rid of the switch for a simpler if / else statement

make sense to have it as a parameter because is only used there! and... yeah as well make sense that can be solved with if/else because is only 2 types of file system

asnaith

Looks good @juans-chainsafe! Just left some minor suggestions.

Tbaut

Great one and great review by Andrew, nothing else to add :)

juans-chainsafe added 5 commits June 30, 2022 09:38

replace switch for type in bucket test

13d61d2

progress rename bucket folder and file

66b803f

progress rename bucket folder and file

05d66c3

Merge remote-tracking branch 'origin/dev' into mnt/rename-folder-and-…

5e444c5

…file-2204-test

rename folder and file in storage tests

675c2fc

juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jul 5, 2022

juans-chainsafe requested review from asnaith, tanmoyAtb, FSM1 and Tbaut July 5, 2022 18:55

juans-chainsafe self-assigned this Jul 5, 2022

juans-chainsafe linked an issue Jul 5, 2022 that may be closed by this pull request

[Storage] Rename folder and file test #2204

Closed

juans-chainsafe commented Jul 5, 2022

View reviewed changes

Merge branch 'dev' into mnt/rename-folder-and-file-2204-test

8e0c5b2

juans-chainsafe changed the title ~~Mnt/rename folder and file 2204 test~~ Rename folder and file in Storage test Jul 5, 2022

asnaith reviewed Jul 6, 2022

View reviewed changes

asnaith reviewed Jul 7, 2022

View reviewed changes

suggestions in PR done for rename file or folder test storage

86c7af9

Tbaut approved these changes Jul 7, 2022

View reviewed changes

fix in rename file in Files test

28e8706

juans-chainsafe requested a review from asnaith July 7, 2022 13:27

fix rename test in files

ce77f94

asnaith approved these changes Jul 7, 2022

View reviewed changes

juans-chainsafe merged commit e3a8c2e into dev Jul 8, 2022

juans-chainsafe deleted the mnt/rename-folder-and-file-2204-test branch July 8, 2022 12:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename folder and file in Storage test #2214

Rename folder and file in Storage test #2214

juans-chainsafe commented Jul 5, 2022

render bot commented Jul 5, 2022

render bot commented Jul 5, 2022

render bot commented Jul 5, 2022

juans-chainsafe Jul 5, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

juans-chainsafe Jul 7, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

asnaith Jul 6, 2022

asnaith Jul 7, 2022 •

edited

Loading

juans-chainsafe Jul 7, 2022

asnaith left a comment

Tbaut left a comment

	bucketContentsPage.fileItemKebabButton().first().click()
	bucketContentsPage.fileItemKebabButton().click()

	bucketContentsPage.renameFileOrFolder("{selectall}abc{del}{esc}")
	bucketContentsPage.renameFileOrFolder("{selectall}{del}abc{esc}")

	createBucket(bucketName: string, bucketType: BucketType) {
	createBucket(bucketName: string, bucketType: "ipfs" \| "chainsafe") {

Rename folder and file in Storage test #2214

Rename folder and file in Storage test #2214

Conversation

juans-chainsafe commented Jul 5, 2022

render bot commented Jul 5, 2022

render bot commented Jul 5, 2022

render bot commented Jul 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asnaith Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asnaith left a comment

Choose a reason for hiding this comment

Tbaut left a comment

Choose a reason for hiding this comment

asnaith Jul 7, 2022 •

edited

Loading