typo: rename SetRollingInternal to SetRollingInterval #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is exactly the problem I am currently facing. I was about to submit a PR and found that there was already an ongoing PR. Thanks, @ntark |
Member
|
thanks for your PR! |
Jaben
added a commit
that referenced
this pull request
Oct 4, 2025
Updated version to 7.1.0 with release notes: - Fixed Guid to BsonValue mapping error (#91) - Fixed RollingInterval collection naming (#95) - Fixed SetRollingInternal to SetRollingInterval typo (#97) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDBSinkConfiguration.cs > SetRollingInternal method is public so that is going to be a breaking change
Closes #96