Skip to content

typo: rename SetRollingInternal to SetRollingInterval #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
Merged

typo: rename SetRollingInternal to SetRollingInterval #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ var log = new LoggerConfiguration()

// sink will use the IMongoDatabase instance provided
cfg.SetMongoDatabase(mongoDbInstance);
cfg.SetRollingInternal(RollingInterval.Month);
cfg.SetRollingInterval(RollingInterval.Month);
})
.CreateLogger();
```
Expand Down
2 changes: 1 addition & 1 deletion src/Serilog.Sinks.MongoDB/LoggerConfigurationMongoDBExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public static LoggerConfiguration MongoDBBson(
cappedMaxSizeMb ?? MongoDBSinkDefaults.CappedCollectionMaxSizeMb,
cappedMaxDocuments);

if (rollingInterval.HasValue) cfg.SetRollingInternal(rollingInterval.Value);
if (rollingInterval.HasValue) cfg.SetRollingInterval(rollingInterval.Value);

cfg.Validate();

Expand Down
2 changes: 1 addition & 1 deletion src/Serilog.Sinks.MongoDB/Sinks/MongoDB/MongoDBSinkConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void Validate()
/// Set the RollingInterval. (Default: RollingInterval.Infinite)
/// </summary>
/// <param name="rollingInterval"></param>
public void SetRollingInternal(RollingInterval rollingInterval)
public void SetRollingInterval(RollingInterval rollingInterval)
{
this.RollingInterval = rollingInterval;
}
Expand Down
2 changes: 1 addition & 1 deletion test/Serilog.Sinks.MongoDB.Tests/LoggerConfigurationMongoDBExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ private static void TestCollectionAndDocumentExists(RollingInterval? rollingInte
{
configuration.SetMongoDatabase(mongoDatabase);
if (rollingInterval is not null)
configuration.SetRollingInternal(rollingInterval.Value);
configuration.SetRollingInterval(rollingInterval.Value);
configuration.SetCollectionName(MongoCollectionName);
}).CreateLogger())
{
Expand Down