Added autocompletion in /whispers for Twitch emotes, Global Bttv/Ffz emotes and emojis #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight refactor in CompletionModel allows us to differentiate between regular Twitch channel and other Twitch channels, as defined by `Channel::Type`. Added completion for - TwitchAccount's emotes (global and subscriber) - Bttv/Ffz global emotes - Emojis In the means of refactor `addString` lambda has been promoted to a private method `CompletionModel::addString`
It's not worth having to pass prefix every time when we want to call addString
…omplete-emotes-in-whispers
pajlada
changed the title
1 task
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jul 17, 2021
Now we're on commit 9f2fc90; Changes from upstream we pulled: - Major: Newly uploaded Twitch emotes are once again present in emote picker and can be autocompleted with Tab as well. (Chatterino#2992) - Minor: Added autocompletion in /whispers for Twitch emotes, Global Bttv/Ffz emotes and emojis. (Chatterino#2999, Chatterino#3033) - Minor: Received Twitch messages now use the exact same timestamp (obtained from Twitch's server) for every Chatterino user instead of assuming message timestamp on client's side. (Chatterino#3021) - Minor: Received IRC messages use `time` message tag for timestamp if it's available. (Chatterino#3021) - Bugfix: Fixed "smiley" emotes being unable to be "Tabbed" with autocompletion, introduced in v2.3.3. (Chatterino#3010) - Dev: Ubuntu packages are now available (Chatterino#2936)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Slight refactor in CompletionModel allows us to differentiate between regular Twitch channel and other Twitch channels, as defined by
Channel::Type.Added completion for
In the means of refactor
addStringlambda has been promoted to a private methodCompletionModel::addString.CompletionModel::TaggedStringseems to be a veeeeery old artifact that's gone since quite some time, so I also removed it.Closes #900