Refactor Tab completion for Twitch commands #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added autocompletion for default Twitch commands starting with the '.'
- Added a helper function wrapping QString::{startsWith,contains} methods, so no duplication in addString inside of CompletionModel.cpp has been removed
- Separate default Chatterino commands from default Twitch commands
- Add separate types in TaggedString for all different types of commands (custom Chatterino commands, default Chatterino commands, default
Twitch commands)
- Moved twitchDefaultCommands and whisperCommands to TwitchCommon.cpp
- TWITCH_DEFAULT_COMMANDS were stripped off leading slash. Instead, we just check for either a slash or a dot inside of CompletionModel.cpp (see first dash). That's been done to make it possible to autocomplete Twitch commands starting with a dot
Only private class members should have their names end with an underscore
…r-tab-command-completion
…r-tab-command-completion
zneix
changed the title
Mm2PL
approved these changes
Dec 7, 2021
…r-tab-command-completion
zneix
changed the title
…r-tab-command-completion
pajlada
approved these changes
Dec 26, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Dec 26, 2021
Now we're on commit f64047d; Changes from upstream we've pulled - Minor: Added clear button to settings search bar. (Chatterino#3403) - Minor: Added autocompletion for default Twitch commands starting with the dot (e.g. `.mods` which does the same as `/mods`). (Chatterino#3144) - Bugfix: Fixed character counter changing fonts after going over the limit. (Chatterino#3422)
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Refactored the way autocompletion works for Twitch commands. These are now less "hardcoded", as they no longer include
/in the command name. As the additional result, Tab autocompletion for commands starting with a dot was also added./deleteTwitch command to the list of commands while moving it toTwitchCommon.cppQString::{startsWith,contains}methods, so duplication in addString inside ofCompletionModel.cpphas been removedCommandController.cppTaggedStringfor all different types of commands (custom Chatterino commands, default Chatterino commands, default Twitch commands)twitchDefaultCommandsandwhisperCommandstoTwitchCommon.cppTWITCH_DEFAULT_COMMANDSwere stripped off leading slash. Instead, we just check for either a slash or a dot inside ofCompletionModel.cpp(see first dash). That's been done to make it possible to autocomplete Twitch commands starting with a dotCommandController(items_->items)Related to/Extends #2999