Add clear button to settings search bar #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
approved these changes
Dec 13, 2021
Mm2PL
approved these changes
Dec 13, 2021
|
Qt has clearButtonEnabled for inputs, the only difference is button disappear instead of graying out |
|
I was able to find a way to use |
pajlada
approved these changes
Dec 26, 2021
|
Good addition, thank you! |
zneix
approved these changes
Dec 26, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Dec 26, 2021
Now we're on commit f64047d; Changes from upstream we've pulled - Minor: Added clear button to settings search bar. (Chatterino#3403) - Minor: Added autocompletion for default Twitch commands starting with the dot (e.g. `.mods` which does the same as `/mods`). (Chatterino#3144) - Bugfix: Fixed character counter changing fonts after going over the limit. (Chatterino#3422)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Adds an "x" icon to the right side of the settings search bar for easy unfiltering with a single click. When nothing is entered, the button darkens, and upon typing, the button brightens.
I decided to give this a go because text inputs (no matter where) that auto-filter something as the user types typically make more sense UX-wise if they have a clear button to undo the filtering.