Simplify ResizingTextEdit::isFirstWord
to avoid invalid QString index warnings
#3285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
As pointed out in #3234 (comment) I've localized the issue and fixed it.
Turns out that our complicated logic with iterating over
QTextEdit
's plainText and checking whether it contains space or not can be just replaced with a simpleQString::contains
which does exactly the same thing as our function did before.While this might be a bit silly logic for detecting a first word, this is something to think of in the future, not something I'm focusing on approaching in this PR.
I've confirmed it Fixes #3234