Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCharRef with an index pointing outside the valid range of a QString warning #3234

Closed
zneix opened this issue Sep 11, 2021 · 2 comments · Fixed by #3285
Closed

QCharRef with an index pointing outside the valid range of a QString warning #3234

zneix opened this issue Sep 11, 2021 · 2 comments · Fixed by #3285
Assignees
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@zneix
Copy link
Collaborator

zneix commented Sep 11, 2021

Describe your issue
Upon pressing Tab in Chatterino, a following warning is generated:
[13:57:35.344] unknown Using QCharRef with an index pointing outside the valid range of a QString. The corresponding behavior is deprecated, and will be changed in a future version of Qt.

Pretty sure it's actually CompletionModel::refresh generating it, since pressing Tab only after text in text edit has changed generates said warning.
It has been around for literally months if not years and it's high time we fix this, because in Qt6 something has changed about it and it's something that crashes on my zneix/feature/qt6 branch.

Screenshots
N/A

OS and Chatterino Version
Arch GNU/Linux, master

@zneix zneix added issue-report An issue reported by a user. bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Sep 11, 2021
@zneix zneix self-assigned this Sep 11, 2021
@Epinomis
Copy link
Contributor

Epinomis commented Oct 14, 2021

a
this happens in ResizingTextEdit::isFirstWord(), when this->textCursor().position() >= plainText.size()

@zneix
Copy link
Collaborator Author

zneix commented Oct 15, 2021

a this happens in ResizingTextEdit::isFirstWord(), when this->textCursor().position() >= plainText.size()

Thanks for a useful debug writeup, I'll make a fix right now 👍

zneix added a commit to SevenTV/chatterino7 that referenced this issue Oct 25, 2021
Now we're on commit 4a90f10; Changes from upstream we've pulled:

- Minor: Added new search predicate to filter for messages matching a regex (Chatterino#3282)
- Minor: Subcategories in settings are now searchable. (Chatterino#3157)
- Minor: Highlight usernames in /mods and /vips messages (Chatterino#3187)
- Minor: Added chatter count to viewer list popout (Chatterino#3261)
- Minor: Added `flags.first_message` filter variable (Chatterino#3292)
- Minor: Removed duplicate setting for toggling `Channel Point Redeemed Message` highlights (Chatterino#3296)
- Bugfix: Fixed a bug that caused zero-width emotes to be misaligned when the "Remove spaces between emotes" setting is on. (Chatterino#3249)
- Bugfix: Fixed the "Change channel" popup showing a wrong window title (Chatterino#3273)
- Bugfix: Fixed built-in Chatterino commands not working in whispers and mentions special channels (Chatterino#3288)
- Bugfix: Fixed `QCharRef with an index pointing outside the valid range of a QString` warning that was emitted on every Tab press. (Chatterino#3234)
- Bugfix: Fixed being unable to disable `First Message` highlights (Chatterino#3293)
- Bugfix: Fixed `First Message` custom sound not persisting through restart. (Chatterino#3303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
2 participants