Fixed Searching for subcategories #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
requested changes
Aug 9, 2021
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
Felanbird
approved these changes
Aug 9, 2021
|
This pr only fixes the generalpage subcategories (I only edited the GeneralPageView after all) |
Ah yes, I tested wrong when I retried searching from my current build without this pr 😄 |
zneix
requested changes
Aug 15, 2021
There was a problem hiding this comment.
The fix indeed does what it is supposed to do, however I am pretty sure that the freeze that occurs upon putting anything into the settings search box is even longer than it originally was and I am wondering if that can be optimized somehow.
Other than nitpicks from code review, good stuff 👍
Co-authored-by: Paweł <zneix@zneix.eu>
pajlada
approved these changes
Oct 24, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Oct 25, 2021
Now we're on commit 4a90f10; Changes from upstream we've pulled: - Minor: Added new search predicate to filter for messages matching a regex (Chatterino#3282) - Minor: Subcategories in settings are now searchable. (Chatterino#3157) - Minor: Highlight usernames in /mods and /vips messages (Chatterino#3187) - Minor: Added chatter count to viewer list popout (Chatterino#3261) - Minor: Added `flags.first_message` filter variable (Chatterino#3292) - Minor: Removed duplicate setting for toggling `Channel Point Redeemed Message` highlights (Chatterino#3296) - Bugfix: Fixed a bug that caused zero-width emotes to be misaligned when the "Remove spaces between emotes" setting is on. (Chatterino#3249) - Bugfix: Fixed the "Change channel" popup showing a wrong window title (Chatterino#3273) - Bugfix: Fixed built-in Chatterino commands not working in whispers and mentions special channels (Chatterino#3288) - Bugfix: Fixed `QCharRef with an index pointing outside the valid range of a QString` warning that was emitted on every Tab press. (Chatterino#3234) - Bugfix: Fixed being unable to disable `First Message` highlights (Chatterino#3293) - Bugfix: Fixed `First Message` custom sound not persisting through restart. (Chatterino#3303)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixes #2707