Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge remote-tracking branch 'chatterino2' into feature/pronouns #4

Conversation

Felanbird
Copy link

@Felanbird Felanbird commented Oct 25, 2021

We are now on c19fd0d - Notable changes from upstream:

Fixed splits losing filters when closing and reopening them Chatterino#3351
Add "clear cache" button to settings Chatterino#3277
Add copy button for both login & display name inside the user info popout Chatterino#3335
Fixed underlying text from disabled emotes not being colorized after using /me Chatterino#3333
Parse usernames out of /mods and /vips messages: Chatterino#3187
Add chatter count to viewer list popout: Chatterino#3261
Add flags.first_message filter variable: Chatterino#3292
Subcategories in settings are now searchable Chatterino#3157

2021-11-07 edit: I deleted it I don't remember what it said
2021-10-31 edit: We are now on: 4b903d7 Notable changes from upstream:
2021-10-30 edit: We are now on: b4b7450 - Notable changes from upstream: nothing special since I opened this PR
We are now on: 4a90f10 - Notable changes from upstream:

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

I probably wont end up doing weekly updates unless there's actually important things, (edit: xd) // this was obviously a lie
but for this the actual important change is Chatterino#3293

Currently 'First Message` highlights cannot be disabled, and many of the people who would enjoy having the pronouns extension, would hate not being able to disable this, so I've held off on mentioning it until this could be committed.

We are now on: 4a90f10 - Noteable
changes from upstream:

Parse usernames out of /mods and /vips messages: Chatterino#3187
Add chatter count to viewer list popout: Chatterino#3261
Add flags.first_message filter variable: Chatterino#3292
@Felanbird
Copy link
Author

I'm going to close this PR and the other one for a couple reasons.

The main one being due to a discussion in Chatterino#3346 - I've realized how much of a pain this extension is when sending a single request for EVERY SINGLE user. It seems like it would be a billion times easier to support in Chatterino if the information was sent in json form (similar to FFZ and Chatterino badges.)

The minor one being the people who would enjoy this, also would be confused/frustrated with having to download a nightly build and while waiting for chatters to load, would assume it's not working because of how long it takes - and the restart/refresh after the loading has finished. So they would be liable to just remove it instead of waiting.

As a note: if/when you intend to update this in the future, be careful of Chatterino#3335 as it breaks pronouns sticking in the usercard.

@Felanbird Felanbird closed this Nov 14, 2021
GabeEddyT pushed a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant