Fix IRC mentions not showing up in the /mentions split #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
approved these changes
Dec 12, 2021
pajlada
force-pushed
the
fix/irc-mentions
branch
from
4057d2b to
76eba65
Compare
zneix
approved these changes
Dec 25, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Dec 25, 2021
Now we're on commit efcef61; Changes from upstream we've pulled - Minor: Sorted usernames in `Users joined/parted` messages alphabetically. (Chatterino#3421) - Minor: Mod list, VIP list, and Users joined/parted messages are now searchable. (Chatterino#3426) - Bugfix: Fixed IRC mentions not showing up in the /mentions split. (Chatterino#3400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
The /mentions split is technically categorized both in our code and in the "new split" dialog as under Twitch, however the description indicates that it should show mentions from all channels, not just all Twitch channels.
This solution works but it's not super pretty in the code as we're importing and using the Twitch server to fetch the special mentions channel.
I have tested clicking the channel name and it finds the split correctly.
I have tested not having any Twitch channels open, and it still works as expected.
Fixes #3381