Add search to emote popup #3404
Conversation
There was a problem hiding this comment.
Nice feature addition! Thank you for the contribution
Got some small tweaks/concerns covered in the comments that I'd like adressed before merging this in. Let me know if you have any questions!
Open questions for others who test this:
- How should pressing Escape behave when the search input is filled? Right now it closes the popup, but I feel like maybe it should clear the search entry first if there's a search query active
- Should the search input be selected by default? I don't believe it is right now, but I think it would be nice if it was
I believe it should be - we already have this as some sort of standard across different dialogs that implement the search input anyway (e.g. Settings dialog, Message Search dialog) |
Got code in my local repository fixing this, and adding support for the hotkey system. Will push together with a merge when another PR has been merged in to save on CI hours. |
Co-authored-by: Paweł <zneix@zneix.eu>
Now we're on commit 14d11b6; Changes from upstream we've pulled - Minor: Add search to emote popup. (Chatterino#3404) - Minor: Messages can now be highlighted by subscriber or founder badges. (Chatterino#3445) - Bugfix: Fixed crash that could occur if the user opens/closes ChannelViews (e.g. EmotePopup, or Splits) then modifies the showLastMessageIndicator setting. (Chatterino#3444) - Dev: Batch checking live status for channels with live notifications that aren't connected. (Chatterino#3442) - Dev: Added /fakemsg command for debugging (Chatterino#3448) - Dev: Notebook::select\* functions now take an optional `focusPage` parameter (true by default) which keeps the default behaviour of selecting the page after it has been selected. If set to false, the page is _not_ focused after being selected. (Chatterino#3446)
Now we're on commit 4e422b3; Changes from upstream we've pulled +- Minor: Add search to emote popup. (Chatterino#3404, Chatterino#3527) // Chatterino#3527 got added, Chatterino#3404 was alredy merged in +- Minor: Colorize the entire split header when focused. (Chatterino#3379)
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
A search bar at the top of the emote popup that filters all emotes across every tab as you type. Uses a new ChannelView to combine all emote sets and is initially hidden until something is typed.