Made emote search not crash in non-Twitch channels. #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
approved these changes
Jan 18, 2022
zneix
approved these changes
Jan 22, 2022
pajlada
approved these changes
Jan 22, 2022
zneix
changed the title
zneix
deleted the
fix/make_emote_search_not_crash_in_non_twitch_channels
branch
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jan 28, 2022
Now we're on commit 4e422b3; Changes from upstream we've pulled +- Minor: Add search to emote popup. (Chatterino#3404, Chatterino#3527) // Chatterino#3527 got added, Chatterino#3404 was alredy merged in +- Minor: Colorize the entire split header when focused. (Chatterino#3379)
qooq69
pushed a commit
to qooq69/chatterino2
that referenced
this pull request
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
I encased all Twitch-specific functionality in a check for a Twitch channel.
Closes #3526