Reward only first TN measurements per round. Closes #98 (#101)

* Reward only first TN measurements per round. Closes #98 * Update lib/evaluate.js Co-authored-by: Miroslav Bajtoš <oss@bajtos.net> * Update lib/evaluate.js Co-authored-by: Miroslav Bajtoš <oss@bajtos.net> --------- Co-authored-by: Miroslav Bajtoš <oss@bajtos.net>
CheckerNetwork · Dec 13, 2023 · 224b0fd · 224b0fd
1 parent 14790c3
commit 224b0fd
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 1 deletion.
diff --git a/lib/evaluate.js b/lib/evaluate.js
@@ -69,7 +69,8 @@ export const evaluate = async ({
   const fraudAssessments = {
     OK: 0,
     INVALID_TASK: 0,
-    DUP_INET_GROUP: 0
+    DUP_INET_GROUP: 0,
+    TOO_MANY_TASKS: 0
   }
   for (const m of measurements) {
     fraudAssessments[m.fraudAssessment] = (fraudAssessments[m.fraudAssessment] ?? 0) + 1
@@ -249,6 +250,19 @@ export const runFraudDetection = async (roundIndex, measurements, sparkRoundDeta
     }
   }
 
+  //
+  // 3. Reward only first TN measurements
+  //
+  const tasksPerNode = new Map()
+  for (const m of measurements) {
+    if (m.fraudAssessment && m.fraudAssessment !== 'OK') continue
+    const node = `${m.inet_group}::${m.participantAddress}`
+    tasksPerNode.set(node, (tasksPerNode.get(node) ?? 0) + 1)
+    if (tasksPerNode.get(node) > sparkRoundDetails.maxTasksPerNode) {
+      m.fraudAssessment = 'TOO_MANY_TASKS'
+    }
+  }
+
   if (debug.enabled) {
     for (const m of measurements) {
       // Print round & participant address & CID together to simplify lookup when debugging

diff --git a/lib/typings.d.ts b/lib/typings.d.ts
@@ -20,6 +20,7 @@ export interface RetrievalTask {
 export interface RoundDetails {
   roundId: string; // BigInt serialized as String (JSON does not support BigInt)
   retrievalTasks: RetrievalTask[];
+  maxTasksPerNode: number;
 }
 
 export type RecordTelemetryFn = (
@@ -32,6 +33,7 @@ export type FraudAssesment =
   | 'OK'
   | 'INVALID_TASK'
   | 'DUP_INET_GROUP'
+  | 'TOO_MANY_TASKS'
 
 
 // When adding a new enum value, remember to update the summary initializer inside `reportRetrievalStats()`

diff --git a/test/evaluate.js b/test/evaluate.js
@@ -453,4 +453,45 @@ describe('fraud detection', () => {
       }
     })
   })
+
+  it('rejects measurements above maxTasksPerNode', async () => {
+    const sparkRoundDetails = {
+      roundId: 1234,
+      retrievalTasks: [
+        {
+          ...VALID_TASK,
+          cid: 'cid1'
+        }, {
+          ...VALID_TASK,
+          cid: 'cid2'
+        }, {
+          ...VALID_TASK,
+          cid: 'cid3'
+        }
+      ],
+      maxTasksPerNode: 1
+    }
+    const measurements = [
+      {
+        ...VALID_MEASUREMENT,
+        cid: 'cid1',
+        inet_group: 'group1'
+      },
+      {
+        ...VALID_MEASUREMENT,
+        cid: 'cid2',
+        inet_group: 'group1'
+      },
+      {
+        ...VALID_MEASUREMENT,
+        cid: 'cid3'
+      }
+    ]
+
+    await runFraudDetection(1, measurements, sparkRoundDetails)
+    assert.deepStrictEqual(
+      measurements.map(m => m.fraudAssessment),
+      ['OK', 'TOO_MANY_TASKS', 'OK']
+    )
+  })
 })