Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reward only first TN measurements per round. Closes #98 #101

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Reward only first TN measurements per round. Closes #98 #101

merged 4 commits into from
Dec 13, 2023

Conversation

juliangruber
Copy link
Member

Closes #98

@juliangruber juliangruber requested a review from bajtos December 13, 2023 13:40
bajtos
bajtos approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
LGTM with two minor comments to consider

juliangruber and others added 2 commits December 13, 2023 06:00
@juliangruber @bajtos
Update lib/evaluate.js
dc9ec13 
Co-authored-by: Miroslav Bajtoš <oss@bajtos.net>
@juliangruber @bajtos
Update lib/evaluate.js
3ff1d2b 
Co-authored-by: Miroslav Bajtoš <oss@bajtos.net>
@juliangruber juliangruber merged commit 224b0fd into main Dec 13, 2023
@juliangruber juliangruber deleted the add/reject-tn branch December 13, 2023 14:37
@bajtos bajtos mentioned this pull request Dec 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Space Meridian
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reward only first TN measurements per round
2 participants
@juliangruber @bajtos