Fix crash when previewing an offer created using WalletConnect #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeden
approved these changes
Oct 17, 2023
cmmarslender
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Nov 28, 2023
Fix typos by @omahs in Chia-Network/chia-blockchain-gui#2142 Fixed add plot directory button by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2199 fix by @paninaro in Chia-Network/chia-blockchain-gui#2202 Fix crash when previewing an offer created using WalletConnect by @paninaro in Chia-Network/chia-blockchain-gui#2201 Fix error when using file browser to import an offer by @paninaro in Chia-Network/chia-blockchain-gui#2203 Fix accidental mutation of the expiring offers defaults object by @paninaro in Chia-Network/chia-blockchain-gui#2214
ramdek18
pushed a commit
to ramdek18/new
that referenced
this pull request
Jun 6, 2024
* update readme with simulator farming by @zsolt-dev in Chia-Network/chia-blockchain-gui#2086 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2095 * Use the proper source branch when targeting something other than main by @cmmarslender in Chia-Network/chia-blockchain-gui#2104 * Fix typos by @omahs in Chia-Network/chia-blockchain-gui#2142 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2149 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2157 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2160 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2162 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2187 * Bump electron from 26.2.1 to 26.2.4 by @dependabot in Chia-Network/chia-blockchain-gui#2190 * Upgraded electron to 27.0.0 by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2195 * Hide compression option if bladebit version < 3 by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2196 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2193 * Fixed add plot directory button by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2199 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2197 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2198 * npm audit fix by @paninaro in Chia-Network/chia-blockchain-gui#2202 * Ensure enough bottom padding is available in the token list by @paninaro in Chia-Network/chia-blockchain-gui#2205 * Fix crash when previewing an offer created using WalletConnect by @paninaro in Chia-Network/chia-blockchain-gui#2201 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2208 * Don't show NFT collection options on the request side of the offer builder by @paninaro in Chia-Network/chia-blockchain-gui#2204 * Fix error when using file browser to import an offer by @paninaro in Chia-Network/chia-blockchain-gui#2203 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2213 * Fix accidental mutation of the expiring offers defaults object by @paninaro in Chia-Network/chia-blockchain-gui#2214 * Remove a redundant confirmation when deleting an offer notification by @paninaro in Chia-Network/chia-blockchain-gui#2215 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2217 * Bump browserify-sign from 4.2.1 to 4.2.2 by @dependabot in Chia-Network/chia-blockchain-gui#2216 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2218 * Added `insufficient_partials` stat item on farm page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2211 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2219 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2222 * added missing change directory command before running npm run dev by @RightSexyOrc in Chia-Network/chia-blockchain-gui#2221 * Bump axios from 1.4.0 to 1.6.0 by @dependabot in Chia-Network/chia-blockchain-gui#2225 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2226 * Added tooltip for missing sps by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2227 * Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2228 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2229 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2232 * @omahs made their first contribution in Chia-Network/chia-blockchain-gui#2142 * @RightSexyOrc made their first contribution in Chia-Network/chia-blockchain-gui#2221 **Full Changelog**: Chia-Network/chia-blockchain-gui@2.1.1-rc1...2.1.2-rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the WalletConnect
createOfferForIdscommand and clicking the 'Show Offer Details' button, OfferBuilderViewer would raise an exception due to a missingvalidTimesvalue.This fix addresses the crash by making the offerSummary.validTimes optional. Additional work needs to be done to support passing in
maxTimeto specify an expiring offer's duration but that's out of scope for this fix.