Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using file browser to import an offer #2203

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

paninaro
Copy link
Contributor

@paninaro paninaro commented Oct 16, 2023

Fixes #2184

When performing a drag & drop, the File object contains both the name and path properties. When selecting a file from the open dialog, only the name property is provided. This resulted in an error when attempting to stat the selected file's path, which would be "" when using the file open dialog. The workaround according to the react-dropzone docs is to use FileReader to read the file contents for the returned File object.

Also removes the offer import background image

Remove offer import background image
@paninaro paninaro merged commit 9a544c1 into main Oct 23, 2023
5 of 8 checks passed
@paninaro paninaro deleted the paninaro.fix_offer_import branch October 23, 2023 21:23
cmmarslender pushed a commit to Chia-Network/chia-blockchain that referenced this pull request Nov 28, 2023
Fix typos by @omahs in Chia-Network/chia-blockchain-gui#2142
Fixed add plot directory button by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2199
fix by @paninaro in Chia-Network/chia-blockchain-gui#2202
Fix crash when previewing an offer created using WalletConnect by @paninaro in Chia-Network/chia-blockchain-gui#2201
Fix error when using file browser to import an offer by @paninaro in Chia-Network/chia-blockchain-gui#2203
Fix accidental mutation of the expiring offers defaults object by @paninaro in Chia-Network/chia-blockchain-gui#2214
ramdek18 pushed a commit to ramdek18/new that referenced this pull request Jun 6, 2024
* update readme with simulator farming by @zsolt-dev in Chia-Network/chia-blockchain-gui#2086
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2095
* Use the proper source branch when targeting something other than main by @cmmarslender in Chia-Network/chia-blockchain-gui#2104
* Fix typos by @omahs in Chia-Network/chia-blockchain-gui#2142
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2149
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2157
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2160
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2162
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2187
* Bump electron from 26.2.1 to 26.2.4 by @dependabot in Chia-Network/chia-blockchain-gui#2190
* Upgraded electron to 27.0.0 by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2195
* Hide compression option if bladebit version < 3 by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2196
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2193
* Fixed add plot directory button by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2199
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2197
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2198
* npm audit fix by @paninaro in Chia-Network/chia-blockchain-gui#2202
* Ensure enough bottom padding is available in the token list by @paninaro in Chia-Network/chia-blockchain-gui#2205
* Fix crash when previewing an offer created using WalletConnect by @paninaro in Chia-Network/chia-blockchain-gui#2201
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2208
* Don't show NFT collection options on the request side of the offer builder by @paninaro in Chia-Network/chia-blockchain-gui#2204
* Fix error when using file browser to import an offer by @paninaro in Chia-Network/chia-blockchain-gui#2203
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2213
* Fix accidental mutation of the expiring offers defaults object by @paninaro in Chia-Network/chia-blockchain-gui#2214
* Remove a redundant confirmation when deleting an offer notification by @paninaro in Chia-Network/chia-blockchain-gui#2215
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2217
* Bump browserify-sign from 4.2.1 to 4.2.2 by @dependabot in Chia-Network/chia-blockchain-gui#2216
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2218
* Added `insufficient_partials` stat item on farm page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2211
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2219
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2222
* added missing change directory command before running npm run dev by @RightSexyOrc in Chia-Network/chia-blockchain-gui#2221
* Bump axios from 1.4.0 to 1.6.0 by @dependabot in Chia-Network/chia-blockchain-gui#2225
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2226
* Added tooltip for missing sps by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2227
* Latest Strings by @github-actions in Chia-Network/chia-blockchain-gui#2228
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2229
* New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2232

* @omahs made their first contribution in Chia-Network/chia-blockchain-gui#2142
* @RightSexyOrc made their first contribution in Chia-Network/chia-blockchain-gui#2221

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.1.1-rc1...2.1.2-rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browsing to open offer fails [Bug]
2 participants