Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code related to no-longer-used websockets library #11123

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Remove code related to no-longer-used websockets library #11123

merged 3 commits into from
Apr 20, 2022

Conversation

altendky
Copy link
Contributor

Follow up after #10611.

hoffmang9
hoffmang9 previously approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jack60612
jack60612 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jack60612
Copy link
Contributor

@altendky can you also remove websockets from

chia-blockchain/pylintrc

Line 253 in 2a6564c

websockets,
And

chia-blockchain/tests/core/daemon/test_daemon.py

Line 88 in c542606

# Suppress warning: "The explicit passing of coroutine objects to asyncio.wait() is deprecated since Python 3.8..."

jack60612
jack60612 requested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all logging tweaks were removed, check my comments.

@altendky altendky changed the title Remove logging tweak for no-longer-used websockets library Remove code related to no-longer-used websockets library Apr 11, 2022
@altendky altendky requested a review from jack60612 April 11, 2022 01:29
jack60612
jack60612 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm and sorry for missing that before.

@altendky altendky added the ready_to_merge Submitter and reviewers think this is ready label Apr 11, 2022
@wjblanke wjblanke merged commit 1088801 into main Apr 20, 2022
@wjblanke wjblanke deleted the altendky-patch-8 branch April 20, 2022 18:18
emlowe pushed a commit that referenced this pull request Apr 21, 2022
@altendky @emlowe
Remove code related to no-longer-used websockets library (#11123)
2fbe8c0 
* Remove logging tweak for no-longer-used websockets library

Follow up after #10611.

* Update pylintrc

* Update test_daemon.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack60612 jack60612 jack60612 approved these changes

@hoffmang9 hoffmang9 hoffmang9 left review comments

Assignees
No one assigned
Labels
ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altendky @jack60612 @hoffmang9 @wjblanke