Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related to no-longer-used websockets library #11123

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Remove code related to no-longer-used websockets library #11123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
581977c
Remove logging tweak for no-longer-used websockets library
altendky Apr 10, 2022
41823d2
Update pylintrc
altendky Apr 11, 2022
0a42b6f
Update test_daemon.py
altendky Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion chia/util/chia_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def initialize_logging(service_name: str, logging_config: Dict, root_path: Path)
elif logging_config["log_level"] == "DEBUG":
logger.setLevel(logging.DEBUG)
logging.getLogger("aiosqlite").setLevel(logging.INFO) # Too much logging on debug level
logging.getLogger("websockets").setLevel(logging.INFO) # Too much logging on debug level
else:
logger.setLevel(logging.INFO)
else:
Expand Down
1 change: 0 additions & 1 deletion pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ ignored-modules=blspy,
chiavdf,
cryptography,
aiohttp,
websockets,
keyring,
keyrings.cryptfile,
bitstring,
Expand Down
6 changes: 0 additions & 6 deletions tests/core/daemon/test_daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@ async def reader(ws, queue):
read_handler.cancel()
assert blockchain_state_found

# Suppress warning: "The explicit passing of coroutine objects to asyncio.wait() is deprecated since Python 3.8..."
# Can be removed when we upgrade to a newer version of websockets (9.1 works)
@pytest.mark.filterwarnings("ignore::DeprecationWarning:websockets.*")
@pytest.mark.asyncio
async def test_validate_keyring_passphrase_rpc(self, get_daemon_with_temp_keyring):
local_b_tools: BlockTools = get_daemon_with_temp_keyring[0]
Expand Down Expand Up @@ -169,9 +166,6 @@ async def check_empty_passphrase_case(response: aiohttp.http_websocket.WSMessage
# Expect: validation failure
await check_empty_passphrase_case(await ws.receive())

# Suppress warning: "The explicit passing of coroutine objects to asyncio.wait() is deprecated since Python 3.8..."
# Can be removed when we upgrade to a newer version of websockets (9.1 works)
@pytest.mark.filterwarnings("ignore::DeprecationWarning:websockets.*")
@pytest.mark.asyncio
async def test_add_private_key(self, get_daemon_with_temp_keyring):
local_b_tools: BlockTools = get_daemon_with_temp_keyring[0]
Expand Down