-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pool url on redirect #17384
Update pool url on redirect #17384
Conversation
5a61b57
to
4952d73
Compare
Needs a test to execise this code - take a look at |
Edit: or i just skip all the redirect logic in aiohttp and return the final response with the url being different from the requested url, thinking about that now it's probably the better way anyway as how redirects are handled by aiohttp is not in scope here. I'll implement a test using this later 👍 |
@emlowe added tests 👍 |
close and reopen to pickup hopefully some CI fixes |
coverage diff exemption |
Purpose:
Support the migration of pool farmer api urls: when a pool changes its farmer api url, the client persists the new url to be able to continue to communicate with the pool should the old url stop working in the future.
Current Behavior:
Pools can already setup redirects to a new farmer api url and they will get used correctly, however the new url is not persisted by the client.
New Behavior:
When a url change is detected the new url is persisted.