Fix new pool url detection #18521
Merged
Fix new pool url detection #18521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbrucker
force-pushed
the
fix-new-pool-url-detection
branch
from
5a2059f to
2d489da
Compare
felixbrucker
force-pushed
the
fix-new-pool-url-detection
branch
from
2d489da to
896e934
Compare
arvidn
previously approved these changes
Aug 25, 2024
pmaslana
added
Fixed
emlowe
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17384 introduced a new feature which updates the pool url in the config file, if a change is detected. This however always triggered (bug), but only updated the config if the url actually differed.
With the addition of #18341 an error log line was (incorrectly) added, which made this bug visible, as currently the only use of the function should always produce a config update (but that does not need to be the case).
This PR fixes the bug and removes the incorrect error log line, any errors in the closure are caught by the try/except block. If we want to log whether the config entry was found we need another variable to keep track of that, as
updatedis not suitable for that.