[CHIA-1736] catchup: long_lived/vault from main @ 08730a266b201e487ca1d361e108491f7862d81b #18852

Quexington · 2024-11-12T15:37:08Z

Source hash: 08730a2
Remaining commits: 0
Merge diffs: https://quexington.github.io/merge-diffs/50b997ed7024ac6f4fceb6dbdddeecf126503355.html

* Replace black with Ruff * Change build_network_protocol_files.py

* Use #!/usr/bin/env bash * Update setup-poetry.sh * Use #!/usr/bin/env bash for shebang * fix up typo for leading space * For consistency fix up a few other scripts

* more `start_*` service starting consistency * fixup * Update start_full_node.py

Move obtain_current_passphrase next to KeyringWrapper.

Annotate chia/rpc/util.py.

* Miscellaneous Ruff cleanups * Migrate pyproject.toml to ruff.toml

…ansactions (#18829) Speedup get_header_blocks_in_range w.r.t. blocks with no transactions.

Update full_node_simulator.py

… links (#18803) * Add new flag to support recurvely scanning and following links * black fix * hardlink_to only in python 3.10+ * Remove unneeded hardlink checks as hardlinks to directories aren't a thing * Minor update per code review * use boolean_datacases * Add new flag to initial-config

…18812) * use run_block_generator() directly in block creation, to compute the final cost of the block we're creating. This lets us avoid validating the signature (to save time) and run in mempool mode * always validate signatures in run_block_generator(). * remove PreValidationResult.validated_signature and instead defer to the inner SpendBundleConditions field

Bumps [keyring](https://github.com/jaraco/keyring) from 25.2.1 to 25.5.0. - [Release notes](https://github.com/jaraco/keyring/releases) - [Changelog](https://github.com/jaraco/keyring/blob/main/NEWS.rst) - [Commits](jaraco/keyring@v25.2.1...v25.5.0) --- updated-dependencies: - dependency-name: keyring dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [clvm](https://github.com/Chia-Network/clvm) from 0.9.10 to 0.9.11. - [Release notes](https://github.com/Chia-Network/clvm/releases) - [Changelog](https://github.com/Chia-Network/clvm/blob/main/HISTORY.org) - [Commits](Chia-Network/clvm@0.9.10...0.9.11) --- updated-dependencies: - dependency-name: clvm dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* explicitly collect api methods instead of later using getattr * api as a class itself * tidy * fixup * tidier * and... * fixup * oops * mm * hum * fixup * monkey patching helper * ... * tidy * back to instances * fix * self-patch * duplicate original request attributes * Update chia/_tests/wallet/sync/test_wallet_sync.py Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org> * test that `@metadata.request()` fails on repeated request type * ... --------- Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>

…date_wp (#18830) Handle index error on empty peers with peak in request_validate_wp.

ignore ephemeral spends in mempool superset rule

Bumps [pyyaml](https://github.com/yaml/pyyaml) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/main/CHANGES) - [Commits](yaml/pyyaml@6.0.1...6.0.2) --- updated-dependencies: - dependency-name: pyyaml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…long_lived_vault_from_main_08730a266b201e487ca1d361e108491f7862d81b

socket-security · 2024-11-12T15:37:39Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
pypi/importlib-metadata@7.2.1	environment, filesystem, unsafe Transitive: eval, network, shell	`+236`	834 MB	barry, brettcannon, jaraco

🚮 Removed packages: pypi/black@24.8.0, pypi/clvm@0.9.10, pypi/importlib-metadata@6.11.0, pypi/keyring@25.2.1, pypi/pathspec@0.11.2, pypi/pyyaml@6.0.1

View full report↗︎

The base branch was changed.

socket-security · 2024-11-12T18:13:38Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: pypi/importlib-metadata@7.2.1, pypi/importlib-metadata@7.2.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

Quexington · 2024-11-12T18:20:23Z

@SocketSecurity ignore pypi/importlib-metadata@7.2.1

github-actions · 2024-11-12T19:16:46Z

File	Coverage	Missing Lines
`chia/consensus/blockchain.py`	71.4%	lines 699, 720
`chia/consensus/multiprocess_validation.py`	92.0%	lines 50, 147
`chia/full_node/full_node.py`	80.0%	lines 1023
`chia/util/keyring_wrapper.py`	57.1%	lines 70-73, 99, 102-103, 105, 107, 109-111, 113-115
`chia/wallet/vault/vault_wallet.py`	33.3%	lines 433, 453

Total	Missing	Coverage
580 lines	22 lines	96%

coveralls-official · 2024-11-12T19:23:30Z

Pull Request Test Coverage Report for Build 11803225894

Details

558 of 580 (96.21%) changed or added relevant lines in 65 files are covered.
24 unchanged lines in 9 files lost coverage.
Overall coverage increased (+0.02%) to 91.046%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
chia/full_node/full_node.py	4	5	80.0%
chia/consensus/blockchain.py	5	7	71.43%
chia/consensus/multiprocess_validation.py	23	25	92.0%
chia/wallet/vault/vault_wallet.py	1	3	33.33%
chia/util/keyring_wrapper.py	20	35	57.14%

Files with Coverage Reduction	New Missed Lines	%
chia/util/config.py	1	84.62%
chia/data_layer/util/benchmark.py	1	0.0%
chia/_tests/wallet/test_wallet_node.py	1	99.79%
chia/util/files.py	2	91.38%
chia/timelord/timelord_launcher.py	2	89.29%
chia/server/ws_connection.py	2	88.99%
chia/server/node_discovery.py	3	80.18%
chia/wallet/wallet_node.py	5	88.32%
chia/daemon/server.py	7	83.29%

Totals
Change from base Build 11690227671:	0.02%
Covered Lines:	104587
Relevant Lines:	114645

💛 - Coveralls

Quexington and others added 21 commits November 4, 2024 15:22

[CHIA-1681] Replace black with Ruff (#18813)

2808ee2

* Replace black with Ruff * Change build_network_protocol_files.py

Use #!/usr/bin/env bash (#18762)

e07d1eb

* Use #!/usr/bin/env bash * Update setup-poetry.sh * Use #!/usr/bin/env bash for shebang * fix up typo for leading space * For consistency fix up a few other scripts

more start_* service starting consistency (#18775)

3f6977f

* more `start_*` service starting consistency * fixup * Update start_full_node.py

CHIA-1684 Move obtain_current_passphrase next to KeyringWrapper (#18787)

0d8920a

Move obtain_current_passphrase next to KeyringWrapper.

CHIA-1692 Annotate chia/rpc/util.py (#18798)

da607b2

Annotate chia/rpc/util.py.

[CHIA-1689] Miscellaneous ruff cleanups (#18817)

42541ae

* Miscellaneous Ruff cleanups * Migrate pyproject.toml to ruff.toml

Fix pre-commit in chia/rpc/util.py (#18823)

15079c6

CHIA-1716 Speedup get_header_blocks_in_range w.r.t. blocks with no tr…

816462d

…ansactions (#18829) Speedup get_header_blocks_in_range w.r.t. blocks with no transactions.

Await self_is_synced() (#18772)

7dd1324

Update full_node_simulator.py

Update Managed Files (#18821)

315f4bf

Fix incorrect comment about default hidden puzzle (#18820)

c7a7d4e

CHIA-1717 Handle index error on empty peers with peak in request_vali…

569a47c

…date_wp (#18830) Handle index error on empty peers with peak in request_validate_wp.

[CHIA-1703] ignore ephemeral spends in mempool superset rule (#18834)

80911d4

ignore ephemeral spends in mempool superset rule

the mempool thread pool should not set the process name (#18842)

c4ac6c7

Merge commit '08730a266b201e487ca1d361e108491f7862d81b' into catchup/…

3388690

…long_lived_vault_from_main_08730a266b201e487ca1d361e108491f7862d81b

Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 12, 2024

Ruff format

e235ed5

Quexington changed the title ~~catchup: long_lived/vault from main @ 08730a266b201e487ca1d361e108491f7862d81b~~ [CHIA-1736] catchup: long_lived/vault from main @ 08730a266b201e487ca1d361e108491f7862d81b Nov 12, 2024

Quexington marked this pull request as ready for review November 12, 2024 16:24

Quexington requested a review from a team as a code owner November 12, 2024 16:24

geoffwalmsley previously approved these changes Nov 12, 2024

View reviewed changes

markelrod previously approved these changes Nov 12, 2024

View reviewed changes

github-actions bot added the coverage-diff label Nov 12, 2024

Quexington changed the base branch from main to long_lived/vault November 12, 2024 18:12

Quexington requested a review from a team as a code owner November 12, 2024 18:12

Quexington closed this Nov 12, 2024

Quexington reopened this Nov 12, 2024

markelrod approved these changes Nov 12, 2024

View reviewed changes

cmmarslender approved these changes Nov 12, 2024

View reviewed changes

Quexington merged commit fecb484 into long_lived/vault Nov 12, 2024
718 of 720 checks passed

Quexington deleted the catchup/long_lived_vault_from_main_08730a266b201e487ca1d361e108491f7862d81b branch November 12, 2024 20:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHIA-1736] catchup: long_lived/vault from main @ 08730a266b201e487ca1d361e108491f7862d81b #18852

[CHIA-1736] catchup: long_lived/vault from main @ 08730a266b201e487ca1d361e108491f7862d81b #18852

Quexington commented Nov 12, 2024 •

edited

Loading

socket-security bot commented Nov 12, 2024 •

edited

Loading

socket-security bot commented Nov 12, 2024 •

edited

Loading

Quexington commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

coveralls-official bot commented Nov 12, 2024

[CHIA-1736] catchup: long_lived/vault from main @ 08730a266b201e487ca1d361e108491f7862d81b #18852

[CHIA-1736] catchup: long_lived/vault from main @ 08730a266b201e487ca1d361e108491f7862d81b #18852

Conversation

Quexington commented Nov 12, 2024 • edited Loading

socket-security bot commented Nov 12, 2024 • edited Loading

socket-security bot commented Nov 12, 2024 • edited Loading

Next steps

Quexington commented Nov 12, 2024

github-actions bot commented Nov 12, 2024

coveralls-official bot commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11803225894

Details

💛 - Coveralls

Quexington commented Nov 12, 2024 •

edited

Loading

socket-security bot commented Nov 12, 2024 •

edited

Loading

socket-security bot commented Nov 12, 2024 •

edited

Loading