Fix update user (go-gitea#18878)

Chianina · Mar 28, 2022 · e1d8d25 · e1d8d25
1 parent e3ed0ef
commit e1d8d25
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/models/user/user.go b/models/user/user.go
@@ -868,13 +868,14 @@ func updateUser(ctx context.Context, u *User, changePrimaryEmail bool, cols ...s
 		}
 
 		if !primaryEmailExist {
-			_, err = e.Insert(&EmailAddress{
+			if _, err := e.Insert(&EmailAddress{
 				Email:       u.Email,
 				UID:         u.ID,
 				IsActivated: true,
 				IsPrimary:   true,
-			})
-			return err
+			}); err != nil {
+				return err
+			}
 		}
 	}