Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update user #18878

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix update user #18878

merged 2 commits into from
Feb 24, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 24, 2022

Fix a bug caused by #18786

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 24, 2022
@lunny lunny mentioned this pull request Feb 24, 2022
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2022
@delvh delvh added this to the 1.17.0 milestone Feb 24, 2022
6543
6543 reviewed Feb 24, 2022
View reviewed changes
models/user/user.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@f1b1472). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18878   +/-   ##
=======================================
  Coverage        ?   46.61%           
=======================================
  Files           ?      853           
  Lines           ?   122512           
  Branches        ?        0           
=======================================
  Hits            ?    57114           
  Misses          ?    58503           
  Partials        ?     6895
Impacted Files Coverage Δ
models/user/user.go 57.97% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b1472...580da52. Read the comment docs.

@6543 6543 merged commit 6621710 into go-gitea:main Feb 24, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
85feb59 
* giteaofficial/main:
  Prevent Stats Indexer reporting error if repo dir missing (go-gitea#18870)
  [skip ci] Updated translations via Crowdin
  Fix update user (go-gitea#18878)
@lunny lunny deleted the lunny/fix_update_user branch February 25, 2022 06:49
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Fix update user (go-gitea#18878)
e1d8d25
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@6543 6543 6543 approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-commenter @KN4CK3R @6543 @delvh @GiteaBot