-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Stats Indexer reporting error if repo dir missing #18870
Merged
techknowlogick
merged 2 commits into
go-gitea:main
from
zeripath:do-not-report-error-for-missing-repo-in-stats
Feb 25, 2022
Merged
Prevent Stats Indexer reporting error if repo dir missing #18870
techknowlogick
merged 2 commits into
go-gitea:main
from
zeripath:do-not-report-error-for-missing-repo-in-stats
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repositories missing their directory should not report an error from the stats indexer. Close go-gitea#18847 Signed-off-by: Andrew Thornton <art27@cantab.net>
Gusted
approved these changes
Feb 23, 2022
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Feb 23, 2022
Could be backported to 1.16 - but should not hold up releases |
silverwind
reviewed
Feb 23, 2022
silverwind
approved these changes
Feb 23, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #18870 +/- ##
==========================================
- Coverage 46.64% 46.58% -0.07%
==========================================
Files 846 853 +7
Lines 121331 122514 +1183
==========================================
+ Hits 56595 57068 +473
- Misses 57859 58554 +695
- Partials 6877 6892 +15
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 25, 2022
* giteaofficial/main: Prevent Stats Indexer reporting error if repo dir missing (go-gitea#18870) [skip ci] Updated translations via Crowdin Fix update user (go-gitea#18878)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…8870) Repositories missing their directory should not report an error from the stats indexer. Close go-gitea#18847 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repositories missing their directory should not report an error from the stats
indexer.
Close #18847
Signed-off-by: Andrew Thornton art27@cantab.net